Skip to content

Commit 272685a

Browse files
fix(docker-build): allow dry-runs by always running build (even if push is disabled)
1 parent a5984e8 commit 272685a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/docker-build.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ jobs:
6767
password: ${{ secrets.password }}
6868

6969
- name: Build Docker Image
70-
if: ${{ inputs.push }}
7170
uses: docker/build-push-action@v6
7271
with:
7372
context: ${{ inputs.context }}

docker-build/README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,12 @@ This reusable GitHub Actions workflow automates the process of building and push
1515

1616
## ⚙️ Inputs
1717

18-
| Name | Description | Required | Default |
19-
| ------------ | -------------------------------------------------------------------------------- | -------- | -------------- |
20-
| `image-name` | Tag to apply to the built image (e.g., 'myimage:latest', 'myorg/myimage:v1.2.3') | true | - |
21-
| `image-tag` | Tag to apply to the built image (e.g., 'latest', 'v1.2.3') | No | `"latest"` |
22-
| `dockerfile` | Path to the Dockerfile to build (e.g., './Dockerfile', './docker/Dockerfile') | No | `"Dockerfile"` |
18+
| Name | Description | Required | Default |
19+
| ------------ | ----------------------------------------------------------------------------- | -------- | -------------- |
20+
| `image-name` | Name of Docker Image (e.g., 'myimage', 'myorg/myimage') | true | - |
21+
| `image-tag` | Tag to apply to the built image (e.g., 'latest', 'v1.2.3') | No | `"latest"` |
22+
| `dockerfile` | Path to the Dockerfile to build (e.g., './Dockerfile', './docker/Dockerfile') | No | `"Dockerfile"` |
23+
| `push` | Push Docker Image to Registry | No | `false` |
2324

2425
## 🔐 Secrets
2526

0 commit comments

Comments
 (0)