Skip to content

Commit d0c027a

Browse files
PierreJeanjacquotPierreJeanjacquot
authored
fix!: remove useless command option (#83)
1 parent 932083a commit d0c027a

File tree

2 files changed

+15
-22
lines changed

2 files changed

+15
-22
lines changed

‎.github/workflows/sconify.yml‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ on:
2323
description: "Path of the binary to use"
2424
type: string
2525
required: true
26-
command:
27-
description: "Command to execute (default: ENTRYPOINT + CMD of native image)"
28-
type: string
2926
binary-fs:
3027
description: "Embed the file system into the binary via Scone binary file system (default: false)"
3128
type: boolean
@@ -133,8 +130,6 @@ jobs:
133130
# --binary
134131
SCONIFY_CMD+=" --binary=${{ inputs.binary }}"
135132
# OPTIONAL:
136-
# --command option
137-
[[ -n '${{ inputs.command }}' ]] && SCONIFY_CMD+=" --command=${{ inputs.command }}"
138133
# --host-path variadic option
139134
while IFS= read -r line; do [[ -n "$line" ]] && SCONIFY_CMD+=" --host-path=$line" ; done <<< '${{ inputs.host-path }}'
140135
# BINARY FILE SYSTEM (binary fs):

‎sconify/README.md‎

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -22,22 +22,21 @@ The workflow performs the following actions:
2222

2323
## Workflow Inputs 🛠️
2424

25-
| **Input** | **Description** | **Required** | **Default** |
26-
| ------------------- | -------------------------------------------------------------------------------------------------------- | ------------ | -------------------------------- |
27-
| **docker-registry** | Docker registry of docker image to sconify | No | docker.io |
28-
| **docker-username** | Docker registry username | Yes | - |
29-
| **image-name** | Name of docker image to sconify | Yes | - |
30-
| **image-tag** | Tag of docker image to sconify | Yes | - |
31-
| **sconify-version** | Version of the sconify image to use | Yes | - |
32-
| **binary** | [SCONE] Path of the binary to use | Yes | - |
33-
| **command** | [SCONE] Command to execute | No | ENTRYPOINT + CMD of native image |
34-
| **binary-fs** | [SCONE] Embed the file system into the binary via Scone binary file system | No | false |
35-
| **fs-dir** | [SCONE] Path of directories to add to the binary file system (use multiline to add multiple directories) | No | - |
36-
| **fs-file** | [SCONE] Path of files to add to the binary file system (use multiline to add multiple files) | No | - |
37-
| **host-path** | [SCONE] Host path, served directly from the host file system (use multiline to add multiple path) | No | - |
38-
| **heap** | [SCONE] Enclave heap size | No | 1G |
39-
| **dlopen** | [SCONE] Scone dlopen mode (0:disable; 1:enable) | No | 0 |
40-
| **mprotect** | [SCONE] Scone mprotect mode (0:disable; 1:enable) | No | 0 |
25+
| **Input** | **Description** | **Required** | **Default** |
26+
| ------------------- | -------------------------------------------------------------------------------------------------------- | ------------ | ----------- |
27+
| **docker-registry** | Docker registry of docker image to sconify | No | docker.io |
28+
| **docker-username** | Docker registry username | Yes | - |
29+
| **image-name** | Name of docker image to sconify | Yes | - |
30+
| **image-tag** | Tag of docker image to sconify | Yes | - |
31+
| **sconify-version** | Version of the sconify image to use | Yes | - |
32+
| **binary** | [SCONE] Path of the binary to use | Yes | - |
33+
| **binary-fs** | [SCONE] Embed the file system into the binary via Scone binary file system | No | false |
34+
| **fs-dir** | [SCONE] Path of directories to add to the binary file system (use multiline to add multiple directories) | No | - |
35+
| **fs-file** | [SCONE] Path of files to add to the binary file system (use multiline to add multiple files) | No | - |
36+
| **host-path** | [SCONE] Host path, served directly from the host file system (use multiline to add multiple path) | No | - |
37+
| **heap** | [SCONE] Enclave heap size | No | 1G |
38+
| **dlopen** | [SCONE] Scone dlopen mode (0:disable; 1:enable) | No | 0 |
39+
| **mprotect** | [SCONE] Scone mprotect mode (0:disable; 1:enable) | No | 0 |
4140

4241
| **sconify-debug** | Create Scone debug image | No | true |
4342
| **sconify-prod** | Create Scone production image | No | true |
@@ -106,7 +105,6 @@ jobs:
106105
docker-registry: docker.io
107106
sconify-version: 5.9.0-v15
108107
binary: /usr/local/bin/node
109-
command: node /app/src/app.js
110108
host-path: |
111109
/etc/hosts
112110
/etc/resolv.conf

0 commit comments

Comments
 (0)