refactor: rename target-address to transaction-target-address in README, workflow, and source code for consistency

Author: Le-Caignec

safe-transaction/.github/workflows/safe-transaction.yml

@@ -15,7 +15,7 @@ on:
         description: 'Address of the Safe contract'
         required: true
         type: string
-      target-address:
+      transaction-target-address:
         description: 'Target address for the transaction'
         required: true
         type: string
@@ -38,11 +38,6 @@ on:
         required: false
         default: '0x'
         type: string
-      operation:
-        description: 'Operation type (0 for Call, 1 for DelegateCall)'
-        required: false
-        default: '0'
-        type: string
     outputs:
       safe-tx-hash:
         description: 'Hash of the Safe transaction'
@@ -80,10 +75,9 @@ jobs:
           INPUT_PROPOSER_PRIVATE_KEY: ${{ inputs.proposer-private-key }}
           INPUT_RPC_URL: ${{ inputs.rpc-url }}
           INPUT_SAFE_ADDRESS: ${{ inputs.safe-address }}
-          INPUT_TARGET_ADDRESS: ${{ inputs.target-address }}
+          INPUT_TARGET_ADDRESS: ${{ inputs.transaction-target-address }}
           INPUT_SAFE_API_KEY: ${{ inputs.safe-api-key }}
           INPUT_CHAIN_ID: ${{ inputs.chain-id }}
           INPUT_TRANSACTION_VALUE: ${{ inputs.transaction-value }}
           INPUT_TRANSACTION_DATA: ${{ inputs.transaction-data }}
-          INPUT_OPERATION: ${{ inputs.operation }}
         id: safe-transaction

safe-transaction/README.md

@@ -11,12 +11,11 @@ This reusable GitHub Actions workflow automates the process of creating and prop
 | **proposer-private-key** | Private key of the proposer wallet                           | Yes          | -                                   |
 | **rpc-url**              | RPC URL for the blockchain network                            | Yes          | -                                   |
 | **safe-address**         | Address of the Safe contract                                  | Yes          | -                                   |
-| **target-address**       | Target address for the transaction                            | Yes          | -                                   |
+| **transaction-target-address** | Target address for the transaction                            | Yes          | -                                   |
 | **safe-api-key**         | Safe API key for transaction service                          | Yes          | -                                   |
 | **chain-id**             | Chain ID of the blockchain network                            | No           | `42161` (Arbitrum)                  |
 | **transaction-value**    | Value to send in the transaction (in wei)                     | No           | `0`                                 |
 | **transaction-data**     | Transaction data/calldata                                     | No           | `0x`                                |
-| **operation**            | Operation type (0 for Call, 1 for DelegateCall)              | No           | `0`                                 |
 
 ## Workflow Outputs 📤
 
@@ -48,7 +47,7 @@ This reusable GitHub Actions workflow automates the process of creating and prop
          safe-address:
            description: 'Safe contract address'
            required: true
-         target-address:
+         transaction-target-address:
            description: 'Target contract address'
            required: true
          transaction-data:
@@ -65,7 +64,7 @@ This reusable GitHub Actions workflow automates the process of creating and prop
          safe-api-key: ${{ secrets.SAFE_API_KEY }}
        with:
          safe-address: ${{ inputs.safe-address }}
-         target-address: ${{ inputs.target-address }}
+         transaction-target-address: ${{ inputs.transaction-target-address }}
          transaction-data: ${{ inputs.transaction-data }}
    ```
 
@@ -74,11 +73,6 @@ This reusable GitHub Actions workflow automates the process of creating and prop
    - `PROPOSER_PRIVATE_KEY`: The private key of the wallet that will propose the transaction
    - `SAFE_API_KEY`: Your Safe API key for the transaction service
 
-## Operation Types 🔧
-
-- **`0`**: **Call** - Normal transaction execution
-- **`1`**: **DelegateCall** - Execution in the context of the Safe contract
-
 ## Security Considerations 🛡️
 
 ⚠️ **Important**: Never expose private keys in logs or code files. Always use GitHub Secrets to store sensitive information securely.

safe-transaction/src/index.js

@@ -10,16 +10,17 @@ async function run() {
     const proposerPrivateKey = process.env.INPUT_PROPOSER_PRIVATE_KEY;
     const rpcUrl = process.env.INPUT_RPC_URL;
     const safeAddress = process.env.INPUT_SAFE_ADDRESS;
-    const targetAddress = process.env.INPUT_TARGET_ADDRESS;
+    const transactionTargetAddress = process.env.INPUT_TARGET_ADDRESS;
     const safeApiKey = process.env.INPUT_SAFE_API_KEY;
-    const chainId = BigInt(process.env.INPUT_CHAIN_ID || '42161');
-    const transactionValue = process.env.INPUT_TRANSACTION_VALUE || '0';
-    const transactionData = process.env.INPUT_TRANSACTION_DATA || '0x';
-    const operation = process.env.INPUT_OPERATION || '0';
+    const chainId = BigInt(process.env.INPUT_CHAIN_ID || "42161");
+    const transactionValue = process.env.INPUT_TRANSACTION_VALUE || "0";
+    const transactionData = process.env.INPUT_TRANSACTION_DATA || "0x";
+    // Hardcoded to 0 (Call operation) - DelegateCall (1) is not supported for security reasons
+    const operation = 0;
 
     core.info(`🚀 Starting Safe transaction creation...`);
     core.info(`📍 Safe Address: ${safeAddress}`);
-    core.info(`🎯 Target Address: ${targetAddress}`);
+    core.info(`🎯 Target Address: ${transactionTargetAddress}`);
 
     // Initialize wallet
     const wallet = new Wallet(proposerPrivateKey);
@@ -28,27 +29,27 @@ async function run() {
     // Initialize API Kit
     const apiKit = new SafeApiKit({
       chainId: chainId,
-      apiKey: safeApiKey
+      apiKey: safeApiKey,
     });
 
     // Initialize Protocol Kit
     const protocolKit = await Safe.init({
       provider: rpcUrl,
       signer: proposerPrivateKey,
-      safeAddress: safeAddress
+      safeAddress: safeAddress,
     });
 
     // Create transaction
     const safeTransactionData = {
-      to: targetAddress,
+      to: transactionTargetAddress,
       value: transactionValue,
       data: transactionData,
-      operation: parseInt(operation)
+      operation: parseInt(operation),
     };
 
-    core.info('📝 Creating Safe transaction...');
+    core.info("📝 Creating Safe transaction...");
     const safeTransaction = await protocolKit.createTransaction({
-      transactions: [safeTransactionData]
+      transactions: [safeTransactionData],
     });
 
     const safeTxHash = await protocolKit.getTransactionHash(safeTransaction);
@@ -62,22 +63,23 @@ async function run() {
       safeTransactionData: safeTransaction.data,
       safeTxHash: safeTxHash,
       senderAddress: wallet.address,
-      senderSignature: signature.data
+      senderSignature: signature.data,
     });
 
-    core.info('📤 Transaction proposed to Safe service');
+    core.info("📤 Transaction proposed to Safe service");
 
     // Get transaction details
     const transaction = await apiKit.getTransaction(safeTxHash);
-    
+
     // Set outputs
-    core.setOutput('safe-tx-hash', safeTxHash);
-    core.setOutput('transaction', JSON.stringify(transaction));
+    core.setOutput("safe-tx-hash", safeTxHash);
+    core.setOutput("transaction", JSON.stringify(transaction));
 
     core.info(`✅ Transaction created successfully!`);
     core.info(`🔗 Transaction Hash: ${safeTxHash}`);
-    core.info(`📋 Transaction Details: ${JSON.stringify(transaction, null, 2)}`);
-
+    core.info(
+      `📋 Transaction Details: ${JSON.stringify(transaction, null, 2)}`
+    );
   } catch (error) {
     core.setFailed(`❌ Error creating Safe transaction: ${error.message}`);
     core.error(error.stack);