fix!: rename iAppAddress and appContractAddress to app in cache files for consistency

Author: PierreJeanjacquot

cli/src/cmd/deploy.ts

@@ -146,7 +146,7 @@ export async function deploy({ chain }: { chain?: string }) {
     // Add deployment data to deployments.json
     await addDeploymentData({
       image: appDockerImage,
-      appContractAddress: appContractAddress,
+      app: appContractAddress,
       owner: userAddress,
       chainName,
     });

cli/src/cmd/run.ts

@@ -219,7 +219,7 @@ export async function run({
     spinner.start('Matching orders...');
     const { dealid, txHash } = await iexec.order.matchOrders(matchOrderParams);
     const taskid = await iexec.deal.computeTaskId(dealid, 0);
-    await addRunData({ iAppAddress, dealid, taskid, txHash, chainName });
+    await addRunData({ app: iAppAddress, dealid, taskid, txHash, chainName });
     spinner.succeed(
       `Deal created successfully
   - deal: ${dealid} ${color.link(`${chainConfig.iexecExplorerUrl}/deal/${dealid}`)}

cli/src/utils/cacheExecutions.ts

@@ -34,20 +34,20 @@ async function addDataToCache(
 
 // Function to add run data to runs.json
 export async function addRunData({
-  iAppAddress,
+  app,
   dealid,
   taskid,
   txHash,
   chainName,
 }: {
-  iAppAddress: string;
+  app: string;
   dealid: string;
   taskid: string;
   txHash: string;
   chainName: string;
 }) {
   const runData = {
-    iAppAddress,
+    app,
     dealid,
     taskid,
     txHash,
@@ -58,18 +58,18 @@ export async function addRunData({
 // Function to add deployment data to deployments.json
 export async function addDeploymentData({
   image,
-  appContractAddress,
+  app,
   owner,
   chainName,
 }: {
   image: string;
-  appContractAddress: string;
+  app: string;
   owner: string;
   chainName: string;
 }) {
   const deploymentData = {
     image,
-    appContractAddress,
+    app,
     owner,
   };
   await addDataToCache('deployments.json', chainName, deploymentData);