Skip to content

Commit 917da8b

Browse files
fix: remove useless sconification option "command"
1 parent 4ba525a commit 917da8b

File tree

3 files changed

+1
-9
lines changed

3 files changed

+1
-9
lines changed

api/src/sconify/deprecated_sconify.service.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ export async function deprecated_sconify({
131131
sconifiedImageId = await sconifyImage({
132132
fromImage: dockerImageToSconify,
133133
sconifyVersion,
134-
entrypoint: appEntrypoint,
135134
binary: configTemplate.binary,
136135
});
137136
logger.info({ sconifiedImageId }, 'Sconified successfully');

api/src/sconify/sconifyBuild.service.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@ export async function sconify({
143143
sconifiedImageId = await sconifyImage({
144144
fromImage: dockerImageToSconify,
145145
sconifyVersion,
146-
entrypoint: appEntrypoint,
147146
binary: configTemplate.binary,
148147
prod: sconeProd,
149148
});

api/src/singleFunction/sconifyImage.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ const docker = new Docker();
1515
export async function sconifyImage({
1616
fromImage,
1717
sconifyVersion,
18-
entrypoint,
1918
binary,
2019
prod = false,
2120
}: {
@@ -27,10 +26,6 @@ export async function sconifyImage({
2726
* sconifier version
2827
*/
2928
sconifyVersion: string;
30-
/**
31-
* command to run the app (whitelisted)
32-
*/
33-
entrypoint: string;
3429
/**
3530
* whitelisted binary
3631
*/
@@ -41,7 +36,7 @@ export async function sconifyImage({
4136
prod?: boolean;
4237
}): Promise<string> {
4338
logger.info(
44-
{ fromImage, entrypoint },
39+
{ fromImage },
4540
`Running sconify command in ${prod ? 'prod' : 'debug'} mode...`
4641
);
4742
const sconifierImage = `${SCONIFY_IMAGE_NAME}:${sconifyVersion}`;
@@ -65,7 +60,6 @@ export async function sconifyImage({
6560
'--dlopen=1',
6661
'--no-color',
6762
'--verbose',
68-
`--command=${entrypoint}`,
6963
];
7064

7165
const baseBinds = ['/var/run/docker.sock:/var/run/docker.sock'];

0 commit comments

Comments
 (0)