fix!: drop support for deprecated APIs

BREAKING CHANGE: `POST /sconify` is dropped, websocket API request `SCONIFY_BUILD` must be used  instead; `POST /sconify/build` is dropped, websocket API request `SCONIFY_BUILD` must be used instead; websocket API request `SCONIFY` is dropped, websocket API request `SCONIFY_BUILD` must be used instead; template `Python` is dropped, template `Python3.13` must be used instead; sconeVersion `v5` or `undefined` is dropped, sconeVersion `v5.9` must be used  instead; sconeProd `false` or `undefined` is dropped, sconeProd `true` must be used instead.

Author: PierreJeanjacquot

api/README.md

@@ -10,10 +10,6 @@ The API is composed of:
     running)
   - 🟢 `GET /health`: will return a JSON object with the health status of the
     server and the version of the API.
-  - 🟠 `POST /sconify`: deprecated, use Websocket API request `SCONIFY_BUILD`
-    instead.
-  - 🟠 `POST /sconify/build`: deprecated, use Websocket API request
-    `SCONIFY_BUILD` instead.
 
 - Websocket API requests:
   - 🟢 `SCONIFY_BUILD`: will take a dockerhub image and return a
@@ -22,7 +18,6 @@ The API is composed of:
       access to the image's repo in order to push the sconified image
     - builds a sconified image out of it
     - publishes it to dockerhub with tag suffix
-  - 🟠 `SCONIFY`: deprecated, use `SCONIFY_BUILD` instead.
 
 ## Prerequisites
 
@@ -64,16 +59,16 @@ npm run start
 npm run dev:pretty
 ```
 
-## deprecations
-
-- `POST /sconify` is deprecated, websocket API request `SCONIFY_BUILD` should be
-  used instead.
-- `POST /sconify/build` is deprecated, websocket API request `SCONIFY_BUILD`
-  should be used instead.
-- websocket API request `SCONIFY` is deprecated, websocket API request
-  `SCONIFY_BUILD` should be used instead.
-- template `Python` is deprecated, template `Python3.13` should be used instead.
-- sconeVersion `v5` or `undefined` is deprecated, sconeVersion `v5.9` should be
-  used instead.
-- sconeProd `false` or `undefined` is deprecated, sconeProd `true` should be
-  used instead.
+## deprecated and dropped API
+
+- `POST /sconify` is dropped, websocket API request `SCONIFY_BUILD` must be used
+  instead.
+- `POST /sconify/build` is dropped, websocket API request `SCONIFY_BUILD` must
+  be used instead.
+- websocket API request `SCONIFY` is dropped, websocket API request
+  `SCONIFY_BUILD` must be used instead.
+- template `Python` is dropped, template `Python3.13` must be used instead.
+- sconeVersion `v5` or `undefined` is dropped, sconeVersion `v5.9` must be used
+  instead.
+- sconeProd `false` or `undefined` is dropped, sconeProd `true` must be used
+  instead.

api/src/constants/constants.ts

@@ -6,18 +6,21 @@ export const SCONIFY_IMAGE_NAME = `registry.scontain.com/scone-production/iexec-
  *
  * NB: "v5" is the legacy scone version v5.7 (name constrained by version parsing in workerpool)
  */
-export type SconeVersion = 'v5' | 'v5.9';
+export type SconeVersion = 'v5.9';
+
+export type OutdatedSconeVersion = 'v5';
 
 export const SCONIFY_IMAGE_VERSIONS: Record<SconeVersion, string> = {
-  v5: '5.7.6-v15',
   'v5.9': '5.9.1-v16',
 };
 
 // This SCONIFY_IMAGE depends on Linux alpine:3.15
 // It will be pulled if it's not yet in the local docker
 // https://hub.docker.com/layers/library/alpine/3.15/images/sha256-6a0657acfef760bd9e293361c9b558e98e7d740ed0dffca823d17098a4ffddf5?context=explore
 
-export type TemplateName = 'JavaScript' | 'Python' | 'Python3.13';
+export type TemplateName = 'JavaScript' | 'Python3.13';
+
+export type OutdatedTemplateName = 'Python';
 
 export const TEMPLATE_CONFIG: Record<
   TemplateName,
@@ -29,17 +32,10 @@ export const TEMPLATE_CONFIG: Record<
   JavaScript: {
     // node binary name does not change from one version to another
     binary: '/usr/local/bin/node',
-    // deprecated for scone 5.7 this was necessary
-    sconeCuratedImage:
-      'registry.scontain.com:5050/sconecuratedimages/node:14.4.0-alpine3.11',
   },
   'Python3.13': {
     binary: '/usr/local/bin/python3.13',
   },
-  // deprecated legacy template name Python used Python 3.8
-  Python: {
-    binary: '/usr/local/bin/python3.8',
-  },
 };
 
 /**

api/src/index.ts

@@ -1,18 +1,11 @@
 import { readFile } from 'node:fs/promises';
 import express from 'express';
 import { pino } from 'pino';
-import {
-  deprecated_sconifyHttpHandler,
-  deprecated_sconifyWsHandler,
-} from './sconify/deprecated_sconify.handler.js';
 import { loggerMiddleware } from './utils/logger.js';
 import { requestIdMiddleware } from './utils/requestId.js';
-import { errorHandlerMiddleware } from './utils/errors.js';
+import { errorHandlerMiddleware, OutdatedClientError } from './utils/errors.js';
 import { attachWebSocketServer } from './utils/websocket.js';
-import {
-  deprecated_sconifyBuildHttpHandler,
-  sconifyBuildWsHandler,
-} from './sconify/sconifyBuild.handler.js';
+import { sconifyBuildWsHandler } from './sconify/sconifyBuild.handler.js';
 
 const app = express();
 const hostname = '0.0.0.0';
@@ -31,10 +24,15 @@ app.use(express.json());
 app.use(requestIdMiddleware);
 app.use(loggerMiddleware);
 
-// deprecated endpoint, clients should use /sconify/build
-app.post('/sconify', deprecated_sconifyHttpHandler);
+app.post('/sconify', () => {
+  throw new OutdatedClientError('/sconify endpoint is no longer supported.');
+});
 
-app.post('/sconify/build', deprecated_sconifyBuildHttpHandler);
+app.post('/sconify/build', () => {
+  throw new OutdatedClientError(
+    '/sconify/build endpoint is no longer supported.'
+  );
+});
 
 // Health endpoint
 app.get('/health', (req, res) => {
@@ -58,9 +56,10 @@ const server = app.listen(port, hostname, () => {
 attachWebSocketServer({
   server,
   requestRouter: (requestTarget) => {
-    // deprecated requestTarget, clients should use SCONIFY_BUILD
     if (requestTarget === 'SCONIFY') {
-      return deprecated_sconifyWsHandler;
+      throw new OutdatedClientError(
+        'SCONIFY request target is no longer supported.'
+      );
     }
     if (requestTarget === 'SCONIFY_BUILD') {
       return sconifyBuildWsHandler;