Remove /tasks/{chainTaskId} endpoint, the adapter must only call initialize and finalize PoCo methods (#130)

Author: jbern0rd

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 
 ## [[NEXT]](https://github.com/iExecBlockchainComputing/iexec-blockchain-adapter-api/releases/tag/vNEXT) 2024
 
+### Bug Fixes
+
+- Remove `/tasks/{chainTaskId}` endpoint, the adapter must only call `initialize` and `finalize` **PoCo** methods. (#130)
+
 ## [[8.3.0]](https://github.com/iExecBlockchainComputing/iexec-blockchain-adapter-api/releases/tag/v8.3.0) 2024-01-10
 
 ### New Features

iexec-blockchain-adapter-api-library/src/main/java/com/iexec/blockchain/api/BlockchainAdapterApiClient.java

@@ -19,7 +19,6 @@
 import com.iexec.common.chain.adapter.args.TaskFinalizeArgs;
 import com.iexec.common.config.PublicChainConfig;
 import com.iexec.common.sdk.broker.BrokerOrder;
-import com.iexec.commons.poco.chain.ChainTask;
 import feign.Param;
 import feign.RequestLine;
 
@@ -41,9 +40,6 @@ public interface BlockchainAdapterApiClient {
     @RequestLine("GET /metrics")
     String getMetrics();
 
-    @RequestLine("GET /tasks/{chainTaskId}")
-    ChainTask getTask(@Param("chainTaskId") String chainTaskId);
-
     @RequestLine("POST /tasks/initialize?chainDealId={chainDealId}&taskIndex={taskIndex}")
     String requestInitializeTask(@Param("chainDealId") String chainDealId,
                                  @Param("taskIndex") int taskIndex);

src/main/java/com/iexec/blockchain/command/task/TaskController.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2021-2023 IEXEC BLOCKCHAIN TECH
+ * Copyright 2021-2024 IEXEC BLOCKCHAIN TECH
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -19,9 +19,7 @@
 import com.iexec.blockchain.api.CommandStatus;
 import com.iexec.blockchain.command.task.finalize.TaskFinalizeService;
 import com.iexec.blockchain.command.task.initialize.TaskInitializeService;
-import com.iexec.blockchain.tool.IexecHubService;
 import com.iexec.common.chain.adapter.args.TaskFinalizeArgs;
-import com.iexec.commons.poco.chain.ChainTask;
 import io.swagger.v3.oas.annotations.Operation;
 import io.swagger.v3.oas.annotations.security.SecurityRequirement;
 import org.springframework.http.ResponseEntity;
@@ -33,33 +31,14 @@
 @RequestMapping("/tasks")
 public class TaskController {
 
-    private final IexecHubService iexecHubService;
     private final TaskInitializeService taskInitializeService;
     private final TaskFinalizeService taskFinalizeService;
 
-    public TaskController(IexecHubService iexecHubService,
-                          TaskInitializeService taskInitializeService,
-                          TaskFinalizeService taskFinalizeService) {
-        this.iexecHubService = iexecHubService;
+    public TaskController(TaskInitializeService taskInitializeService, TaskFinalizeService taskFinalizeService) {
         this.taskInitializeService = taskInitializeService;
         this.taskFinalizeService = taskFinalizeService;
     }
 
-    /**
-     * Read task metadata on the blockchain.
-     *
-     * @param chainTaskId blockchain ID of the task
-     * @return task metadata
-     */
-    @Operation(security = @SecurityRequirement(name = SWAGGER_BASIC_AUTH))
-    @GetMapping("/{chainTaskId}")
-    public ResponseEntity<ChainTask> getTask(
-            @PathVariable String chainTaskId) {
-        return iexecHubService.getChainTask(chainTaskId)
-                .map(ResponseEntity::ok)
-                .orElse(ResponseEntity.notFound().build());
-    }
-
     /**
      * Start the asynchronous `initialize task` blockchain remote call.
      *