Allow null callback data when finalizing a task (#158)

Author: jbern0rd

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 
 ## [[NEXT]](https://github.com/iExecBlockchainComputing/iexec-blockchain-adapter-api/releases/tag/vNEXT) 2024
 
+### Bug Fixes
+
+- Allow null callback data when finalizing a task. (#158)
+
 ### Quality
 
 - Use poco-chain with poco v5.5.0 and voucher v1.0.0 in tests. (#152)

src/main/java/com/iexec/blockchain/command/task/finalize/TaskFinalizeService.java

@@ -35,9 +35,9 @@ public TaskFinalizeService(
     }
 
     public String start(final String chainTaskId, final String resultLink, final String callbackData) {
-        if (!isByte32(chainTaskId) || resultLink == null || callbackData == null) {
-            log.error("At least one bad args [chainTaskId:{}, resultLink:{}, callbackData:{}]",
-                    chainTaskId, resultLink, callbackData);
+        // callbackData can be null at the moment
+        if (!isByte32(chainTaskId) || resultLink == null) {
+            log.error("At least one bad args [chainTaskId:{}, resultLink:{}]", chainTaskId, resultLink);
             return "";
         }
         return startBlockchainCommand(

src/test/java/com/iexec/blockchain/command/task/finalize/TaskFinalizeServiceTests.java

@@ -67,15 +67,14 @@ void shouldFinalizeTask() {
 
     @ParameterizedTest
     @MethodSource("provideTaskFinalizeBadParameters")
-    void shouldNotFinalizeTaskWithBadParameters(final String chainTaskId, final String resultLink, final String callbackData) {
-        assertThat(taskFinalizeService.start(chainTaskId, resultLink, callbackData)).isEmpty();
+    void shouldNotFinalizeTaskWithBadParameters(final String chainTaskId, final String resultLink) {
+        assertThat(taskFinalizeService.start(chainTaskId, resultLink, EMPTY_ADDRESS)).isEmpty();
     }
 
     private static Stream<Arguments> provideTaskFinalizeBadParameters() {
         return Stream.of(
-                Arguments.of("not-a-task", RESULT_LINK, EMPTY_ADDRESS),
-                Arguments.of(CHAIN_TASK_ID, null, EMPTY_ADDRESS),
-                Arguments.of(CHAIN_TASK_ID, RESULT_LINK, null)
+                Arguments.of("not-a-task", RESULT_LINK),
+                Arguments.of(CHAIN_TASK_ID, null)
         );
     }