Merge pull request #123 from iExecBlockchainComputing/bugfix/set-one-for-gauge-version

Fix NaN value for gauge version

Author: thewhitewizard

CHANGELOG.md

@@ -9,7 +9,7 @@ All notable changes to this project will be documented in this file.
 - Send up to 2 blockchain transactions per block.
   With a big enough latency, the nonce is properly computed in web3j library against the pending block. (#111)
 - Add `BlockchainAdapterService` class to implement interactions with REST API. (#117 #118 #119)
-- Expose version through prometheus endpoint and through VersionController. (#122)
+- Expose version through prometheus endpoint and through VersionController. (#122 #123)
 
 ### Bug Fixes
 

src/main/java/com/iexec/blockchain/version/VersionController.java

@@ -32,7 +32,8 @@ public class VersionController {
     public static final String METRIC_INFO_GAUGE_DESC = "A metric to expose version and application name.";
     public static final String METRIC_INFO_LABEL_APP_NAME = "iexecAppName";
     public static final String METRIC_INFO_LABEL_APP_VERSION = "iexecAppVersion";
-
+    // Must be static final to avoid garbage collect and side effect on gauge
+    public static final int METRIC_VALUE = 1;
     private final BuildProperties buildProperties;
 
     public VersionController(BuildProperties buildProperties) {
@@ -41,7 +42,7 @@ public VersionController(BuildProperties buildProperties) {
 
     @PostConstruct
     void initializeGaugeVersion() {
-        Gauge.builder(METRIC_INFO_GAUGE_NAME, 1.0, n -> n)
+        Gauge.builder(METRIC_INFO_GAUGE_NAME, METRIC_VALUE, n -> METRIC_VALUE)
                 .description(METRIC_INFO_GAUGE_DESC)
                 .tags(METRIC_INFO_LABEL_APP_VERSION, buildProperties.getVersion(),
                         METRIC_INFO_LABEL_APP_NAME, buildProperties.getName())

src/test/java/com/iexec/blockchain/version/VersionControllerTests.java

@@ -75,5 +75,6 @@ void shouldReturnInfoGauge() {
                         id -> id.getTag(VersionController.METRIC_INFO_LABEL_APP_VERSION)
                 )
                 .containsExactly(buildProperties.getName(), buildProperties.getVersion());
+        assertThat(info.value()).isEqualTo(VersionController.METRIC_VALUE);
     }
 }