Skip to content

Commit 697955c

Browse files
committed
feat: deprecate classes based on deprecated EIP-712 implementation
1 parent ed89528 commit 697955c

File tree

6 files changed

+23
-4
lines changed

6 files changed

+23
-4
lines changed

src/main/java/com/iexec/commons/poco/eip712/EIP712.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@
2424
import java.util.List;
2525
import java.util.Map;
2626

27+
/**
28+
* @deprecated only used in {@link EIP712Entity}
29+
*/
30+
@Deprecated(forRemoval = true)
2731
@JsonIgnoreProperties(ignoreUnknown = true)
2832
public interface EIP712<M> {
2933

src/main/java/com/iexec/commons/poco/eip712/entity/EIP712AppOrder.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@
2626
import java.util.Arrays;
2727
import java.util.List;
2828

29+
/**
30+
* @deprecated replaced with {@link AppOrder#computeHash(EIP712Domain)} )
31+
*/
32+
@Deprecated(forRemoval = true)
2933
@Getter
3034
@NoArgsConstructor
3135
public class EIP712AppOrder extends EIP712Entity<AppOrder> {

src/main/java/com/iexec/commons/poco/eip712/entity/EIP712Challenge.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,16 @@
1919
import com.iexec.commons.poco.eip712.EIP712Domain;
2020
import com.iexec.commons.poco.eip712.EIP712Entity;
2121
import com.iexec.commons.poco.eip712.TypeParam;
22+
import com.iexec.commons.poco.order.AppOrder;
2223
import lombok.NoArgsConstructor;
2324

2425
import java.util.Collections;
2526
import java.util.List;
2627

2728
/**
28-
* EIP-712 compliant challenge based on {@link Challenge} type and {@link EIP712Domain}.
29-
* <p>
30-
* In the current implementation, {@link EIP712Domain} fields are {@code name}, {@code version} and {@code chainID}.
31-
* There is no {@code verifyingContract}.
29+
* @deprecated replaced with {@link Challenge#computeHash(EIP712Domain)} )
3230
*/
31+
@Deprecated(forRemoval = true)
3332
@NoArgsConstructor
3433
public class EIP712Challenge extends EIP712Entity<Challenge> {
3534

src/main/java/com/iexec/commons/poco/eip712/entity/EIP712DatasetOrder.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@
2626
import java.util.Arrays;
2727
import java.util.List;
2828

29+
/**
30+
* @deprecated replaced with {@link DatasetOrder#computeHash(EIP712Domain)} )
31+
*/
32+
@Deprecated(forRemoval = true)
2933
@Getter
3034
@NoArgsConstructor
3135
public class EIP712DatasetOrder extends EIP712Entity<DatasetOrder> {

src/main/java/com/iexec/commons/poco/eip712/entity/EIP712RequestOrder.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@
2626
import java.util.Arrays;
2727
import java.util.List;
2828

29+
/**
30+
* @deprecated replaced with {@link RequestOrder#computeHash(EIP712Domain)} )
31+
*/
32+
@Deprecated(forRemoval = true)
2933
@Getter
3034
@NoArgsConstructor
3135
public class EIP712RequestOrder extends EIP712Entity<RequestOrder> {

src/main/java/com/iexec/commons/poco/eip712/entity/EIP712WorkerpoolOrder.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@
2626
import java.util.Arrays;
2727
import java.util.List;
2828

29+
/**
30+
* @deprecated replaced with {@link WorkerpoolOrder#computeHash(EIP712Domain)} )
31+
*/
32+
@Deprecated(forRemoval = true)
2933
@Getter
3034
@NoArgsConstructor
3135
public class EIP712WorkerpoolOrder extends EIP712Entity<WorkerpoolOrder> {

0 commit comments

Comments
 (0)