Skip to content

Commit 45a6899

Browse files
committed
Localize executor into init method instead of class member + shutdown
1 parent 2d4d84e commit 45a6899

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/main/java/com/iexec/core/task/update/TaskUpdateManager.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ class TaskUpdateManager {
6666
private final SmsService smsService;
6767

6868
private final LinkedHashMap<TaskStatus, AtomicLong> currentTaskStatusesCount;
69-
private final ExecutorService taskStatusesCountExecutor;
7069

7170
public TaskUpdateManager(TaskService taskService,
7271
IexecHubService iexecHubService,
@@ -97,16 +96,17 @@ public TaskUpdateManager(TaskService taskService,
9796
"status", status.name()
9897
).register(Metrics.globalRegistry);
9998
}
100-
101-
this.taskStatusesCountExecutor = Executors.newSingleThreadExecutor();
10299
}
103100

104101
@PostConstruct
105102
Future<Void> init() {
106-
return taskStatusesCountExecutor.submit(
103+
final ExecutorService taskStatusesCountExecutor = Executors.newSingleThreadExecutor();
104+
final Future<Void> future = taskStatusesCountExecutor.submit(
107105
this::initializeCurrentTaskStatusesCount,
108106
null // Trick to get a `Future<Void>` instead of a `Future<?>`
109107
);
108+
taskStatusesCountExecutor.shutdown();
109+
return future;
110110
}
111111

112112
/**

0 commit comments

Comments
 (0)