More unit tests

Author: Jérémy James Toussaint

src/main/java/com/iexec/core/workflow/ReplicateWorkflow.java

@@ -32,7 +32,7 @@
 public class ReplicateWorkflow extends Workflow<ReplicateStatus> {
 
     private static ReplicateWorkflow instance;
-    private Map<ReplicateStatus, TaskNotificationType> actionMap = new LinkedHashMap<>();
+    private final Map<ReplicateStatus, TaskNotificationType> actionMap = new LinkedHashMap<>();
 
     private ReplicateWorkflow() {
         super();
@@ -181,6 +181,9 @@ public TaskNotificationType getNextAction(ReplicateStatus whenStatus, ReplicateS
     }
 
     TaskNotificationType getNextActionWhenStatusAndCause(ReplicateStatus whenStatus, ReplicateStatusCause whenCause) {
+        if (whenStatus == null){
+            return null;
+        }
         if (whenCause == null){
             return null;
         }

src/test/java/com/iexec/core/workflow/ReplicateWorkflowTests.java

@@ -34,6 +34,37 @@ public void setup() {
         replicateWorkflow = ReplicateWorkflow.getInstance();
     }
 
+    @Test
+    public void shouldNotGetNextActionWhenStatusSinceStatusIsNull(){
+        assertThat(replicateWorkflow
+                .getNextActionWhenStatus(null)).isNull();
+    }
+
+    @Test
+    public void shouldNotGetNextActionWhenStatusSinceStatusIsUnknown(){
+        assertThat(replicateWorkflow
+                .getNextActionWhenStatus(ReplicateStatus.ABORTED)) //unknown
+                .isNull();
+    }
+
+    @Test
+    public void shouldNotGetNextActionWhenStatusAndCauseSinceCauseIsNull(){
+        assertThat(replicateWorkflow
+                .getNextActionWhenStatusAndCause(null,
+                        ReplicateStatusCause.INPUT_FILES_DOWNLOAD_FAILED)) //any
+                .isNull();
+    }
+
+    @Test
+    public void shouldNotGetNextActionWhenStatusAndCauseSinceStatusIsUnknown(){
+        assertThat(replicateWorkflow
+                .getNextActionWhenStatusAndCause(ReplicateStatus.ABORTED, //unknown
+                        ReplicateStatusCause.ABORTED_BY_WORKER)) //any
+                .isNull();
+    }
+
+    // app
+
     @Test
     public void shouldGetNextActionOnAppDownloadFailed(){
         assertThat(replicateWorkflow
@@ -58,6 +89,8 @@ public void shouldGetNextActionOnAppDownloadFailedWithAppImageDownloadFailed(){
                 .isEqualTo(TaskNotificationType.PLEASE_CONTRIBUTE);
     }
 
+    // data
+
     @Test
     public void shouldGetNextActionOnDataDownloadFailed(){
         assertThat(replicateWorkflow