Merge pull request #446 from iExecBlockchainComputing/fix/updateReplicateStatus-recover

mcornaton · web-flow · commit 9a11db7c6f0d · 2021-10-19T11:46:37.000+02:00
Fix @recover return value on `ReplicatesService::updateReplicateStatus`
diff --git a/src/main/java/com/iexec/core/replicate/ReplicatesService.java b/src/main/java/com/iexec/core/replicate/ReplicatesService.java
@@ -352,11 +352,12 @@ public Optional<TaskNotificationType> updateReplicateStatus(String chainTaskId,
     }
 
     @Recover
-    public void updateReplicateStatus(OptimisticLockingFailureException exception,
+    public Optional<TaskNotificationType> updateReplicateStatus(OptimisticLockingFailureException exception,
                                       String chainTaskId,
                                       String walletAddress,
                                       ReplicateStatusUpdate statusUpdate) {
         logUpdateReplicateStatusRecover(exception);
+        return Optional.empty();
     }
 
     private void logUpdateReplicateStatusRecover(OptimisticLockingFailureException exception) {

Original file line number	Diff line number	Diff line change
`@@ -352,11 +352,12 @@ public Optional<TaskNotificationType> updateReplicateStatus(String chainTaskId,`
`352`	`352`	`}`
`353`	`353`
`354`	`354`	`@Recover`
`355`		`- public void updateReplicateStatus(OptimisticLockingFailureException exception,`
	`355`	`+ public Optional<TaskNotificationType> updateReplicateStatus(OptimisticLockingFailureException exception,`
`356`	`356`	`String chainTaskId,`
`357`	`357`	`String walletAddress,`
`358`	`358`	`ReplicateStatusUpdate statusUpdate) {`
`359`	`359`	`logUpdateReplicateStatusRecover(exception);`
	`360`	`+ return Optional.empty();`
`360`	`361`	`}`
`361`	`362`
`362`	`363`	`private void logUpdateReplicateStatusRecover(OptimisticLockingFailureException exception) {`