Immutable ResultRepositoryConfiguration and WorkerConfiguration classe (#650)

* Immutable `ResultRepositoryConfiguration` and `WorkerConfiguration` classes

* Replace `@Data` with `@Value` annotation

Author: jbern0rd

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 All notable changes to this project will be documented in this file.
 
-## [[NEXT]](https://github.com/iExecBlockchainComputing/iexec-core/releases/tag/vNEXT) 2023
+## [[NEXT]](https://github.com/iExecBlockchainComputing/iexec-core/releases/tag/vNEXT) 2024
 
 ### New Features
 
@@ -21,6 +21,7 @@ All notable changes to this project will be documented in this file.
 - Replace single thread executor with synchronized keyword. (#633)
 - Move contribution status checks from `iexec-commons-poco`. (#636)
 - Use `BlockchainAdapterService` from `iexec-blockchain-adapter-api-library`. (#641)
+- `ResultRepositoryConfiguration` and `WorkerConfiguration` classes are now immutable with `@Value` lombok annotation. (#650)
 
 ### Bug Fixes
 

src/main/java/com/iexec/core/configuration/ResultRepositoryConfiguration.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2020 IEXEC BLOCKCHAIN TECH
+ * Copyright 2020-2024 IEXEC BLOCKCHAIN TECH
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -19,27 +19,18 @@
 import com.iexec.resultproxy.api.ResultProxyClient;
 import com.iexec.resultproxy.api.ResultProxyClientBuilder;
 import feign.Logger;
-import lombok.AllArgsConstructor;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import org.springframework.beans.factory.annotation.Value;
+import lombok.Value;
+import org.springframework.boot.context.properties.ConfigurationProperties;
+import org.springframework.boot.context.properties.ConstructorBinding;
 import org.springframework.context.annotation.Bean;
-import org.springframework.stereotype.Component;
 
-@Component
-@Getter
-@AllArgsConstructor
-@NoArgsConstructor
+@Value
+@ConstructorBinding
+@ConfigurationProperties(prefix = "result-repository")
 public class ResultRepositoryConfiguration {
-
-    @Value("${resultRepository.protocol}")
-    private String protocol;
-
-    @Value("${resultRepository.host}")
-    private String host;
-
-    @Value("${resultRepository.port}")
-    private String port;
+    String protocol;
+    String host;
+    String port;
 
     public String getResultRepositoryURL() {
         return protocol + "://" + host + ":" + port;

src/main/java/com/iexec/core/configuration/WorkerConfiguration.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2020 IEXEC BLOCKCHAIN TECH
+ * Copyright 2020-2024 IEXEC BLOCKCHAIN TECH
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,36 +16,17 @@
 
 package com.iexec.core.configuration;
 
-import lombok.*;
-import org.springframework.beans.factory.annotation.Value;
-import org.springframework.stereotype.Component;
+import lombok.Value;
+import org.springframework.boot.context.properties.ConfigurationProperties;
+import org.springframework.boot.context.properties.ConstructorBinding;
 
-import java.util.Arrays;
 import java.util.List;
 
-@Setter
-@Component
+@Value
+@ConstructorBinding
+@ConfigurationProperties(prefix = "workers")
 public class WorkerConfiguration {
-
-    @Value("${workers.askForReplicatePeriod}")
-    private long askForReplicatePeriod;
-
-    @Value("${workers.requiredWorkerVersion}")
-    private String requiredWorkerVersion;
-
-    @Value("${workers.whitelist}")
-    private String[] whitelist;
-
-    // getters are overridden since the whitelist should return a list, not an array
-    public long getAskForReplicatePeriod() {
-        return askForReplicatePeriod;
-    }
-
-    public String getRequiredWorkerVersion() {
-        return requiredWorkerVersion;
-    }
-
-    public List<String> getWhitelist() {
-        return Arrays.asList(whitelist);
-    }
+    long askForReplicatePeriod;
+    String requiredWorkerVersion;
+    List<String> whitelist;
 }