chore(api): fix eslint errors

Author: PierreJeanjacquot

api/eslint.config.js

@@ -24,6 +24,12 @@ export default [
       'new-cap': 'off',
       'no-console': 'error',
       'no-underscore-dangle': 'off',
+      'no-unused-vars': [
+        'error',
+        {
+          ignoreRestSiblings: true,
+        },
+      ],
       'no-template-curly-in-string': 'off',
       'max-classes-per-file': 'off',
       'max-len': 'off',

api/generateEsModulesFromJson.cjs

@@ -63,8 +63,7 @@ const sources = [
 ];
 
 const createEsModule = (jsonObj) => {
-  let module =
-    '// this file is auto generated do not edit it\n/* eslint-disable */\n';
+  let module = '// this file is auto generated do not edit it\n\n';
   Object.entries(jsonObj).forEach(([key, value]) => {
     module += `export const ${key} = ${JSON.stringify(value)};\n`;
   });

api/src/config.js

@@ -1,11 +1,11 @@
-import iexecTokenDesc from './generated/@iexec/poco/IexecInterfaceToken.js';
-import iexecNativeDesc from './generated/@iexec/poco/IexecInterfaceNative.js';
-import appRegistryDesc from './generated/@iexec/poco/AppRegistry.js';
-import workerpoolRegistryDesc from './generated/@iexec/poco/WorkerpoolRegistry.js';
-import datasetRegistryDesc from './generated/@iexec/poco/DatasetRegistry.js';
-import appDesc from './generated/@iexec/poco/App.js';
-import workerpoolDesc from './generated/@iexec/poco/Workerpool.js';
-import datasetDesc from './generated/@iexec/poco/Dataset.js';
+import { abi as iexecTokenAbi } from './generated/@iexec/poco/IexecInterfaceToken.js';
+import { abi as iexecNativeAbi } from './generated/@iexec/poco/IexecInterfaceNative.js';
+import { abi as appRegistryAbi } from './generated/@iexec/poco/AppRegistry.js';
+import { abi as workerpoolRegistryAbi } from './generated/@iexec/poco/WorkerpoolRegistry.js';
+import { abi as datasetRegistryAbi } from './generated/@iexec/poco/DatasetRegistry.js';
+import { abi as appAbi } from './generated/@iexec/poco/App.js';
+import { abi as workerpoolAbi } from './generated/@iexec/poco/Workerpool.js';
+import { abi as datasetAbi } from './generated/@iexec/poco/Dataset.js';
 
 import { logger } from './utils/logger.js';
 
@@ -27,21 +27,21 @@ const {
 const chainsNames = CHAINS.split(',').map((e) => e.toUpperCase());
 
 const abis = {
-  app: appDesc.abi,
-  dataset: datasetDesc.abi,
-  workerpool: workerpoolDesc.abi,
-  appregistry: appRegistryDesc.abi,
-  datasetregistry: datasetRegistryDesc.abi,
-  workerpoolregistry: workerpoolRegistryDesc.abi,
+  app: appAbi,
+  dataset: datasetAbi,
+  workerpool: workerpoolAbi,
+  appregistry: appRegistryAbi,
+  datasetregistry: datasetRegistryAbi,
+  workerpoolregistry: workerpoolRegistryAbi,
 };
 
 const tokenAbis = {
-  hub: iexecTokenDesc.abi,
+  hub: iexecTokenAbi,
   ...abis,
 };
 
 const nativeAbis = {
-  hub: iexecNativeDesc.abi,
+  hub: iexecNativeAbi,
   ...abis,
 };
 

api/src/controllers/ratelimit.js

@@ -30,8 +30,8 @@ const getRatelimitMiddleware = ({ maxRequest, period }) => {
       )
         return true;
       // allow localhost
-      if (ctx.ip === '::ffff:127.0.0.1') return true;
-      return false;
+      // eslint-disable-next-line sonarjs/no-hardcoded-ip
+      return ctx.ip === '::ffff:127.0.0.1';
     },
   });
 };

api/src/models/common.js

@@ -6,7 +6,7 @@ const addressValidator = {
     try {
       getAddress(address);
       return true;
-    } catch (e) {
+    } catch {
       return false;
     }
   },
@@ -20,7 +20,7 @@ const bytes32validator = {
 
 const timestampValidator = {
   validator: (str) =>
-    /^[0-9]{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])T(2[0-3]|[01][0-9]):[0-5][0-9]:[0-5][0-9].[0-9][0-9][0-9]Z$/.test(
+    /^\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2]\d|3[0-1])T(2[0-3]|[01]\d):[0-5]\d:[0-5]\d.\d\d\dZ$/.test(
       str,
     ),
   message: '{PATH} is not a valid timestamp',

api/src/utils/error.js

@@ -1,3 +1,4 @@
+/* eslint-disable sonarjs/no-identical-functions */
 import { ValidationError } from 'yup';
 import { logError } from './logger.js';
 

api/src/utils/validator.js

@@ -24,14 +24,14 @@ const positiveStrictIntSchema = () =>
 
 const timestampSchema = () =>
   string().match(
-    /^[0-9]{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])T(2[0-3]|[01][0-9]):[0-5][0-9]:[0-5][0-9].[0-9][0-9][0-9]Z$/,
+    /^\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2]\d|3[0-1])T(2[0-3]|[01]\d):[0-5]\d:[0-5]\d.\d\d\dZ$/,
     '${path} must be a timestamp (2019-09-11T10:03:38.068Z is a valid timestamp)',
   );
 
 const transformAddress = (value) => {
   try {
     return getAddress(value.toLowerCase());
-  } catch (e) {
+  } catch {
     return value;
   }
 };
@@ -40,7 +40,7 @@ const isAddress = (value) => {
   try {
     getAddress(value);
     return true;
-  } catch (e) {
+  } catch {
     return false;
   }
 };