fix: prevent prepareDatasetBulk when bulk is not implemented

Author: PierreJeanjacquot

src/common/execution/order-helper.js

@@ -13,7 +13,12 @@ import {
   STORAGE_PROVIDERS,
   TEE_FRAMEWORKS,
 } from '../utils/constant.js';
-import { THEGRAPH_IPFS_NODE, THEGRAPH_IPFS_GATEWAY } from '../utils/config.js';
+import {
+  THEGRAPH_IPFS_NODE,
+  THEGRAPH_IPFS_GATEWAY,
+  checkImplementedOnChain,
+  CHAIN_SPECIFIC_FEATURES,
+} from '../utils/config.js';
 import {
   getStorageTokenKeyName,
   reservedSecretKeyName,
@@ -234,10 +239,16 @@ const ipfsUpload = async ({
 export const prepareDatasetBulk = async ({
   ipfsNode = throwIfMissing(),
   ipfsGateway = throwIfMissing(),
-  datasetorders,
+  contracts = throwIfMissing(),
+  datasetorders = throwIfMissing(),
   maxDatasetPerTask = MAX_DATASET_PER_TASK,
   thegraphUpload = false,
 }) => {
+  checkImplementedOnChain(
+    contracts.chainId,
+    CHAIN_SPECIFIC_FEATURES.BULK_PROCESSING,
+  );
+
   const vmMaxDatasetPerTask = await positiveStrictIntSchema()
     .max(MAX_DATASET_PER_TASK)
     .label('maxDatasetPerTask')

src/common/utils/config.js

@@ -8,6 +8,7 @@ export const CHAIN_SPECIFIC_FEATURES = {
   VOUCHER: 'iExec Voucher',
   COMPASS: 'iExec Compass',
   XRLC_BRIDGE: 'iExec xRLC Bridge',
+  BULK_PROCESSING: 'Bulk processing',
 };
 
 const networkConfigs = [
@@ -37,7 +38,10 @@ const networkConfigs = [
     },
     shouldRegisterNetwork: true,
     isExperimental: false,
-    notImplemented: [CHAIN_SPECIFIC_FEATURES.COMPASS],
+    notImplemented: [
+      CHAIN_SPECIFIC_FEATURES.COMPASS,
+      CHAIN_SPECIFIC_FEATURES.BULK_PROCESSING,
+    ],
   },
   {
     id: 1,
@@ -64,6 +68,7 @@ const networkConfigs = [
     notImplemented: [
       CHAIN_SPECIFIC_FEATURES.COMPASS,
       CHAIN_SPECIFIC_FEATURES.VOUCHER,
+      CHAIN_SPECIFIC_FEATURES.BULK_PROCESSING,
     ],
   },
   {
@@ -123,6 +128,7 @@ const networkConfigs = [
       CHAIN_SPECIFIC_FEATURES.WORKERPOOL_API_URL_REGISTRATION,
       CHAIN_SPECIFIC_FEATURES.VOUCHER,
       CHAIN_SPECIFIC_FEATURES.XRLC_BRIDGE,
+      CHAIN_SPECIFIC_FEATURES.BULK_PROCESSING,
     ],
   },
 ];

src/lib/IExecOrderModule.js

@@ -400,6 +400,7 @@ export default class IExecOrderModule extends IExecModule {
       return prepareDatasetBulk({
         ipfsNode: await this.config.resolveIpfsNodeURL(),
         ipfsGateway: await this.config.resolveIpfsGatewayURL(),
+        contracts: await this.config.resolveContractsClient(),
         datasetorders,
         maxDatasetPerTask,
         thegraphUpload:

test/lib/e2e/IExecOrderModule.test.js

@@ -40,11 +40,13 @@ const signRegex = /^(0x)([0-9a-f]{2}){65}$/;
 
 describe('order', () => {
   describe('prepareDatasetBulk()', () => {
-    const { iexec: iexecRequester } = getTestConfig(iexecTestChain)();
+    const testChain = TEST_CHAINS['custom-token-chain']; // no bulk processing on bellecour;
+    const { iexec: iexecRequester } = getTestConfig(testChain)();
     let datasetorders = [];
 
     beforeAll(async () => {
       const requesterAddress = await iexecRequester.wallet.getAddress();
+      await setBalance(testChain)(requesterAddress, ONE_ETH);
       const { address: appAddress } = await deployRandomApp(iexecRequester);
       datasetorders = await Promise.all(
         Array(10)

test/lib/unit/config.test.js

@@ -166,4 +166,25 @@ describe('checkImplementedOnChain', () => {
       );
     });
   });
+  describe(`feature ${CHAIN_SPECIFIC_FEATURES.BULK_PROCESSING}`, () => {
+    const feature = CHAIN_SPECIFIC_FEATURES.BULK_PROCESSING;
+    test('is not implemented on bellecour', () => {
+      expect(() => checkImplementedOnChain(134, feature)).toThrow(
+        `${feature} is not available on network bellecour`,
+      );
+    });
+    test('is not implemented on mainnet', () => {
+      expect(() => checkImplementedOnChain(1, feature)).toThrow(
+        `${feature} is not available on network mainnet`,
+      );
+    });
+    test('is not implemented on arbitrum-mainnet', () => {
+      expect(() => checkImplementedOnChain(42161, feature)).toThrow(
+        `${feature} is not available on network arbitrum-mainnet`,
+      );
+    });
+    test('is implemented on arbitrum-sepolia-testnet', () => {
+      expect(() => checkImplementedOnChain(421614, feature)).not.toThrow();
+    });
+  });
 });

test/test-utils.js

@@ -65,6 +65,8 @@ export const TEST_CHAINS = {
     hubAddress: '0xC129e7917b7c7DeDfAa5Fff1FB18d5D7050fE8ca',
     ensRegistryAddress: '0xaf87b82B01E484f8859c980dE69eC8d09D30F22a',
     ensPublicResolverAddress: '0x464E9FC01C2970173B183D24B43A0FA07e6A072E',
+    ipfsNodeURL: 'http://localhost:5001',
+    ipfsGatewayURL: 'http://localhost:8080',
     pocoAdminWallet: new Wallet(
       '0x564a9db84969c8159f7aa3d5393c5ecd014fce6a375842a45b12af6677b12407',
     ),