diff --git a/.github/workflows/docker-staging.yml b/.github/workflows/docker-staging.yml index e27a5ad9..de591109 100644 --- a/.github/workflows/docker-staging.yml +++ b/.github/workflows/docker-staging.yml @@ -12,8 +12,7 @@ jobs: uses: ./.github/workflows/reusable-docker.yml needs: compute-staging-version with: - dry-run: true # TODO set to false tag: ${{ needs.compute-staging-version.outputs.version }} secrets: - docker-username: ${{ secrets.DOCKERHUB_USERNAME }} # TODO ensure secret is set - docker-password: ${{ secrets.DOCKERHUB_TOKEN }} # TODO ensure secret is set + docker-username: ${{ secrets.DOCKERHUB_USERNAME }} + docker-password: ${{ secrets.DOCKERHUB_TOKEN }} diff --git a/.github/workflows/npm-staging.yml b/.github/workflows/npm-staging.yml index c4f5bedc..09c6c59b 100644 --- a/.github/workflows/npm-staging.yml +++ b/.github/workflows/npm-staging.yml @@ -12,7 +12,6 @@ jobs: uses: ./.github/workflows/reusable-npm.yml needs: compute-staging-version with: - dry-run: true # TODO set to false version: ${{ needs.compute-staging-version.outputs.version }} tag: ${{ needs.compute-staging-version.outputs.dist-tag }} secrets: diff --git a/.github/workflows/reusable-docker.yml b/.github/workflows/reusable-docker.yml index df1e9147..889da1ae 100644 --- a/.github/workflows/reusable-docker.yml +++ b/.github/workflows/reusable-docker.yml @@ -22,7 +22,7 @@ on: jobs: docker-publish: - uses: iExecBlockchainComputing/github-actions-workflows/.github/workflows/docker-build.yml@docker-build-v2.3.0 + uses: iExecBlockchainComputing/github-actions-workflows/.github/workflows/docker-build.yml@docker-build-v2.3.1 with: image-name: 'iexechub/iexec-sdk' registry: 'docker.io'