Use @Getter lombok annotation in PublicConfigurationService (#573)

Author: jbern0rd

CHANGELOG.md

@@ -14,6 +14,7 @@ All notable changes to this project will be documented in this file.
 
 - Expose `workerWalletAddress` to avoid importing `CredentialsService` when not required. (#558)
 - Use `docker-java` from `iexec-commons-containers`. (#572)
+- Use `@Getter` lombok annotation in `PublicConfigurationService`. (#573)
 
 ### Dependency Upgrades
 

src/main/java/com/iexec/worker/config/PublicConfigurationService.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2020 IEXEC BLOCKCHAIN TECH
+ * Copyright 2020-2024 IEXEC BLOCKCHAIN TECH
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,9 +23,11 @@
 import com.iexec.resultproxy.api.ResultProxyClientBuilder;
 import com.iexec.worker.feign.CustomCoreFeignClient;
 import feign.Logger;
+import lombok.Getter;
 import org.springframework.context.annotation.Bean;
 import org.springframework.stereotype.Service;
 
+@Getter
 @Service
 public class PublicConfigurationService {
 
@@ -35,41 +37,25 @@ public PublicConfigurationService(CustomCoreFeignClient customCoreFeignClient) {
         this.publicConfiguration = customCoreFeignClient.getPublicConfiguration();
     }
 
-    public PublicConfiguration getPublicConfiguration() {
-        return publicConfiguration;
-    }
-
-    public String getBlockchainAdapterUrl() {
-        return publicConfiguration.getBlockchainAdapterUrl();
-    }
-
-    public String getWorkerPoolAddress() {
-        return publicConfiguration.getWorkerPoolAddress();
-    }
-
     public String getSchedulerPublicAddress() {
         return publicConfiguration.getSchedulerPublicAddress();
     }
 
-    public long getAskForReplicatePeriod() {
-        return publicConfiguration.getAskForReplicatePeriod();
-    }
-
-    public String getResultRepositoryURL() {
-        return publicConfiguration.getResultRepositoryURL();
-    }
-
     public String getRequiredWorkerVersion() {
         return publicConfiguration.getRequiredWorkerVersion();
     }
 
     @Bean
     public BlockchainAdapterApiClient blockchainAdapterApiClient() {
-        return BlockchainAdapterApiClientBuilder.getInstance(Logger.Level.NONE, getBlockchainAdapterUrl());
+        return BlockchainAdapterApiClientBuilder.getInstance(
+                Logger.Level.NONE,
+                publicConfiguration.getBlockchainAdapterUrl());
     }
 
     @Bean
     public ResultProxyClient resultProxyClient() {
-        return ResultProxyClientBuilder.getInstance(Logger.Level.NONE, getResultRepositoryURL());
+        return ResultProxyClientBuilder.getInstance(
+                Logger.Level.NONE,
+                publicConfiguration.getResultRepositoryURL());
     }
 }

src/main/java/com/iexec/worker/replicate/ReplicateDemandService.java

@@ -68,7 +68,7 @@ public ReplicateDemandService(IexecHubService iexecHubService,
      * than one replicate at the same time. The executor's queue is of size 1 to
      * avoid memory leak if the thread halts for any reason.
      */
-    @Scheduled(fixedDelayString = "#{publicConfigurationService.askForReplicatePeriod}")
+    @Scheduled(fixedDelayString = "#{publicConfigurationService.publicConfiguration.askForReplicatePeriod}")
     void triggerAskForReplicate() {
         log.debug("Triggering ask for replicate action");
         AsyncUtils.runAsyncTask("ask-for-replicate", this::askForReplicate, executor);