Harmonize YML internal variables to proper case (#638)

Author: Natchica

CHANGELOG.md

@@ -14,6 +14,7 @@ All notable changes to this project will be documented in this file.
 - Refactor `RestTemplateConfig` to use `HttpClient 5` and improve proxy handling. (#626)
 - Replace deprecated `connect` with `connectAsync` in `StompClientService`. (#627)
 - Remove redundant blockchain calls to diminish pressure on Ethereum JSON-RPC API. (#632)
+- Harmonize YML internal variables to proper case. (#638)
 
 ### Breaking API changes
 

src/main/java/com/iexec/worker/config/SchedulerConfiguration.java

@@ -38,7 +38,7 @@ public class SchedulerConfiguration {
     public SchedulerConfiguration(@Value("${core.protocol}") String protocol,
                                   @Value("${core.host}") String host,
                                   @Value("${core.port}") String port,
-                                  @Value("${core.poolAddress}") String poolAddress) {
+                                  @Value("${core.pool-address}") String poolAddress) {
         this.protocol = protocol;
         this.host = host;
         this.port = port;

src/main/resources/application.yml

@@ -5,7 +5,7 @@ core:
   protocol: ${IEXEC_CORE_PROTOCOL:http}
   host: ${IEXEC_CORE_HOST:localhost}
   port: ${IEXEC_CORE_PORT:13000}
-  poolAddress: ${POOL_ADDRESS:0x0}
+  pool-address: ${POOL_ADDRESS:0x0}
 
 worker:
   name: ${IEXEC_WORKER_NAME:worker}

src/test/java/com/iexec/worker/config/SchedulerConfigurationTests.java

@@ -32,7 +32,7 @@ class SchedulerConfigurationTests {
 
     @Test
     void shouldCreateBeanInstance() {
-        runner.withPropertyValues("core.protocol=http", "core.host=localhost", "core.port=13000", "core.poolAddress=0x365E7BABAa85eC61Dffe5b520763062e6C29dA27")
+        runner.withPropertyValues("core.protocol=http", "core.host=localhost", "core.port=13000", "core.pool-address=0x365E7BABAa85eC61Dffe5b520763062e6C29dA27")
                 .withConfiguration(UserConfigurations.of(SchedulerConfiguration.class))
                 .run(context -> {
                     assertThat(context).hasSingleBean(SchedulerClient.class);
@@ -45,7 +45,7 @@ void shouldCreateBeanInstance() {
     @ParameterizedTest
     @ValueSource(strings = {"", "0x0"})
     void shouldFailedAndRaisedExceptionWhenPoolAddressIsInvalid(String poolAddress) {
-        runner.withPropertyValues("core.protocol=http", "core.host=localhost", "core.port=13000", "core.poolAddress=" + poolAddress)
+        runner.withPropertyValues("core.protocol=http", "core.host=localhost", "core.port=13000", "core.pool-address=" + poolAddress)
                 .withConfiguration(UserConfigurations.of(SchedulerConfiguration.class))
                 .run(context -> {
                     assertThatThrownBy(() -> context.getBean(SchedulerConfiguration.class))