Replace SignatureUtils#hashAndSign deprecated calls in LoginServiceTests (#618)

Author: jbern0rd

CHANGELOG.md

@@ -18,6 +18,7 @@ All notable changes to this project will be documented in this file.
 - Reorder `static` and `final` keywords. (#614)
 - Improve code maintainability in test classes. (#615)
 - Resolve deprecations caused by `TaskDescription` in `AppComputeService`, `TaskManagerService`, and `ResultService`. (#616)
+- Replace `SignatureUtils#hashAndSign` deprecated calls in `LoginServiceTests`. (#618)
 
 ### Dependency Upgrades
 

src/test/java/com/iexec/worker/feign/LoginServiceTests.java

@@ -72,7 +72,7 @@ private Credentials generateCredentials() {
 
     @Test
     void shouldNotLoginOnBadChallengeStatusCode() {
-        Credentials credentials = generateCredentials();
+        final Credentials credentials = generateCredentials();
         when(coreClient.getChallenge(credentials.getAddress())).thenThrow(FeignException.class);
         assertAll(
                 () -> assertEquals("", loginService.login()),
@@ -83,8 +83,8 @@ void shouldNotLoginOnBadChallengeStatusCode() {
     @ParameterizedTest
     @NullSource
     @ValueSource(strings = "")
-    void shouldNotLoginOnEmptyChallenge(String challenge) {
-        Credentials credentials = generateCredentials();
+    void shouldNotLoginOnEmptyChallenge(final String challenge) {
+        final Credentials credentials = generateCredentials();
         when(coreClient.getChallenge(credentials.getAddress())).thenReturn(challenge);
         assertAll(
                 () -> assertEquals("", loginService.login()),
@@ -94,9 +94,9 @@ void shouldNotLoginOnEmptyChallenge(String challenge) {
 
     @Test
     void shouldNotLoginOnBadLoginStatusCode() {
-        Credentials credentials = generateCredentials();
+        final Credentials credentials = generateCredentials();
         when(coreClient.getChallenge(credentials.getAddress())).thenReturn("challenge");
-        Signature signature = SignatureUtils.hashAndSign("challenge", credentials.getAddress(), credentials.getEcKeyPair());
+        final Signature signature = SignatureUtils.hashAndSign("challenge", credentials.getEcKeyPair());
         when(coreClient.login(credentials.getAddress(), signature)).thenThrow(FeignException.class);
         assertAll(
                 () -> assertEquals("", loginService.login()),
@@ -108,10 +108,10 @@ void shouldNotLoginOnBadLoginStatusCode() {
     @NullSource
     @ValueSource(strings = "")
     @ParameterizedTest
-    void shouldNotLoginOnEmptyToken(String token) {
-        Credentials credentials = generateCredentials();
+    void shouldNotLoginOnEmptyToken(final String token) {
+        final Credentials credentials = generateCredentials();
         when(coreClient.getChallenge(credentials.getAddress())).thenReturn("challenge");
-        Signature signature = SignatureUtils.hashAndSign("challenge", credentials.getAddress(), credentials.getEcKeyPair());
+        final Signature signature = SignatureUtils.hashAndSign("challenge", credentials.getEcKeyPair());
         when(coreClient.login(credentials.getAddress(), signature)).thenReturn(token);
         assertAll(
                 () -> assertEquals("", loginService.login()),
@@ -122,9 +122,9 @@ void shouldNotLoginOnEmptyToken(String token) {
 
     @Test
     void shouldLogin() {
-        Credentials credentials = generateCredentials();
+        final Credentials credentials = generateCredentials();
         when(coreClient.getChallenge(credentials.getAddress())).thenReturn("challenge");
-        Signature signature = SignatureUtils.hashAndSign("challenge", credentials.getAddress(), credentials.getEcKeyPair());
+        final Signature signature = SignatureUtils.hashAndSign("challenge", credentials.getEcKeyPair());
         when(coreClient.login(credentials.getAddress(), signature)).thenReturn("token");
         assertAll(
                 () -> assertEquals(TOKEN_PREFIX + "token", loginService.login()),
@@ -143,7 +143,7 @@ void shouldLogin() {
      * </ul>
      */
     @Test
-    void shouldLoginOnceOnSimultaneousCalls(CapturedOutput output)
+    void shouldLoginOnceOnSimultaneousCalls(final CapturedOutput output)
             throws InterruptedException,
             ExecutionException,
             TimeoutException {
@@ -164,7 +164,7 @@ void shouldLoginOnceOnSimultaneousCalls(CapturedOutput output)
 
         final Credentials credentials = generateCredentials();
         when(coreClient.getChallenge(credentials.getAddress())).thenReturn("challenge");
-        final Signature signature = SignatureUtils.hashAndSign("challenge", credentials.getAddress(), credentials.getEcKeyPair());
+        final Signature signature = SignatureUtils.hashAndSign("challenge", credentials.getEcKeyPair());
         when(coreClient.login(credentials.getAddress(), signature))
                 .then(waitForOtherThreads)
                 .thenReturn("token");