Skip to content

Commit 23881a7

Browse files
authored
fix: somes-fixes (#61)
1 parent 3719483 commit 23881a7

File tree

7 files changed

+240
-217
lines changed

7 files changed

+240
-217
lines changed

test/e2e/IexecLayerZeroBridgeScript.t.sol

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ contract IexecLayerZeroBridgeScriptTest is Test {
2323
bytes32 salt = keccak256("salt");
2424

2525
IexecLayerZeroBridgeDeploy public deployer;
26-
address private liquidityUnifier;
26+
address private rlcLiquidityUnifier;
2727
address private rlcCrosschainToken;
2828

2929
// Forks ID
@@ -39,7 +39,7 @@ contract IexecLayerZeroBridgeScriptTest is Test {
3939

4040
// Setup Ethereum Mainnet fork
4141
vm.selectFork(sepoliaFork);
42-
liquidityUnifier = new RLCLiquidityUnifierDeployScript().deploy(
42+
rlcLiquidityUnifier = new RLCLiquidityUnifierDeployScript().deploy(
4343
params.rlcToken, admin, upgrader, params.createxFactory, keccak256("salt")
4444
);
4545

@@ -48,11 +48,15 @@ contract IexecLayerZeroBridgeScriptTest is Test {
4848
rlcCrosschainToken = new RLCCrosschainTokenDeployScript().deploy(
4949
"iEx.ec Network Token", "RLC", admin, admin, params.createxFactory, salt
5050
);
51+
52+
//Add label to make logs more readable
53+
vm.label(address(rlcCrosschainToken), "rlcCrosschainToken");
54+
vm.label(address(rlcLiquidityUnifier), "rlcLiquidityUnifier");
5155
}
5256

5357
function testFork_Deployment_WithApproval() public {
5458
vm.selectFork(sepoliaFork);
55-
_test_Deployment(true, liquidityUnifier);
59+
_test_Deployment(true, rlcLiquidityUnifier);
5660
}
5761

5862
function testFork_Deployment_WithoutApproval() public {
@@ -73,6 +77,7 @@ contract IexecLayerZeroBridgeScriptTest is Test {
7377
salt
7478
)
7579
);
80+
vm.label(address(iexecLayerZeroBridge), "iexecLayerZeroBridge");
7681

7782
assertEq(iexecLayerZeroBridge.owner(), admin);
7883
assertEq(iexecLayerZeroBridge.token(), requireApproval ? params.rlcToken : rlcCrosschainToken);

test/units/RLCCrosschainToken.t.sol

Lines changed: 120 additions & 117 deletions
Large diffs are not rendered by default.

test/units/RLCCrosschainTokenScript.t.sol

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,20 @@ contract RLCCrosschainTokenTest is Test {
2222

2323
function test_Deploy() public {
2424
address crosschainTokenAddress = deployer.deploy(name, symbol, admin, upgrader, createx, salt);
25-
RLCCrosschainToken crossChainToken = RLCCrosschainToken(crosschainTokenAddress);
26-
assertEq(crossChainToken.name(), name);
27-
assertEq(crossChainToken.symbol(), symbol);
28-
assertEq(crossChainToken.owner(), admin);
29-
assertEq(crossChainToken.hasRole(crossChainToken.DEFAULT_ADMIN_ROLE(), admin), true);
30-
assertEq(crossChainToken.hasRole(crossChainToken.UPGRADER_ROLE(), upgrader), true);
25+
RLCCrosschainToken rlcCrosschainToken = RLCCrosschainToken(crosschainTokenAddress);
26+
assertEq(rlcCrosschainToken.name(), name);
27+
assertEq(rlcCrosschainToken.symbol(), symbol);
28+
assertEq(rlcCrosschainToken.owner(), admin);
29+
assertEq(rlcCrosschainToken.hasRole(rlcCrosschainToken.DEFAULT_ADMIN_ROLE(), admin), true);
30+
assertEq(rlcCrosschainToken.hasRole(rlcCrosschainToken.UPGRADER_ROLE(), upgrader), true);
3131

3232
// Make sure the contract has been initialized.
3333
vm.expectRevert(abi.encodeWithSelector(Initializable.InvalidInitialization.selector));
34-
crossChainToken.initialize(name, symbol, admin, upgrader);
34+
rlcCrosschainToken.initialize(name, symbol, admin, upgrader);
35+
36+
//Add label to make logs more readable
37+
vm.label(address(rlcCrosschainToken), "rlcCrosschainToken");
38+
3539
// TODO check that the proxy address is saved.
3640
}
3741

0 commit comments

Comments
 (0)