refactor: Replace if-else with case statement for operation handling in transaction preparation

Author: gfournierPro

.github/workflows/manage-contract-roles-safe.yml

@@ -79,13 +79,20 @@ jobs:
           ROLE_HASH=$(cast keccak "$ROLE_NAME")
           
           # Determine the function selector and encode calldata
-          if [ "${{ inputs.operation }}" = "grant" ]; then
-            TRANSACTION_DATA=$(cast calldata "grantRole(bytes32,address)" "$ROLE_HASH" "${{ inputs.target_address }}")
-            FUNCTION_NAME="grantRole(bytes32,address)"
-          else
-            TRANSACTION_DATA=$(cast calldata "revokeRole(bytes32,address)" "$ROLE_HASH" "${{ inputs.target_address }}")
-            FUNCTION_NAME="revokeRole(bytes32,address)"
-          fi
+          case "${{ inputs.operation }}" in
+            grant)
+              TRANSACTION_DATA=$(cast calldata "grantRole(bytes32,address)" "$ROLE_HASH" "${{ inputs.target_address }}")
+              FUNCTION_NAME="grantRole(bytes32,address)"
+              ;;
+            revoke)
+              TRANSACTION_DATA=$(cast calldata "revokeRole(bytes32,address)" "$ROLE_HASH" "${{ inputs.target_address }}")
+              FUNCTION_NAME="revokeRole(bytes32,address)"
+              ;;
+            *)
+              echo "❌ Error: Unknown operation ${{ inputs.operation }}"
+              exit 1
+              ;;
+          esac
           
           # Prepare transactions array based on role type
           TRANSACTIONS='[]'

.github/workflows/transfer-admin-role-safe.yml

@@ -73,32 +73,38 @@ jobs:
           
           # Prepare transactions array for both contracts
           TRANSACTIONS='[]'
-          
-          if [ "${{ inputs.operation }}" = "begin-transfer" ]; then
-            # beginDefaultAdminTransfer(address newAdmin)
-            TRANSACTION_DATA=$(cast calldata "beginDefaultAdminTransfer(address)" "${{ inputs.new_admin_address }}")
-            FUNCTION_NAME="beginDefaultAdminTransfer(address)"
-            
-            # Create transaction for token contract
-            TRANSACTIONS=$(echo "$TRANSACTIONS" | jq -c --arg to "$TOKEN_CONTRACT" --arg data "$TRANSACTION_DATA" \
-              '. += [{"to": $to, "data": $data}]')
-            
-            # Create transaction for bridge contract
-            TRANSACTIONS=$(echo "$TRANSACTIONS" | jq -c --arg to "$BRIDGE_ADDRESS" --arg data "$TRANSACTION_DATA" \
-              '. += [{"to": $to, "data": $data}]')
-          else
-            # acceptDefaultAdminTransfer()
-            TRANSACTION_DATA=$(cast calldata "acceptDefaultAdminTransfer()")
-            FUNCTION_NAME="acceptDefaultAdminTransfer()"
-            
-            # Create transaction for token contract
-            TRANSACTIONS=$(echo "$TRANSACTIONS" | jq -c --arg to "$TOKEN_CONTRACT" --arg data "$TRANSACTION_DATA" \
-              '. += [{"to": $to, "data": $data}]')
-            
-            # Create transaction for bridge contract
-            TRANSACTIONS=$(echo "$TRANSACTIONS" | jq -c --arg to "$BRIDGE_ADDRESS" --arg data "$TRANSACTION_DATA" \
-              '. += [{"to": $to, "data": $data}]')
-          fi
+          case "${{ inputs.operation }}" in
+            begin-transfer)
+              # beginDefaultAdminTransfer(address newAdmin)
+              TRANSACTION_DATA=$(cast calldata "beginDefaultAdminTransfer(address)" "${{ inputs.new_admin_address }}")
+              FUNCTION_NAME="beginDefaultAdminTransfer(address)"
+              
+              # Create transaction for token contract
+              TRANSACTIONS=$(echo "$TRANSACTIONS" | jq -c --arg to "$TOKEN_CONTRACT" --arg data "$TRANSACTION_DATA" \
+                '. += [{"to": $to, "data": $data}]')
+              
+              # Create transaction for bridge contract
+              TRANSACTIONS=$(echo "$TRANSACTIONS" | jq -c --arg to "$BRIDGE_ADDRESS" --arg data "$TRANSACTION_DATA" \
+                '. += [{"to": $to, "data": $data}]')
+              ;;
+            accept-transfer)
+              # acceptDefaultAdminTransfer()
+              TRANSACTION_DATA=$(cast calldata "acceptDefaultAdminTransfer()")
+              FUNCTION_NAME="acceptDefaultAdminTransfer()"
+              
+              # Create transaction for token contract
+              TRANSACTIONS=$(echo "$TRANSACTIONS" | jq -c --arg to "$TOKEN_CONTRACT" --arg data "$TRANSACTION_DATA" \
+                '. += [{"to": $to, "data": $data}]')
+              
+              # Create transaction for bridge contract
+              TRANSACTIONS=$(echo "$TRANSACTIONS" | jq -c --arg to "$BRIDGE_ADDRESS" --arg data "$TRANSACTION_DATA" \
+                '. += [{"to": $to, "data": $data}]')
+              ;;
+            *)
+              echo "❌ Error: Unknown operation ${{ inputs.operation }}"
+              exit 1
+              ;;
+          esac
           
           echo "transactions=$(echo $TRANSACTIONS | jq -c .)" >> $GITHUB_OUTPUT
           echo "safe-address=${{ secrets.SAFE_ADDRESS }}" >> $GITHUB_OUTPUT