Skip to content

Commit 6a89317

Browse files
style: fix typos and update TODO comments
1 parent 5bc9443 commit 6a89317

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

pre-compute/src/compute/pre_compute_app.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ impl PreComputeAppTrait for PreComputeApp {
5656
/// app.run();
5757
/// ```
5858
fn run(&mut self) -> Result<(), ReplicateStatusCause> {
59-
// TODO: Collect all errors instead of propagating immediately,and return the list of erros
59+
// TODO: Collect all errors instead of propagating immediately, and return the list of errors
6060
self.pre_compute_args = PreComputeArgs::read_args()?;
6161
self.check_output_folder()?;
6262
for dataset in &self.pre_compute_args.datasets {
@@ -163,7 +163,7 @@ mod tests {
163163
use super::*;
164164
use crate::compute::dataset::Dataset;
165165
use crate::compute::pre_compute_args::PreComputeArgs;
166-
use std::fs;
166+
use std::fs;
167167
use tempfile::TempDir;
168168
use testcontainers::core::WaitFor;
169169
use testcontainers::runners::SyncRunner;

pre-compute/src/compute/pre_compute_args.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use crate::compute::utils::env_utils::{TeeSessionEnvironmentVariable, get_env_va
1010
#[derive(Clone, Default)]
1111
pub struct PreComputeArgs {
1212
pub output_dir: String,
13-
// Dataset related field
13+
// Dataset related fields
1414
pub is_dataset_required: bool,
1515
// Input files
1616
pub input_files: Vec<String>,
@@ -195,7 +195,7 @@ mod tests {
195195
vars
196196
}
197197

198-
// TODO: Collect all errors instead of propagating immediately,and return the list of erros
198+
// TODO: Collect all errors instead of propagating immediately, and return the list of errors
199199
fn setup_bulk_dataset_env_vars(count: usize) -> HashMap<String, String> {
200200
let mut vars = HashMap::new();
201201
vars.insert(BulkSize.name(), count.to_string());
@@ -233,7 +233,6 @@ mod tests {
233233

234234
assert_eq!(args.output_dir, OUTPUT_DIR);
235235
assert!(!args.is_dataset_required);
236-
assert_eq!(args.datasets.len(), 0);
237236
assert_eq!(args.input_files.len(), 1);
238237
assert_eq!(args.input_files[0], "https://input-1.txt");
239238
assert_eq!(args.bulk_size, 0);
@@ -282,7 +281,6 @@ mod tests {
282281

283282
assert_eq!(args.output_dir, OUTPUT_DIR);
284283
assert!(!args.is_dataset_required);
285-
assert_eq!(args.datasets.len(), 0);
286284
assert_eq!(args.input_files.len(), 3);
287285
assert_eq!(args.input_files[0], "https://input-1.txt");
288286
assert_eq!(args.input_files[1], "https://input-2.txt");

0 commit comments

Comments
 (0)