Skip to content

Commit 7dfe67d

Browse files
fix: replace dataset parsing error with generic PreComputeFailedUnknownIssue
1 parent ac6f73b commit 7dfe67d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pre-compute/src/compute/pre_compute_args.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ impl PreComputeArgs {
7979
.unwrap_or("0".to_string());
8080
let iexec_bulk_slice_size = iexec_bulk_slice_size_str
8181
.parse::<usize>()
82-
.map_err(|_| ReplicateStatusCause::PreComputeIsDatasetRequiredMissing)?;
82+
.map_err(|_| ReplicateStatusCause::PreComputeFailedUnknownIssue)?; // TODO: replace with a more specific error
8383

8484
let mut datasets = Vec::with_capacity(iexec_bulk_slice_size + 1);
8585

@@ -88,19 +88,19 @@ impl PreComputeArgs {
8888
for i in start_index..=iexec_bulk_slice_size {
8989
let url = get_env_var_or_error(
9090
TeeSessionEnvironmentVariable::IexecDatasetUrl(i),
91-
ReplicateStatusCause::PreComputeDatasetUrlMissing,
91+
ReplicateStatusCause::PreComputeDatasetUrlMissing, // TODO: replace with a more specific error for bulk dataset
9292
)?;
9393
let checksum = get_env_var_or_error(
9494
TeeSessionEnvironmentVariable::IexecDatasetChecksum(i),
95-
ReplicateStatusCause::PreComputeDatasetChecksumMissing,
95+
ReplicateStatusCause::PreComputeDatasetChecksumMissing, // TODO: replace with a more specific error for bulk dataset
9696
)?;
9797
let filename = get_env_var_or_error(
9898
TeeSessionEnvironmentVariable::IexecDatasetFilename(i),
99-
ReplicateStatusCause::PreComputeDatasetFilenameMissing,
99+
ReplicateStatusCause::PreComputeDatasetFilenameMissing, // TODO: replace with a more specific error for bulk dataset
100100
)?;
101101
let key = get_env_var_or_error(
102102
TeeSessionEnvironmentVariable::IexecDatasetKey(i),
103-
ReplicateStatusCause::PreComputeDatasetKeyMissing,
103+
ReplicateStatusCause::PreComputeDatasetKeyMissing, // TODO: replace with a more specific error for bulk dataset
104104
)?;
105105

106106
datasets.push(Dataset::new(url, checksum, filename, key));
@@ -408,7 +408,7 @@ mod tests {
408408
assert!(result.is_err());
409409
assert_eq!(
410410
result.unwrap_err(),
411-
ReplicateStatusCause::PreComputeIsDatasetRequiredMissing
411+
ReplicateStatusCause::PreComputeFailedUnknownIssue
412412
);
413413
});
414414
}

0 commit comments

Comments
 (0)