fix(validators): improve campaignRequest schema validation error message

- Add strict mode to prevent undefined coercion to empty object
- Add custom test to check for undefined/null/empty object before field validation
- Fix error message to show 'campaignRequest is required' instead of 'sign is a required field' when campaignRequest is undefined

Author: SeddikBellamine

src/utils/validators.ts

@@ -117,4 +117,14 @@ export const campaignRequestSchema = () =>
     trust: positiveIntegerStringSchema().required(),
     salt: stringSchema().required(),
     sign: stringSchema().required(),
-  }).typeError('${path} should be a BulkRequest object');
+  })
+    .strict()
+    .typeError('${path} should be a BulkRequest object')
+    .test('is-defined', '${path} is required', (value) => {
+      // Check if value is undefined, null, or an empty object (which would be coerced from undefined)
+      return (
+        value !== undefined &&
+        value !== null &&
+        !(typeof value === 'object' && Object.keys(value).length === 0)
+      );
+    });

tests/e2e/sendEmailCampaign.test.ts

@@ -314,15 +314,12 @@ describe('web3mail.sendEmailCampaign()', () => {
           .catch((e) => (error = e));
 
         expect(error).toBeDefined();
-        // campaignRequest is undefined, so accessing campaignRequest.workerpool throws TypeError
-        // which gets wrapped in WorkflowError
-        const isWorkflowError = error instanceof Web3mailWorkflowError;
-        const isTypeError = error instanceof TypeError;
-        expect(isWorkflowError || isTypeError).toBe(true);
-        // Check message only if it's a WorkflowError
-        expect(
-          !isWorkflowError || error.message === 'Failed to sendEmailCampaign'
-        ).toBe(true);
+
+        const isValidationrror = error instanceof ValidationError;
+        expect(isValidationrror).toBe(true);
+        expect(error.message === 'campaignRequest is a required field').toBe(
+          true
+        );
       },
       MAX_EXPECTED_WEB2_SERVICES_TIME
     );