ci: update whitelist-smart-contract to v1.0.0 and fix workflow variables (#210)

abbesBenayache · PierreJeanjacquot · web-flow · commit 71eab0190739 · 2025-07-24T10:38:49.000+02:00
* ci: update whitelist-smart-contract to v1.0.0 and fix workflow variables

* ci: pass whitelist network via env vars

---------

Co-authored-by: Pierre Jeanjacquot &lt;26487010+PierreJeanjacquot@users.noreply.github.com&gt;
diff --git a/.github/workflows/dapp-deploy.yml b/.github/workflows/dapp-deploy.yml
@@ -138,10 +138,12 @@ jobs:
       - name: Add resource to whitelist
         env:
           CONTRACT_ADDRESS: ${{ vars.WEB3MAIL_WHITELIST_CONTRACT_ADDRESS }}
-          WALLET_PRIVATE_KEY: ${{ secrets.WEB3MAIL_APP_OWNER_PRIVATEKEY }}
+          PRIVATE_KEY: ${{ secrets.WEB3MAIL_APP_OWNER_PRIVATEKEY }}
+          RPC_URL: ${{ secrets.RPC_URL }}
         run: |
           cd node_modules/whitelist-smart-contract
-          export ADDRESS_TO_ADD=$(cat ../../deployment-dapp/.app-address) && npm run addResourceToWhitelist
+          export ADDRESS_TO_ADD=$(cat ../../deployment-dapp/.app-address)
+          npm run addResourceToWhitelist -- --network ${{ vars.WHITELIST_NETWORK_NAME }}
 
       - name: Configure ENS
         if: ${{ vars.DAPP_ENS_NAME }}
diff --git a/.github/workflows/dapp-release.yml b/.github/workflows/dapp-release.yml
@@ -123,10 +123,12 @@ jobs:
       - name: Add resource to whitelist
         env:
           CONTRACT_ADDRESS: ${{ vars.WEB3MAIL_WHITELIST_CONTRACT_ADDRESS }}
-          WALLET_PRIVATE_KEY: ${{ secrets.WEB3MAIL_APP_OWNER_PRIVATEKEY }}
+          PRIVATE_KEY: ${{ secrets.WEB3MAIL_APP_OWNER_PRIVATEKEY }}
+          RPC_URL: ${{ secrets.RPC_URL }}
         run: |
           cd node_modules/whitelist-smart-contract
-          export ADDRESS_TO_ADD=$(cat ../../deployment-dapp/.app-address) && npm run addResourceToWhitelist
+          export ADDRESS_TO_ADD=$(cat ../../deployment-dapp/.app-address)
+          npm run addResourceToWhitelist -- --network ${{ vars.WHITELIST_NETWORK_NAME }}
 
       - name: Configure ENS
         if: ${{ vars.DAPP_ENS_NAME }}
diff --git a/.github/workflows/reusable-npm.yml b/.github/workflows/reusable-npm.yml
@@ -1,4 +1,4 @@
-name: publish-npm-sdk
+name: reusable-npm-publish
 
 on:
   workflow_call:
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -73,6 +73,6 @@
     "jest": "^29.7.0",
     "prettier": "^2.8.4",
     "typescript": "^5.5.2",
-    "whitelist-smart-contract": "github:iExecBlockchainComputing/whitelist-smart-contract#0.2.1"
+    "whitelist-smart-contract": "github:iExecBlockchainComputing/whitelist-smart-contract#1.0.0"
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-name: publish-npm-sdk`
	`1`	`+name: reusable-npm-publish`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`workflow_call:`
Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,6 @@`
`73`	`73`	`"jest": "^29.7.0",`
`74`	`74`	`"prettier": "^2.8.4",`
`75`	`75`	`"typescript": "^5.5.2",`
`76`		`- "whitelist-smart-contract": "github:iExecBlockchainComputing/whitelist-smart-contract#0.2.1"`
	`76`	`+ "whitelist-smart-contract": "github:iExecBlockchainComputing/whitelist-smart-contract#1.0.0"`
`77`	`77`	`}`
`78`	`78`	`}`