chore(ci): update dapp CI workflows and pushSecretScript

Author: abbesBenayache

.github/workflows/dapp-ci.yml

@@ -46,7 +46,7 @@ jobs:
       MJ_APIKEY_PRIVATE: ${{ secrets.MAILJET_APIKEY_PRIVATE }}
       MJ_SENDER: ${{ secrets.MAILJET_SENDER }}
       MAILGUN_APIKEY: ${{ secrets.MAILGUN_APIKEY }}
-      WEB3MAIL_WHITELISTED_APPS: ${{ secrets.WEB3MAIL_WHITELISTED_APPS }}
+      WEB3MAIL_WHITELISTED_APPS: ${{ vars.WEB3MAIL_WHITELISTED_APPS }}
     steps:
       - uses: actions/checkout@v4
 

.github/workflows/reusable-dapp-deploy.yml

@@ -136,7 +136,7 @@ jobs:
           MJ_APIKEY_PRIVATE: ${{ secrets.mailjet-apikey-private }}
           MJ_SENDER: ${{ secrets.mailjet-sender }}
           MAILGUN_APIKEY: ${{ secrets.mailgun-apikey }}
-          WEB3MAIL_WHITELISTED_APPS: ${{ secrets.WEB3MAIL_WHITELISTED_APPS }}
+          WEB3MAIL_WHITELISTED_APPS: ${{ vars.WEB3MAIL_WHITELISTED_APPS }}
         run: |
           cd deployment-dapp
           npm run push-dapp-secret

deployment-dapp/src/pushSecretScript.ts

@@ -18,7 +18,7 @@ const main = async () => {
   if (!MJ_APIKEY_PRIVATE) throw Error('Missing env MJ_APIKEY_PRIVATE');
   if (!MJ_SENDER) throw Error('Missing env MJ_SENDER');
   if (!MAILGUN_APIKEY) throw Error('Missing env MAILGUN_APIKEY');
-  if (!WEB3MAIL_WHITELISTED_APPS)
+  if (WEB3MAIL_WHITELISTED_APPS === undefined)
     throw Error('Missing env WEB3MAIL_WHITELISTED_APPS');
 
   if (!WALLET_PRIVATE_KEY)
@@ -29,8 +29,9 @@ const main = async () => {
   const appAddress = await loadAppAddress();
 
   if (!appAddress) throw Error('Failed to get app address'); // If the app was not deployed, do not continue
+
   const fullWhitelistedApps = [
-    ...new Set([...WEB3MAIL_WHITELISTED_APPS.split(','), appAddress]),
+    ...new Set([...JSON.parse(WEB3MAIL_WHITELISTED_APPS), appAddress]),
   ];
 
   const jsonSecret = JSON.stringify({