refactor: clean up deployment scripts and use environment variables for docker image tags

Author: abbesBenayache

deployment-dapp/src/config/config.ts

@@ -1,4 +1,3 @@
-import { readFileSync } from 'fs';
 
 //hosting url
 export const HOST = 'https://bellecour.iex.ec';
@@ -17,16 +16,9 @@ export const APP_TAG = ['tee', 'scone'];
 export const WEB3_MAIL_ENS_NAME_DEV = 'web3mail-dev.apps.iexec.eth';
 export const WEB3_MAIL_ENS_NAME_PROD = 'web3mail.apps.iexec.eth';
 
-//scone image
-const SCONIFIER_VERSION = '5.7.5-v12';
-const dappVersion = JSON.parse(
-  readFileSync('../dapp/package.json', 'utf-8')
-).version;
 
 export const DOCKER_IMAGE_NAMESPACE = 'iexechub';
 export const DOCKER_IMAGE_REPOSITORY = 'web3mail-dapp';
-export const DOCKER_IMAGE_PROD_TAG = `${dappVersion}-sconify-${SCONIFIER_VERSION}-production`;
-export const DOCKER_IMAGE_DEV_TAG = `dev-${process.env.GITHUB_SHA}-sconify-${SCONIFIER_VERSION}-production`;
 
 //GitHub Actions environment variables
 export const GITHUB_DEPLOY_ENVIRONMENT =

deployment-dapp/src/deployScript.ts

@@ -39,11 +39,12 @@ const main = async () => {
 
   const iexec = getIExec(privateKey);
 
-  let dockerImageTag;
-  if (deployEnvironment === GITHUB_DEPLOY_TO_DEV) {
-    dockerImageTag = DOCKER_IMAGE_DEV_TAG;
-  } else if (deployEnvironment === GITHUB_DEPLOY_TO_PROD) {
-    dockerImageTag = DOCKER_IMAGE_PROD_TAG;
+  const dockerImageTag = deployEnvironment === GITHUB_DEPLOY_TO_DEV
+    ? DOCKER_IMAGE_DEV_TAG
+    : DOCKER_IMAGE_PROD_TAG;
+
+  if (!dockerImageTag) {
+    throw Error(`Missing docker image tag for environment ${deployEnvironment}`);
   }
 
   //deploy app