[EXPLORER] AppBar Part 3 (reactos#7966)

Follow-up of reactos#7946.
JIRA issue: CORE-7237
- Implement ABM_GETSTATE,
 ABM_GETTASKBARPOS, ABM_ACTIVATE,
  ABM_WINDOWPOSCHANGED,
  ABM_GETAUTOHIDEBAR,
  ABM_SETAUTOHIDEBAR, and
  ABM_SETSTATE appbar messages.
- Implement TWM_SETZORDER tray
  message.

Author: katahiromz

base/shell/explorer/appbar.cpp

@@ -11,6 +11,7 @@
 
 CAppBarManager::CAppBarManager()
     : m_hAppBarDPA(NULL)
+    , m_ahwndAutoHideBars { 0 }
 {
 }
 
@@ -450,13 +451,40 @@ void CAppBarManager::RecomputeAllWorkareas()
     ::EnumDisplayMonitors(NULL, NULL, CAppBarManager::MonitorEnumProc, (LPARAM)this);
 }
 
+BOOL CAppBarManager::SetAutoHideBar(_In_ HWND hwndTarget, _In_ BOOL bSetOrReset, _In_ UINT uSide)
+{
+    ATLASSERT(uSide < _countof(m_ahwndAutoHideBars));
+    HWND *phwndAutoHide = &m_ahwndAutoHideBars[uSide];
+    if (!IsWindow(*phwndAutoHide))
+        *phwndAutoHide = NULL;
+
+    if (bSetOrReset) // Set?
+    {
+        if (!*phwndAutoHide)
+            *phwndAutoHide = hwndTarget;
+        return *phwndAutoHide == hwndTarget;
+    }
+    else // Reset
+    {
+        if (*phwndAutoHide == hwndTarget)
+            *phwndAutoHide = NULL;
+        return TRUE;
+    }
+}
+
+void CAppBarManager::OnAppBarActivationChange2(_In_ HWND hwndNewAutoHide, _In_ UINT uSide)
+{
+    HWND hwndAutoHideBar = OnAppBarGetAutoHideBar(uSide);
+    if (hwndAutoHideBar && hwndAutoHideBar != hwndNewAutoHide)
+        ::PostMessageW(GetTrayWnd(), TWM_SETZORDER, (WPARAM)hwndAutoHideBar, uSide);
+}
+
 PAPPBAR_COMMAND
 CAppBarManager::GetAppBarMessage(_Inout_ PCOPYDATASTRUCT pCopyData)
 {
     PAPPBAR_COMMAND pData = (PAPPBAR_COMMAND)pCopyData->lpData;
 
-    if (pCopyData->cbData != sizeof(*pData) ||
-        pData->abd.cbSize != sizeof(pData->abd))
+    if (pCopyData->cbData != sizeof(*pData) || pData->abd.cbSize != sizeof(pData->abd))
     {
         ERR("Invalid AppBar message\n");
         return NULL;
@@ -465,6 +493,80 @@ CAppBarManager::GetAppBarMessage(_Inout_ PCOPYDATASTRUCT pCopyData)
     return pData;
 }
 
+// ABM_GETSTATE
+UINT CAppBarManager::OnAppBarGetState()
+{
+    return (IsAutoHideState() ? ABS_AUTOHIDE : 0) | (IsAlwaysOnTop() ? ABS_ALWAYSONTOP : 0);
+}
+
+// ABM_GETTASKBARPOS
+BOOL CAppBarManager::OnAppBarGetTaskbarPos(_Inout_ PAPPBAR_COMMAND pData)
+{
+    PAPPBARDATAINTEROP pOutput = AppBar_LockOutput(pData);
+    if (!pOutput)
+    {
+        ERR("!pOutput: %d\n", pData->dwProcessId);
+        return FALSE;
+    }
+
+    pOutput->rc = *GetTrayRect();
+    pOutput->uEdge = GetPosition();
+
+    AppBar_UnLockOutput(pOutput);
+    return TRUE;
+}
+
+// ABM_ACTIVATE, ABM_WINDOWPOSCHANGED
+void CAppBarManager::OnAppBarActivationChange(_In_ const APPBAR_COMMAND *pData)
+{
+    HWND hWnd = (HWND)UlongToHandle(pData->abd.hWnd32);
+    PAPPBAR pAppBar = FindAppBar(hWnd);
+    if (!pAppBar)
+    {
+        ERR("Not found: %p\n", hWnd);
+        return;
+    }
+
+    HWND hwndAppBar = pAppBar->hWnd;
+    for (UINT uSide = ABE_LEFT; uSide <= ABE_BOTTOM; ++uSide)
+    {
+        if (m_ahwndAutoHideBars[uSide] == hwndAppBar && uSide != pAppBar->uEdge)
+            return;
+    }
+
+    OnAppBarActivationChange2(hwndAppBar, pAppBar->uEdge);
+}
+
+// ABM_GETAUTOHIDEBAR
+HWND CAppBarManager::OnAppBarGetAutoHideBar(_In_ UINT uSide)
+{
+    if (uSide >= _countof(m_ahwndAutoHideBars))
+        return NULL;
+
+    if (!::IsWindow(m_ahwndAutoHideBars[uSide]))
+        m_ahwndAutoHideBars[uSide] = NULL;
+    return m_ahwndAutoHideBars[uSide];
+}
+
+// ABM_SETAUTOHIDEBAR
+BOOL CAppBarManager::OnAppBarSetAutoHideBar(_In_ const APPBAR_COMMAND *pData)
+{
+    if (pData->abd.uEdge >= _countof(m_ahwndAutoHideBars))
+        return FALSE;
+    HWND hwndTarget = (HWND)UlongToHandle(pData->abd.hWnd32);
+    return SetAutoHideBar(hwndTarget, (BOOL)pData->abd.lParam64, pData->abd.uEdge);
+}
+
+// ABM_SETSTATE
+void CAppBarManager::OnAppBarSetState(_In_ UINT uState)
+{
+    if ((uState & ~(ABS_AUTOHIDE | ABS_ALWAYSONTOP)))
+        return;
+
+    SetAutoHideState(!!(uState & ABS_AUTOHIDE));
+    UpdateAlwaysOnTop(!!(uState & ABS_ALWAYSONTOP));
+}
+
 // WM_COPYDATA TABDMC_APPBAR
 LRESULT CAppBarManager::OnAppBarMessage(_Inout_ PCOPYDATASTRUCT pCopyData)
 {
@@ -485,6 +587,21 @@ LRESULT CAppBarManager::OnAppBarMessage(_Inout_ PCOPYDATASTRUCT pCopyData)
         case ABM_SETPOS:
             OnAppBarSetPos(pData);
             break;
+        case ABM_GETSTATE:
+            return OnAppBarGetState();
+        case ABM_GETTASKBARPOS:
+            return OnAppBarGetTaskbarPos(pData);
+        case ABM_ACTIVATE:
+        case ABM_WINDOWPOSCHANGED:
+            OnAppBarActivationChange(pData);
+            break;
+        case ABM_GETAUTOHIDEBAR:
+            return (LRESULT)OnAppBarGetAutoHideBar(pData->abd.uEdge);
+        case ABM_SETAUTOHIDEBAR:
+            return OnAppBarSetAutoHideBar(pData);
+        case ABM_SETSTATE:
+            OnAppBarSetState((UINT)pData->abd.lParam64);
+            break;
         default:
         {
             FIXME("0x%X\n", pData->dwMessage);

base/shell/explorer/appbar.h

@@ -51,6 +51,7 @@ class CAppBarManager
 
 protected:
     HDPA m_hAppBarDPA; // DPA (Dynamic Pointer Array)
+    HWND m_ahwndAutoHideBars[4]; // The side --> auto-hide window
 
     PAPPBAR FindAppBar(_In_ HWND hwndAppBar) const;
     void EliminateAppBar(_In_ INT iItem);
@@ -60,11 +61,19 @@ class CAppBarManager
     void ComputeHiddenRect(_Inout_ PRECT prc, _In_ UINT uSide);
     PAPPBAR_COMMAND GetAppBarMessage(_Inout_ PCOPYDATASTRUCT pCopyData);
     void GetDockedRect(_Out_ PRECT prcDocked);
+    BOOL SetAutoHideBar(_In_ HWND hwndTarget, _In_ BOOL bSetOrReset, _In_ UINT uSide);
+    void OnAppBarActivationChange2(_In_ HWND hwndNewAutoHide, _In_ UINT uSide);
 
     BOOL OnAppBarNew(_In_ const APPBAR_COMMAND *pData);
     void OnAppBarRemove(_In_ const APPBAR_COMMAND *pData);
     void OnAppBarQueryPos(_Inout_ PAPPBAR_COMMAND pData);
     void OnAppBarSetPos(_Inout_ PAPPBAR_COMMAND pData);
+    UINT OnAppBarGetState();
+    BOOL OnAppBarGetTaskbarPos(_Inout_ PAPPBAR_COMMAND pData);
+    void OnAppBarActivationChange(_In_ const APPBAR_COMMAND *pData);
+    HWND OnAppBarGetAutoHideBar(_In_ UINT uSide);
+    BOOL OnAppBarSetAutoHideBar(_In_ const APPBAR_COMMAND *pData);
+    void OnAppBarSetState(_In_ UINT uState);
 
     void OnAppBarNotifyAll(
         _In_opt_ HMONITOR hMon,
@@ -89,11 +98,15 @@ class CAppBarManager
 
     virtual BOOL IsAutoHideState() const = 0;
     virtual BOOL IsHidingState() const = 0;
-    virtual HMONITOR GetMonitor() const = 0;
-    virtual HMONITOR GetPreviousMonitor() const = 0;
+    virtual BOOL IsAlwaysOnTop() const = 0;
+    virtual HMONITOR& GetMonitor() = 0;
+    virtual HMONITOR& GetPreviousMonitor() = 0;
     virtual INT GetPosition() const = 0;
     virtual const RECT* GetTrayRect() = 0;
+    virtual HWND GetTrayWnd() const = 0;
     virtual HWND GetDesktopWnd() const = 0;
+    virtual void SetAutoHideState(_In_ BOOL bAutoHide) = 0;
+    virtual void UpdateAlwaysOnTop(_In_ BOOL bAlwaysOnTop) = 0;
 
     static BOOL CALLBACK
     MonitorEnumProc(

base/shell/explorer/precomp.h

@@ -132,6 +132,7 @@ HRESULT WINAPI _CBandSite_CreateInstance(LPUNKNOWN pUnkOuter, REFIID riid, void
 #define TWM_GETTASKSWITCH (WM_USER + 236)
 #define TWM_OPENSTARTMENU (WM_USER + 260)
 #define TWM_SETTINGSCHANGED (WM_USER + 300)
+#define TWM_SETZORDER (WM_USER + 338)
 #define TWM_PULSE (WM_USER + 400)
 
 extern const GUID IID_IShellDesktopTray;