Skip to content

Commit cffbc59

Browse files
committed
[FREELDR] Fix tcpip.sys issue
1 parent 4cc6c38 commit cffbc59

File tree

4 files changed

+58
-39
lines changed

4 files changed

+58
-39
lines changed

boot/freeldr/freeldr/include/peloader.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ BOOLEAN
5959
PeLdrScanImportDescriptorTable(
6060
IN OUT PLIST_ENTRY ModuleListHead,
6161
IN PCCH DirectoryPath,
62+
IN PCCH ArcPath,
6263
IN PLDR_DATA_TABLE_ENTRY ScanDTE);
6364

6465
BOOLEAN

boot/freeldr/freeldr/lib/fs/ntfs.c

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -525,19 +525,9 @@ static BOOLEAN NtfsCompareFileName(PCHAR FileName, PNTFS_INDEX_ENTRY IndexEntry)
525525
if (strlen(FileName) != EntryFileNameLength)
526526
return FALSE;
527527

528-
/* Do case-sensitive compares for Posix file names. */
529-
if (IndexEntry->FileName.FileNameType == NTFS_FILE_NAME_POSIX)
530-
{
531-
for (i = 0; i < EntryFileNameLength; i++)
532-
if (EntryFileName[i] != FileName[i])
533-
return FALSE;
534-
}
535-
else
536-
{
537-
for (i = 0; i < EntryFileNameLength; i++)
538-
if (tolower(EntryFileName[i]) != tolower(FileName[i]))
539-
return FALSE;
540-
}
528+
for (i = 0; i < EntryFileNameLength; i++)
529+
if (tolower(EntryFileName[i]) != tolower(FileName[i]))
530+
return FALSE;
541531

542532
return TRUE;
543533
}

boot/freeldr/freeldr/lib/peloader.c

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ static BOOLEAN
130130
PeLdrpLoadAndScanReferencedDll(
131131
IN OUT PLIST_ENTRY ModuleListHead,
132132
IN PCCH DirectoryPath,
133+
IN PCCH ArcPath,
133134
IN PCH ImportName,
134135
IN PLIST_ENTRY Parent OPTIONAL,
135136
OUT PLDR_DATA_TABLE_ENTRY *DataTableEntry);
@@ -145,6 +146,7 @@ PeLdrpBindImportName(
145146
_In_ ULONG ExportSize,
146147
_In_ BOOLEAN ProcessForwards,
147148
_In_ PCSTR DirectoryPath,
149+
_In_ PCSTR ArcPath,
148150
_In_ PLIST_ENTRY Parent)
149151
{
150152
ULONG Ordinal;
@@ -316,6 +318,7 @@ PeLdrpBindImportName(
316318
/* Now let's try to load it! */
317319
Success = PeLdrpLoadAndScanReferencedDll(ModuleListHead,
318320
DirectoryPath,
321+
ArcPath,
319322
ForwardDllName,
320323
Parent,
321324
&DataTableEntry);
@@ -366,6 +369,7 @@ PeLdrpBindImportName(
366369
RefExportSize,
367370
TRUE,
368371
DirectoryPath,
372+
ArcPath,
369373
Parent);
370374

371375
/* Fill out the ThunkData with data from RefThunkData */
@@ -389,31 +393,36 @@ static BOOLEAN
389393
PeLdrpLoadAndScanReferencedDll(
390394
IN OUT PLIST_ENTRY ModuleListHead,
391395
IN PCCH DirectoryPath,
396+
IN PCCH ArcPath,
392397
IN PCH ImportName,
393398
IN PLIST_ENTRY Parent OPTIONAL,
394399
OUT PLDR_DATA_TABLE_ENTRY *DataTableEntry)
395400
{
401+
CHAR ArcDllName[256];
396402
CHAR FullDllName[256];
397403
BOOLEAN Success;
398404
PVOID BasePA = NULL;
399405

400406
/* Prepare the full path to the file to be loaded */
401-
RtlStringCbCopyA(FullDllName, sizeof(FullDllName), DirectoryPath);
402-
RtlStringCbCatA(FullDllName, sizeof(FullDllName), ImportName);
407+
RtlStringCbCopyA(ArcDllName, sizeof(ArcDllName), ArcPath);
408+
RtlStringCbCatA(ArcDllName, sizeof(ArcDllName), ImportName);
403409

404-
TRACE("Loading referenced DLL: %s\n", FullDllName);
410+
TRACE("Loading referenced DLL: %s\n", ArcDllName);
405411

406412
if (PeLdrImportDllLoadCallback)
407-
PeLdrImportDllLoadCallback(FullDllName);
413+
PeLdrImportDllLoadCallback(ArcDllName);
408414

409415
/* Load the image */
410-
Success = PeLdrLoadImage(FullDllName, LoaderBootDriver, &BasePA);
416+
Success = PeLdrLoadImage(ArcDllName, LoaderBootDriver, &BasePA);
411417
if (!Success)
412418
{
413-
ERR("PeLdrLoadImage('%s') failed\n", FullDllName);
419+
ERR("PeLdrLoadImage('%s') failed\n", ArcDllName);
414420
return Success;
415421
}
416422

423+
RtlStringCbCopyA(FullDllName, sizeof(FullDllName), DirectoryPath);
424+
RtlStringCbCatA(FullDllName, sizeof(FullDllName), ImportName);
425+
417426
/* Allocate DTE for newly loaded DLL */
418427
Success = PeLdrAllocateDataTableEntry(Parent ? Parent->Blink : ModuleListHead,
419428
ImportName,
@@ -437,7 +446,7 @@ PeLdrpLoadAndScanReferencedDll(
437446
TRACE("PeLdrScanImportDescriptorTable() calling ourselves for '%.*S'\n",
438447
(*DataTableEntry)->BaseDllName.Length / sizeof(WCHAR),
439448
VaToPa((*DataTableEntry)->BaseDllName.Buffer));
440-
Success = PeLdrScanImportDescriptorTable(ModuleListHead, DirectoryPath, *DataTableEntry);
449+
Success = PeLdrScanImportDescriptorTable(ModuleListHead, DirectoryPath, ArcPath, *DataTableEntry);
441450
if (!Success)
442451
{
443452
/* Cleanup and bail out */
@@ -458,6 +467,7 @@ PeLdrpScanImportAddressTable(
458467
_In_ PIMAGE_THUNK_DATA ThunkName,
459468
_Inout_ PIMAGE_THUNK_DATA ThunkData,
460469
_In_ PCSTR DirectoryPath,
470+
_In_ PCSTR ArcPath,
461471
_In_ PLIST_ENTRY Parent)
462472
{
463473
PIMAGE_EXPORT_DIRECTORY ExportDirectory = NULL;
@@ -504,6 +514,7 @@ PeLdrpScanImportAddressTable(
504514
ExportSize,
505515
FALSE,
506516
DirectoryPath,
517+
ArcPath,
507518
Parent);
508519
/* Fail if binding was unsuccessful */
509520
if (!Success)
@@ -629,6 +640,7 @@ BOOLEAN
629640
PeLdrScanImportDescriptorTable(
630641
IN OUT PLIST_ENTRY ModuleListHead,
631642
IN PCCH DirectoryPath,
643+
IN PCCH ArcPath,
632644
IN PLDR_DATA_TABLE_ENTRY ScanDTE)
633645
{
634646
PLDR_DATA_TABLE_ENTRY DataTableEntry;
@@ -675,6 +687,7 @@ PeLdrScanImportDescriptorTable(
675687
{
676688
Success = PeLdrpLoadAndScanReferencedDll(ModuleListHead,
677689
DirectoryPath,
690+
ArcPath,
678691
ImportName,
679692
&ScanDTE->InLoadOrderLinks,
680693
&DataTableEntry);
@@ -692,6 +705,7 @@ PeLdrScanImportDescriptorTable(
692705
ThunkName,
693706
ThunkData,
694707
DirectoryPath,
708+
ArcPath,
695709
&ScanDTE->InLoadOrderLinks);
696710

697711
if (!Success)
@@ -1083,7 +1097,7 @@ PeLdrLoadBootImage(
10831097
}
10841098

10851099
/* Resolve imports */
1086-
Success = PeLdrScanImportDescriptorTable(&FrLdrModuleList, "", *DataTableEntry);
1100+
Success = PeLdrScanImportDescriptorTable(&FrLdrModuleList, "", "", *DataTableEntry);
10871101
if (!Success)
10881102
{
10891103
/* Cleanup and bail out */

boot/freeldr/freeldr/ntldr/winldr.c

Lines changed: 32 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,8 @@ WinLdrLoadDeviceDriver(PLIST_ENTRY LoadOrderListHead,
314314
PLDR_DATA_TABLE_ENTRY *DriverDTE)
315315
{
316316
CHAR FullPath[1024];
317+
CHAR FullFileName[1024];
318+
CHAR ArcPath[1024];
317319
CHAR DriverPath[1024];
318320
CHAR DllName[1024];
319321
PCHAR DriverNamePos;
@@ -349,21 +351,23 @@ WinLdrLoadDeviceDriver(PLIST_ENTRY LoadOrderListHead,
349351
}
350352

351353
// It's not loaded, we have to load it
352-
RtlStringCbPrintfA(FullPath, sizeof(FullPath), "%s%wZ", BootPath, FilePath);
354+
RtlStringCbPrintfA(ArcPath, sizeof(ArcPath), "%s%wZ", BootPath, FilePath);
353355

354-
NtLdrOutputLoadMsg(FullPath, NULL);
355-
Success = PeLdrLoadImage(FullPath, LoaderBootDriver, &DriverBase);
356+
NtLdrOutputLoadMsg(ArcPath, NULL);
357+
Success = PeLdrLoadImage(ArcPath, LoaderBootDriver, &DriverBase);
356358
if (!Success)
357359
{
358360
ERR("PeLdrLoadImage('%s') failed\n", DllName);
359361
return FALSE;
360362
}
361363

362364
// Allocate a DTE for it
365+
RtlStringCbPrintfA(FullFileName, sizeof(FullFileName), "\\SystemRoot\\%s%s", DriverPath, DllName);
366+
363367
Success = PeLdrAllocateDataTableEntry(LoadOrderListHead,
364-
DllName,
365-
DllName,
366-
PaToVa(DriverBase),
368+
DllName,
369+
FullFileName,
370+
PaToVa(DriverBase),
367371
DriverDTE);
368372
if (!Success)
369373
{
@@ -380,8 +384,10 @@ WinLdrLoadDeviceDriver(PLIST_ENTRY LoadOrderListHead,
380384
(*DriverDTE)->Flags |= Flags;
381385

382386
// Look for any dependencies it may have, and load them too
383-
RtlStringCbPrintfA(FullPath, sizeof(FullPath), "%s%s", BootPath, DriverPath);
384-
Success = PeLdrScanImportDescriptorTable(LoadOrderListHead, FullPath, *DriverDTE);
387+
RtlStringCbPrintfA(ArcPath, sizeof(ArcPath), "%s%s", BootPath, DriverPath);
388+
RtlStringCbPrintfA(FullPath, sizeof(FullPath), "\\SystemRoot\\%s", DriverPath);
389+
390+
Success = PeLdrScanImportDescriptorTable(LoadOrderListHead, FullPath, ArcPath, *DriverDTE);
385391
if (!Success)
386392
{
387393
/* Cleanup and bail out */
@@ -535,6 +541,7 @@ PVOID
535541
LoadModule(
536542
IN OUT PLOADER_PARAMETER_BLOCK LoaderBlock,
537543
IN PCCH Path,
544+
IN PCCH ArcPath,
538545
IN PCCH File,
539546
IN PCCH ImportName, // BaseDllName
540547
IN TYPE_OF_MEMORY MemoryType,
@@ -543,6 +550,7 @@ LoadModule(
543550
{
544551
BOOLEAN Success;
545552
CHAR FullFileName[MAX_PATH];
553+
CHAR ArcFileName[MAX_PATH];
546554
CHAR ProgressString[256];
547555
PVOID BaseAddress;
548556

@@ -552,8 +560,11 @@ LoadModule(
552560
RtlStringCbCopyA(FullFileName, sizeof(FullFileName), Path);
553561
RtlStringCbCatA(FullFileName, sizeof(FullFileName), File);
554562

563+
RtlStringCbCopyA(ArcFileName, sizeof(ArcFileName), ArcPath);
564+
RtlStringCbCatA(ArcFileName, sizeof(ArcFileName), File);
565+
555566
NtLdrOutputLoadMsg(FullFileName, NULL);
556-
Success = PeLdrLoadImage(FullFileName, MemoryType, &BaseAddress);
567+
Success = PeLdrLoadImage(ArcFileName, MemoryType, &BaseAddress);
557568
if (!Success)
558569
{
559570
ERR("PeLdrLoadImage('%s') failed\n", File);
@@ -649,15 +660,18 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion,
649660
PVOID KernelBase, HalBase, KdDllBase = NULL;
650661
PLDR_DATA_TABLE_ENTRY HalDTE, KdDllDTE = NULL;
651662
CHAR DirPath[MAX_PATH];
663+
CHAR ArcPath[MAX_PATH];
652664
CHAR HalFileName[MAX_PATH];
653665
CHAR KernelFileName[MAX_PATH];
654666
CHAR KdDllName[MAX_PATH];
655667

656668
if (!KernelDTE) return FALSE;
657669

658670
/* Initialize SystemRoot\System32 path */
659-
RtlStringCbCopyA(DirPath, sizeof(DirPath), BootPath);
660-
RtlStringCbCatA(DirPath, sizeof(DirPath), "system32\\");
671+
RtlStringCbCopyA(DirPath, sizeof(DirPath), "\\SystemRoot\\system32\\");
672+
673+
RtlStringCbCopyA(ArcPath, sizeof(ArcPath), BootPath);
674+
RtlStringCbCatA(ArcPath, sizeof(ArcPath), "system32\\");
661675

662676
/* Parse the boot options */
663677
TRACE("LoadWindowsCore: BootOptions '%s'\n", BootOptions);
@@ -780,7 +794,7 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion,
780794
*/
781795

782796
/* Load the Kernel */
783-
KernelBase = LoadModule(LoaderBlock, DirPath, KernelFileName,
797+
KernelBase = LoadModule(LoaderBlock, DirPath, ArcPath, KernelFileName,
784798
"ntoskrnl.exe", LoaderSystemCode, KernelDTE, 30);
785799
if (!KernelBase)
786800
{
@@ -790,7 +804,7 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion,
790804
}
791805

792806
/* Load the HAL */
793-
HalBase = LoadModule(LoaderBlock, DirPath, HalFileName,
807+
HalBase = LoadModule(LoaderBlock, DirPath, ArcPath, HalFileName,
794808
"hal.dll", LoaderHalCode, &HalDTE, 35);
795809
if (!HalBase)
796810
{
@@ -865,7 +879,7 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion,
865879
_strlwr(KdDllName);
866880

867881
/* Load the KD DLL. Override its base DLL name to the default "KDCOM.DLL". */
868-
KdDllBase = LoadModule(LoaderBlock, DirPath, KdDllName,
882+
KdDllBase = LoadModule(LoaderBlock, DirPath, ArcPath, KdDllName,
869883
"kdcom.dll", LoaderSystemCode, &KdDllDTE, 40);
870884
if (!KdDllBase)
871885
{
@@ -878,7 +892,7 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion,
878892
IsCustomKdDll = FALSE;
879893
RtlStringCbCopyA(KdDllName, sizeof(KdDllName), "kdcom.dll");
880894

881-
KdDllBase = LoadModule(LoaderBlock, DirPath, KdDllName,
895+
KdDllBase = LoadModule(LoaderBlock, DirPath, ArcPath, KdDllName,
882896
"kdcom.dll", LoaderSystemCode, &KdDllDTE, 40);
883897
}
884898

@@ -892,21 +906,21 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion,
892906
}
893907

894908
/* Load all referenced DLLs for Kernel, HAL and Kernel Debugger Transport DLL */
895-
Success = PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, *KernelDTE);
909+
Success = PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, ArcPath, *KernelDTE);
896910
if (!Success)
897911
{
898912
UiMessageBox("Could not load %s", KernelFileName);
899913
goto Quit;
900914
}
901-
Success = PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, HalDTE);
915+
Success = PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, ArcPath, HalDTE);
902916
if (!Success)
903917
{
904918
UiMessageBox("Could not load %s", HalFileName);
905919
goto Quit;
906920
}
907921
if (KdDllDTE)
908922
{
909-
Success = PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, KdDllDTE);
923+
Success = PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, ArcPath, KdDllDTE);
910924
if (!Success)
911925
{
912926
UiMessageBox("Could not load %s", KdDllName);

0 commit comments

Comments
 (0)