[SHELL32][CMD][SHLWAPI] Use the openas verb when invoking unknown file types (reactos#7981)

CORE-20184

Author: whindsaks

base/shell/cmd/cmd.c

@@ -266,10 +266,10 @@ typedef BOOL (WINAPI *MYEX)(LPSHELLEXECUTEINFO lpExecInfo);
 HANDLE RunFile(DWORD flags, LPTSTR filename, LPTSTR params,
                LPTSTR directory, INT show)
 {
-    SHELLEXECUTEINFO sei;
+    SHELLEXECUTEINFO sei = { sizeof(sei), flags | SEE_MASK_FLAG_DDEWAIT };
     HMODULE     hShell32;
     MYEX        hShExt;
-    BOOL        ret;
+    UINT        err;
 
     TRACE ("RunFile(%s)\n", debugstr_aw(filename));
     hShell32 = LoadLibrary(_T("SHELL32.DLL"));
@@ -289,19 +289,17 @@ HANDLE RunFile(DWORD flags, LPTSTR filename, LPTSTR params,
 
     TRACE ("RunFile: ShellExecuteExA/W is at %x\n", hShExt);
 
-    memset(&sei, 0, sizeof sei);
-    sei.cbSize = sizeof sei;
-    sei.fMask = flags;
     sei.lpFile = filename;
     sei.lpParameters = params;
     sei.lpDirectory = directory;
     sei.nShow = show;
-    ret = hShExt(&sei);
-
-    TRACE ("RunFile: ShellExecuteExA/W returned 0x%p\n", ret);
+    err = hShExt(&sei) ? ERROR_SUCCESS : GetLastError();
+    TRACE ("RunFile: ShellExecuteExA/W returned error %#x\n", err);
 
     FreeLibrary(hShell32);
-    return ret ? sei.hProcess : NULL;
+
+    SetLastError(err);
+    return err ? NULL : sei.hProcess;
 }
 
 
@@ -431,6 +429,7 @@ Execute(LPTSTR Full, LPTSTR First, LPTSTR Rest, PARSED_COMMAND *Cmd)
         /* exec the program */
         PROCESS_INFORMATION prci;
         STARTUPINFO stui;
+        UINT execerror = ERROR_FILE_NOT_FOUND;
 
         /* build command line for CreateProcess(): FullName + " " + rest */
         BOOL quoted = !!_tcschr(First, _T(' '));
@@ -450,8 +449,8 @@ Execute(LPTSTR Full, LPTSTR First, LPTSTR Rest, PARSED_COMMAND *Cmd)
         memset(&stui, 0, sizeof(stui));
         stui.cb = sizeof(stui);
         stui.lpTitle = Full;
-        stui.dwFlags = STARTF_USESHOWWINDOW;
-        stui.wShowWindow = SW_SHOWDEFAULT;
+        stui.dwFlags = 0;
+        stui.wShowWindow = SW_SHOWNORMAL;
 
         /* Set the console to standard mode */
         SetConsoleMode(ConStreamGetOSHandle(StdIn),
@@ -470,14 +469,12 @@ Execute(LPTSTR Full, LPTSTR First, LPTSTR Rest, PARSED_COMMAND *Cmd)
         {
             CloseHandle(prci.hThread);
         }
-        else
+        else if (GetLastError() == ERROR_BAD_EXE_FORMAT)
         {
             // See if we can run this with ShellExecute() ie myfile.xls
-            prci.hProcess = RunFile(SEE_MASK_NOCLOSEPROCESS | SEE_MASK_NO_CONSOLE,
-                                    szFullName,
-                                    rest,
-                                    NULL,
-                                    SW_SHOWNORMAL);
+            HANDLE hProcess = RunFile(SEE_MASK_NOCLOSEPROCESS | SEE_MASK_NO_CONSOLE,
+                                      szFullName, rest, NULL, SW_SHOWNORMAL);
+            execerror = hProcess ? ERROR_SUCCESS : GetLastError();
         }
 
         *FirstEnd = _T('\0');
@@ -499,10 +496,13 @@ Execute(LPTSTR Full, LPTSTR First, LPTSTR Rest, PARSED_COMMAND *Cmd)
             }
             CloseHandle(prci.hProcess);
         }
-        else
+        else if (execerror)
         {
             TRACE ("[ShellExecute failed!: %s]\n", debugstr_aw(Full));
-            error_bad_command(first);
+            if (execerror == ERROR_NO_ASSOCIATION)
+                error_cant_exec_program();
+            else
+                error_bad_command(first);
             dwExitCode = 1;
         }
 

base/shell/cmd/cmd.h

@@ -216,6 +216,7 @@ VOID error_parameter_format(TCHAR ch);
 VOID error_invalid_switch(TCHAR ch);
 VOID error_invalid_parameter_format(PCTSTR s);
 VOID error_out_of_memory(VOID);
+VOID error_cant_exec_program(VOID);
 VOID error_syntax(PCTSTR s);
 
 VOID msg_pause(VOID);

base/shell/cmd/error.c

@@ -141,6 +141,13 @@ VOID error_out_of_memory(VOID)
     nErrorLevel = 1;
 }
 
+VOID error_cant_exec_program(VOID)
+{
+    /* TODO: Windows uses the custom string "The system cannot execute the specified program" here */
+    ErrorMessage(ERROR_NO_ASSOCIATION, NULL);
+    nErrorLevel = 1;
+}
+
 
 VOID error_invalid_parameter_format(PCWSTR s)
 {

boot/bootdata/hivecls.inf

@@ -5,8 +5,8 @@ Signature = "$Windows NT$"
 HKLM,"SOFTWARE\Classes",,0x00000010
 
 ; Default key
-HKCR,"*","",0x00000000,""
-HKCR,"SystemFileAssociations","",0x00000000,""
+HKCR,"*","AlwaysShowExt",0x00000000,""
+HKCR,"SystemFileAssociations",,0x00000010
 
 ; Open With List
 HKCR,"*\OpenWithList\excel.exe","",0x00000000,""
@@ -16,6 +16,12 @@ HKCR,"*\OpenWithList\notepad.exe","",0x00000000,""
 HKCR,"*\OpenWithList\winword.exe","",0x00000000,""
 HKCR,"*\OpenWithList\wordpad.exe","",0x00000000,""
 
+; Unknown
+HKCR,"Unknown","AlwaysShowExt"
+HKCR,"Unknown","QueryClassStore"
+HKCR,"Unknown\shell","",,"openas"
+HKCR,"Unknown\shell\openas\command","",0x00020000,"%SystemRoot%\system32\rundll32.exe %SystemRoot%\system32\shell32.dll,OpenAs_RunDLL %1"
+
 ; Folders
 HKCR,"Folder","",0x00000000,"Folder"
 ;HKCR,"Folder\DefaultIcon","",0x00000000,"%SystemRoot%\system32\shell32.dll,-4"

dll/win32/shell32/CDefaultContextMenu.cpp

@@ -58,10 +58,10 @@ static const struct _StaticInvokeCommandMap_
     SHORT DfmCmd;
 } g_StaticInvokeCmdMap[] =
 {
-    { "RunAs", 0 },  // Unimplemented
-    { "Print", 0 },  // Unimplemented
-    { "Preview", 0 }, // Unimplemented
-    { "Open",            FCIDM_SHVIEW_OPEN },
+    { "runas", 0 },  // Unimplemented
+    { "print", 0 },  // Unimplemented
+    { "preview", 0 }, // Unimplemented
+    { "open",            FCIDM_SHVIEW_OPEN },
     { CMDSTR_NEWFOLDERA, FCIDM_SHVIEW_NEWFOLDER,  (SHORT)DFM_CMD_NEWFOLDER },
     { "cut",             FCIDM_SHVIEW_CUT,        /* ? */ },
     { "copy",            FCIDM_SHVIEW_COPY,       (SHORT)DFM_CMD_COPY },
@@ -139,6 +139,36 @@ EXTERN_C HRESULT SHELL32_EnumDefaultVerbList(LPCWSTR List, UINT Index, LPWSTR Ve
     return HRESULT_FROM_WIN32(ERROR_NO_MORE_ITEMS);
 }
 
+static HRESULT GetFriendlyVerb(_In_ PCWSTR pszVerb, _Out_ PWSTR pszBuf, _In_ SIZE_T cchMax)
+{
+    static const struct { PCWSTR pszVerb; WORD iResId; } map[] =
+    {
+        // { L"open", IDS_OPEN_VERB }, These two have already been handled
+        // { L"explore", IDS_EXPLORE_VERB },
+        { L"edit", IDS_EDIT_VERB },
+        { L"print", IDS_PRINT_VERB },
+        { L"runas", IDS_RUNAS_VERB },
+        { L"openas", IDS_OPEN_VERB },
+        { L"find", IDS_FIND_VERB },
+    };
+    for (SIZE_T i = 0; i < _countof(map); ++i)
+    {
+        if (!_wcsicmp(pszVerb, map[i].pszVerb) &&
+            LoadStringW(shell32_hInstance, map[i].iResId, pszBuf, cchMax))
+        {
+            return S_OK;
+        }
+    }
+
+    // Try to make a friendly verb based on the verb subkey
+    if (pszVerb[0] < 127 && !StrChrW(pszVerb, '&') && SUCCEEDED(StringCchCopyW(pszBuf + 1, --cchMax, pszVerb)))
+    {
+        *pszBuf = L'&';
+        return S_OK; // This can be changed to S_FALSE if the caller needs to know we faked it
+    }
+    return E_FAIL;
+}
+
 class CDefaultContextMenu :
     public CComObjectRootEx<CComMultiThreadModelNoCS>,
     public IContextMenu3,
@@ -572,9 +602,8 @@ CDefaultContextMenu::AddStaticContextMenusToMenu(
 {
     UINT ntver = RosGetProcessEffectiveVersion();
     MENUITEMINFOW mii = { sizeof(mii) };
-    UINT idResource;
     WCHAR wszDispVerb[80]; // The limit on XP. If the friendly string is longer, it falls back to the verb key.
-    UINT fState;
+    UINT fState, idVerbRes;
     UINT cIds = 0, indexFirst = *pIndexMenu, indexDefault;
     int iDefVerbIndex = -1;
 
@@ -587,6 +616,7 @@ CDefaultContextMenu::AddStaticContextMenusToMenu(
     {
         StaticShellEntry& info = m_StaticEntries.GetNext(it);
         BOOL forceFirstPos = FALSE;
+        bool hide = false;
 
         fState = MFS_ENABLED;
 
@@ -599,86 +629,59 @@ CDefaultContextMenu::AddStaticContextMenusToMenu(
 
         if (info.Verb.CompareNoCase(L"open") == 0)
         {
-            idResource = IDS_OPEN_VERB;
+            idVerbRes = IDS_OPEN_VERB; // TODO: This string should include '&'
             fState |= MFS_DEFAULT; /* override default when open verb is found */
             forceFirstPos++;
         }
         else if (info.Verb.CompareNoCase(L"explore") == 0)
         {
-            idResource = IDS_EXPLORE_VERB;
+            idVerbRes = IDS_EXPLORE_VERB; // TODO: This string should include '&'
             if (uFlags & CMF_EXPLORE)
             {
                 fState |= MFS_DEFAULT;
                 forceFirstPos++;
             }
         }
-        else if (info.Verb.CompareNoCase(L"runas") == 0)
-            idResource = IDS_RUNAS_VERB;
-        else if (info.Verb.CompareNoCase(L"edit") == 0)
-            idResource = IDS_EDIT_VERB;
-        else if (info.Verb.CompareNoCase(L"find") == 0)
-            idResource = IDS_FIND_VERB;
-        else if (info.Verb.CompareNoCase(L"print") == 0)
-            idResource = IDS_PRINT_VERB;
         else if (info.Verb.CompareNoCase(L"printto") == 0)
-            continue;
+            hide = true;
         else
-            idResource = 0;
+            idVerbRes = 0;
 
         /* By default use verb for menu item name */
         mii.dwTypeData = (LPWSTR)info.Verb.GetString();
 
         WCHAR wszKey[sizeof("shell\\") + MAX_VERB];
-        HRESULT hr;
-        hr = StringCbPrintfW(wszKey, sizeof(wszKey), L"shell\\%s", info.Verb.GetString());
+        HRESULT hr = StringCbPrintfW(wszKey, sizeof(wszKey), L"shell\\%s", info.Verb.GetString());
         if (FAILED_UNEXPECTEDLY(hr))
-        {
-            continue;
-        }
+            hide = true;
 
         UINT cmdFlags = 0;
-        bool hide = false;
         HKEY hkVerb;
-        if (idResource > 0)
+        if (RegOpenKeyExW(info.hkClass, wszKey, 0, KEY_READ, &hkVerb) == ERROR_SUCCESS)
         {
             if (!(uFlags & CMF_OPTIMIZEFORINVOKE))
             {
-                if (LoadStringW(shell32_hInstance, idResource, wszDispVerb, _countof(wszDispVerb)))
-                    mii.dwTypeData = wszDispVerb; /* use translated verb */
-                else
-                    ERR("Failed to load string\n");
+                DWORD cbVerb = sizeof(wszDispVerb);
+                LONG res = RegLoadMUIStringW(hkVerb, L"MUIVerb", wszDispVerb, cbVerb, NULL, 0, NULL);
+                if (res || !*wszDispVerb)
+                    res = RegLoadMUIStringW(hkVerb, NULL, wszDispVerb, cbVerb, NULL, 0, NULL);
+
+                if ((res == ERROR_SUCCESS && *wszDispVerb) ||
+                    (idVerbRes && LoadStringW(shell32_hInstance, idVerbRes, wszDispVerb, _countof(wszDispVerb))) ||
+                    SUCCEEDED(GetFriendlyVerb(info.Verb, wszDispVerb, _countof(wszDispVerb))))
+                {
+                    mii.dwTypeData = wszDispVerb;
+                }
             }
-
-            if (RegOpenKeyW(info.hkClass, wszKey, &hkVerb) != ERROR_SUCCESS)
-                hkVerb = NULL;
         }
         else
         {
-            if (RegOpenKeyW(info.hkClass, wszKey, &hkVerb) == ERROR_SUCCESS)
-            {
-                if (!(uFlags & CMF_OPTIMIZEFORINVOKE))
-                {
-                    DWORD cbVerb = sizeof(wszDispVerb);
-                    LONG res = RegLoadMUIStringW(hkVerb, L"MUIVerb", wszDispVerb, cbVerb, NULL, 0, NULL);
-                    if (res || !*wszDispVerb)
-                        res = RegLoadMUIStringW(hkVerb, NULL, wszDispVerb, cbVerb, NULL, 0, NULL);
-
-                    if (res == ERROR_SUCCESS && *wszDispVerb)
-                    {
-                        /* use description for the menu entry */
-                        mii.dwTypeData = wszDispVerb;
-                    }
-                }
-            }
-            else
-            {
-                hkVerb = NULL;
-            }
+            hkVerb = NULL;
         }
 
         if (hkVerb)
         {
-            if (!(uFlags & CMF_EXTENDEDVERBS))
+            if (!hide && !(uFlags & CMF_EXTENDEDVERBS))
                 hide = RegValueExists(hkVerb, L"Extended");
 
             if (!hide)
@@ -687,6 +690,9 @@ CDefaultContextMenu::AddStaticContextMenusToMenu(
             if (!hide && !(uFlags & CMF_DISABLEDVERBS))
                 hide = RegValueExists(hkVerb, L"LegacyDisable");
 
+            if (DWORD dwRest = (hide ? 0 : RegGetDword(hkVerb, NULL, L"SuppressionPolicy", 0)))
+                hide = SHRestricted((RESTRICTIONS)dwRest);
+
             if (RegValueExists(hkVerb, L"NeverDefault"))
                 fState &= ~MFS_DEFAULT;
 
@@ -924,6 +930,11 @@ CDefaultContextMenu::QueryContextMenu(
 
     // TODO: DFM_MERGECONTEXTMENU_TOP
 
+    // TODO: Remove duplicate verbs. This will be easier when the static items handling
+    // has been moved to CLSID_ShellFileDefExt so we only have to deal with ShellEx.
+    // This is a Windows XP+ feature. On an unknown file type, Windows 2000 will
+    // display both "Open" (openas from Unknown) and "Open with..." (openas from *).
+
     return MAKE_HRESULT(SEVERITY_SUCCESS, 0, cIds);
 }
 
@@ -1278,8 +1289,6 @@ CDefaultContextMenu::BrowserFlagsFromVerb(LPCMINVOKECOMMANDINFOEX lpcmi, PStatic
     LPCWSTR FlagsName;
     WCHAR wszKey[sizeof("shell\\") + MAX_VERB];
     HRESULT hr;
-    DWORD wFlags;
-    DWORD cbVerb;
 
     if (!m_site)
         return 0;
@@ -1306,14 +1315,7 @@ CDefaultContextMenu::BrowserFlagsFromVerb(LPCMINVOKECOMMANDINFOEX lpcmi, PStatic
     hr = StringCbPrintfW(wszKey, sizeof(wszKey), L"shell\\%s", pEntry->Verb.GetString());
     if (FAILED_UNEXPECTEDLY(hr))
         return 0;
-
-    cbVerb = sizeof(wFlags);
-    if (RegGetValueW(pEntry->hkClass, wszKey, FlagsName, RRF_RT_REG_DWORD, NULL, &wFlags, &cbVerb) == ERROR_SUCCESS)
-    {
-        return wFlags;
-    }
-
-    return 0;
+    return RegGetDword(pEntry->hkClass, wszKey, FlagsName, 0);
 }
 
 HRESULT