Move ssl to attribute

Author: tetienne

pyoverkiz/clients/overkiz.py

@@ -73,6 +73,7 @@ class OverkizClient(ABC):
     setup: Setup | None = field(default=None, init=False)
     devices: list[Device] = field(factory=list, init=False)
     gateways: list[Gateway] = field(factory=list, init=False)
+    _ssl: bool = field(default=True, init=False)
 
     @abstractmethod
     async def _login(
@@ -99,12 +100,11 @@ def _headers(self) -> dict[str, str]:
     async def get(
         self,
         path: str,
-        ssl: bool = True,
     ) -> Any:
         """Make a GET request to the OverKiz API"""
 
         async with self.session.get(
-            f"{self.endpoint}{path}", headers=self._headers, ssl=ssl
+            f"{self.endpoint}{path}", headers=self._headers, ssl=self._ssl
         ) as response:
             await self.check_response(response)
             return await response.json()
@@ -114,7 +114,6 @@ async def post(
         path: str,
         payload: JSON | None = None,
         data: JSON | None = None,
-        ssl: bool = True,
     ) -> Any:
         """Make a POST request to the OverKiz API"""
 
@@ -123,20 +122,19 @@ async def post(
             data=data,
             json=payload,
             headers=self._headers,
-            ssl=ssl,
+            ssl=self._ssl,
         ) as response:
             await self.check_response(response)
             return await response.json()
 
     async def delete(
         self,
         path: str,
-        ssl: bool = True,
     ) -> None:
         """Make a DELETE request to the OverKiz API"""
 
         async with self.session.delete(
-            f"{self.endpoint}{path}", headers=self._headers, ssl=ssl
+            f"{self.endpoint}{path}", headers=self._headers, ssl=self._ssl
         ) as response:
             await self.check_response(response)
 

pyoverkiz/clients/somfy.py

@@ -24,7 +24,7 @@ class SomfyClient(OverkizClient):
     def _headers(self) -> dict[str, str]:
         return {"Authorization": f"Bearer {self._access_token}"}
 
-    async def get(self, path: str, ssl: bool = True) -> Any:
+    async def get(self, path: str) -> Any:
         """Make a GET request to the OverKiz API"""
 
         await self._refresh_token_if_expired()
@@ -35,14 +35,13 @@ async def post(
         path: str,
         payload: JSON | None = None,
         data: JSON | None = None,
-        ssl: bool = True,
     ) -> Any:
         """Make a POST request to the OverKiz API"""
         if path != "login":
             await self._refresh_token_if_expired()
         return await super().post(path, payload=payload, data=data)
 
-    async def delete(self, path: str, ssl: bool = True) -> None:
+    async def delete(self, path: str) -> None:
         """Make a DELETE request to the OverKiz API"""
         await self._refresh_token_if_expired()
         return await super().delete(path)

pyoverkiz/clients/somfy_local.py

@@ -1,43 +1,18 @@
 from __future__ import annotations
 
-from typing import Any
+from attr import field
 
 from pyoverkiz.clients.overkiz import OverkizClient
-from pyoverkiz.types import JSON
 
 
 class SomfyLocalClient(OverkizClient):
-    async def _login(self, username: str, password: str) -> bool:
+
+    _ssl: bool = field(default=False, init=False)
+
+    async def _login(self, _username: str, _password: str) -> bool:
         """There is no login for Somfy Local"""
         return True
 
     @property
     def _headers(self) -> dict[str, str]:
         return {"Authorization": f"Bearer {self.password}"}
-
-    async def get(
-        self,
-        path: str,
-        _ssl: bool = False,
-    ) -> Any:
-        """Make a GET request to the OverKiz API"""
-
-        return await super().get(path, ssl=False)
-
-    async def post(
-        self,
-        path: str,
-        payload: JSON | None = None,
-        data: JSON | None = None,
-        _ssl: bool = False,
-    ) -> Any:
-        """Make a POST request to the OverKiz API"""
-        return await super().post(path, payload=payload, data=data, ssl=False)
-
-    async def delete(
-        self,
-        path: str,
-        _ssl: bool = False,
-    ) -> None:
-        """Make a DELETE request to the OverKiz API"""
-        return await super().delete(path, ssl=False)