refactor(obfuscate): improve type consistency and simplify branch logic

Author: tetienne

pyoverkiz/obfuscate.py

@@ -19,21 +19,20 @@ def obfuscate_email(email: str | None) -> str:
     return re.sub(r"(.).*@.*(.\..*)", r"\1****@****\2", email)
 
 
-def obfuscate_string(input: str) -> str:
+def obfuscate_string(input: str | None) -> str:
     """Mask string."""
     return re.sub(r"[a-zA-Z0-9_.-]*", "*", str(input))
 
 
-# pylint: disable=too-many-branches
 def obfuscate_sensitive_data(data: dict[str, Any]) -> JSON:
     """Mask Overkiz JSON data to remove sensitive data."""
     mask_next_value = False
 
     for key, value in data.items():
-        if key in ["gatewayId", "id", "deviceURL"]:
+        if key in {"gatewayId", "id", "deviceURL"}:
             data[key] = obfuscate_id(value)
 
-        if key in [
+        if key in {
             "label",
             "city",
             "country",
@@ -42,7 +41,7 @@ def obfuscate_sensitive_data(data: dict[str, Any]) -> JSON:
             "addressLine2",
             "longitude",
             "latitude",
-        ]:
+        }:
             data[key] = obfuscate_string(value)
 
         if value in [
@@ -62,17 +61,7 @@ def obfuscate_sensitive_data(data: dict[str, Any]) -> JSON:
             obfuscate_sensitive_data(value)
         elif isinstance(value, list):
             for val in value:
-                if isinstance(val, str):
-                    continue
-                if isinstance(val, int):
-                    continue
-                if isinstance(val, float):
-                    continue
-                if isinstance(val, list):
-                    continue
-                if val is None:
-                    continue
-
-                obfuscate_sensitive_data(val)
+                if isinstance(val, dict):
+                    obfuscate_sensitive_data(val)
 
     return data