Skip to content

Commit 4a6e4db

Browse files
committed
improve focus visuals
toggle switch command bar
1 parent 343c668 commit 4a6e4db

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

source/iNKORE.UI.WPF.Modern.Controls/Controls/Windows/CommandBar/CommandBar.xaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
-->
4949
<ContentControl
5050
x:Name="ContentControl"
51+
Margin="{TemplateBinding Padding}"
5152
HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}"
5253
VerticalAlignment="{TemplateBinding VerticalContentAlignment}"
5354
HorizontalContentAlignment="{TemplateBinding HorizontalContentAlignment}"
@@ -76,14 +77,15 @@
7677
IsChecked="{Binding Path=IsOverflowOpen, Mode=TwoWay, RelativeSource={RelativeSource TemplatedParent}}"
7778
IsEnabled="{TemplateBinding HasOverflowItems}"
7879
Style="{DynamicResource EllipsisButton}"
80+
ui:FocusVisualHelper.IsTemplateFocusTarget="True"
7981
Visibility="{TemplateBinding EffectiveOverflowButtonVisibility}">
8082
<ui:FontIcon
8183
x:Name="EllipsisIcon"
8284
Height="{DynamicResource AppBarExpandButtonCircleDiameter}"
8385
VerticalAlignment="Center"
84-
FontFamily="{DynamicResource FluentSystemIcons}"
86+
FontFamily="{DynamicResource SymbolThemeFontFamily}"
8587
FontSize="20"
86-
Glyph="&#xE826;" />
88+
Glyph="&#xE712;" />
8789
</ToggleButton>
8890
<Rectangle
8991
x:Name="HighContrastBorder"
@@ -129,6 +131,7 @@
129131
</primitives:CommandBarOverflowPresenter.Resources>
130132
<primitives:CommandBarOverflowPanel
131133
x:Name="PART_ToolBarOverflowPanel"
134+
Margin="{DynamicResource CommandBarOverflowPresenterMargin}"
132135
FocusVisualStyle="{x:Null}"
133136
Focusable="true"
134137
KeyboardNavigation.DirectionalNavigation="Cycle"
@@ -210,7 +213,6 @@
210213
SnapsToDevicePixels="True">
211214
<Border Padding="{TemplateBinding Padding}" CornerRadius="{TemplateBinding CornerRadius}">
212215
<ui:ScrollViewerEx
213-
Padding="{DynamicResource CommandBarOverflowPresenterMargin}"
214216
Content="{TemplateBinding Content}"
215217
HorizontalScrollBarVisibility="{TemplateBinding ScrollViewer.HorizontalScrollBarVisibility}"
216218
SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}"

source/iNKORE.UI.WPF.Modern.Controls/Controls/Windows/ToggleSwitch/ToggleSwitch.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@
124124
Visibility="Collapsed" />
125125
<Grid
126126
Grid.Row="1"
127+
ui:FocusVisualHelper.IsTemplateFocusTarget="True"
127128
HorizontalAlignment="Left"
128129
VerticalAlignment="Top">
129130

@@ -145,7 +146,6 @@
145146
Grid.RowSpan="3"
146147
Grid.ColumnSpan="5"
147148
Margin="0,5"
148-
ui:FocusVisualHelper.IsTemplateFocusTarget="True"
149149
Background="{DynamicResource ToggleSwitchContainerBackground}"
150150
CornerRadius="{TemplateBinding CornerRadius}" />
151151
<ui:ContentPresenterEx

source/iNKORE.UI.WPF.Modern/Controls/Helpers/FocusVisualHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ public FocusVisualAdorner(Control focusedElement, UIElement adornedElement, Styl
539539
TransferValue(focusedElement, control, FocusVisualSecondaryBrushProperty);
540540
TransferValue(focusedElement, control, FocusVisualSecondaryThicknessProperty);
541541
_adorderChild = control;
542-
IsClipEnabled = true;
542+
IsClipEnabled = false;
543543
IsHitTestVisible = false;
544544
IsEnabled = false;
545545
AddVisualChild(_adorderChild);

0 commit comments

Comments
 (0)