Skip to content

Commit 17e7ce6

Browse files
committed
Fix broken flight axis override tests
The test_flight_axis_override.js file had multiple bugs preventing tests from running correctly: **Fix #1: Missing Decompiler import** - Added `import { Decompiler } from '../decompiler.js';` - Changed `transpiler.decompile()` to proper `new Decompiler()` usage - Error was: "transpiler.decompile is not a function" **Fix #2: Invalid property name in Test 4** - Fixed `flight.armed` → `flight.isArmed` - Error was: "Unknown property 'armed' in 'flight.armed'" - The correct property is `isArmed` per the flight API **Fix #3: Error message handling** - Fixed `result.errors` → `result.error || result.errors` - Fixed `decompiled.errors` → `decompiled.error || decompiled.errors` - Handles both singular and plural error field names **Test Results:** Before: 3 decompile errors, 1 compilation failure After: All 4 tests pass ✅ - Test 1: Roll angle override ✅ - Test 2: Pitch rate override ✅ - Test 3: Yaw angle override ✅ - Test 4: Multiple axis overrides ✅
1 parent 61c8ab1 commit 17e7ce6

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

js/transpiler/transpiler/tests/test_flight_axis_override.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66

77
import { Transpiler } from '../index.js';
8+
import { Decompiler } from '../decompiler.js';
89

910
function testFlightAxisOverride() {
1011
console.log('Testing Flight Axis Override...\n');
@@ -45,7 +46,7 @@ if (flight.heading < 180) {
4546
code: `
4647
const { flight, override } = inav;
4748
48-
if (flight.armed) {
49+
if (flight.isArmed) {
4950
override.flightAxis.roll.angle = 30;
5051
override.flightAxis.pitch.angle = -15;
5152
override.flightAxis.yaw.rate = 50;
@@ -77,16 +78,17 @@ if (flight.armed) {
7778
});
7879

7980
// Test decompilation
80-
const decompiled = transpiler.decompile(logicConditions);
81+
const decompiler = new Decompiler();
82+
const decompiled = decompiler.decompile(logicConditions);
8183
if (decompiled.success) {
8284
console.log('✓ Decompilation successful');
8385
console.log('Decompiled code:');
8486
console.log(decompiled.code);
8587
} else {
86-
console.log('✗ Decompilation failed:', decompiled.errors);
88+
console.log('✗ Decompilation failed:', decompiled.error || decompiled.errors);
8789
}
8890
} else {
89-
console.log('✗ Compilation failed:', result.errors);
91+
console.log('✗ Compilation failed:', result.error || result.errors);
9092
}
9193
} catch (error) {
9294
console.log('✗ Error:', error.message);

0 commit comments

Comments
 (0)