Skip to content

Commit eb6a9f6

Browse files
sensei-hackersensei-hacker
committed
Fix power limit UI and add i18n for all languages
Three fixes: 1. Fixed data-setting attribute (bug fix) - Changed data-setting-placeholder to data-setting on all 8 fields - Settings.saveInputs() only processes data-setting attributes - This was preventing values from being saved 2. Fixed duplicate labels (UX improvement) - "Burst Time" → "Burst Current Time" / "Burst Power Time" - "Burst Falldown Time" → "Burst Current Falldown Time" / "Burst Power Falldown Time" - Eliminates confusion between current and power timing fields 3. Added i18n strings to all languages - Added 14 power limit strings to: ja, ru, uk, zh_CN - Using English text as placeholders for proper translations later - Prevents missing translation key errors in non-English locales
1 parent 227030f commit eb6a9f6

File tree

6 files changed

+240
-12
lines changed

6 files changed

+240
-12
lines changed

‎locale/en/messages.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1099,13 +1099,13 @@
10991099
"message": "Higher current allowed for short bursts (punch-outs, climbs). Example: 750 = 75A. Should be >= continuous limit."
11001100
},
11011101
"configurationLimitBurstCurrentTime": {
1102-
"message": "Burst Time (ds)"
1102+
"message": "Burst Current Time (ds)"
11031103
},
11041104
"configurationLimitBurstCurrentTimeHelp": {
11051105
"message": "Duration burst current is allowed in deci-seconds (ds). Example: 100 = 10 seconds. After this time, limit falls to continuous."
11061106
},
11071107
"configurationLimitBurstCurrentFalldownTime": {
1108-
"message": "Burst Falldown Time (ds)"
1108+
"message": "Burst Current Falldown Time (ds)"
11091109
},
11101110
"configurationLimitBurstCurrentFalldownTimeHelp": {
11111111
"message": "Smooth ramp-down time from burst to continuous limit in deci-seconds (ds). Example: 20 = 2 seconds."
@@ -1123,13 +1123,13 @@
11231123
"message": "Higher power allowed for short bursts. Example: 10000 = 1000W. Should be >= continuous limit."
11241124
},
11251125
"configurationLimitBurstPowerTime": {
1126-
"message": "Burst Time (ds)"
1126+
"message": "Burst Power Time (ds)"
11271127
},
11281128
"configurationLimitBurstPowerTimeHelp": {
11291129
"message": "Duration burst power is allowed in deci-seconds (ds). Example: 50 = 5 seconds."
11301130
},
11311131
"configurationLimitBurstPowerFalldownTime": {
1132-
"message": "Burst Falldown Time (ds)"
1132+
"message": "Burst Power Falldown Time (ds)"
11331133
},
11341134
"configurationLimitBurstPowerFalldownTimeHelp": {
11351135
"message": "Smooth ramp-down time from burst to continuous power limit in deci-seconds (ds). Example: 10 = 1 second."

‎locale/ja/messages.json‎

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1172,6 +1172,63 @@
11721172
"configurationSystem": {
11731173
"message": "システム設定"
11741174
},
1175+
"configurationPowerLimits": {
1176+
"message": "Power Limiting"
1177+
},
1178+
"configurationPowerLimitsHelp": {
1179+
"message": "Limit battery current and power draw to protect your battery and ESCs. Set to 0 to disable. Units: dA (deci-amps) = A×10, dW (deci-watts) = W×10, ds (deci-seconds) = s×10."
1180+
},
1181+
"configurationPowerLimitsNote": {
1182+
"message": "Protects battery from over-current by smoothly reducing throttle. Requires current sensor. Set continuous and burst limits per your battery specs."
1183+
},
1184+
"configurationLimitContCurrent": {
1185+
"message": "Continuous Current Limit (dA)"
1186+
},
1187+
"configurationLimitContCurrentHelp": {
1188+
"message": "Maximum sustained current draw in deci-amps (dA). Example: 500 = 50A. Set to 0 to disable current limiting."
1189+
},
1190+
"configurationLimitBurstCurrent": {
1191+
"message": "Burst Current Limit (dA)"
1192+
},
1193+
"configurationLimitBurstCurrentHelp": {
1194+
"message": "Higher current allowed for short bursts (punch-outs, climbs). Example: 750 = 75A. Should be >= continuous limit."
1195+
},
1196+
"configurationLimitBurstCurrentTime": {
1197+
"message": "Burst Current Time (ds)"
1198+
},
1199+
"configurationLimitBurstCurrentTimeHelp": {
1200+
"message": "Duration burst current is allowed in deci-seconds (ds). Example: 100 = 10 seconds. After this time, limit falls to continuous."
1201+
},
1202+
"configurationLimitBurstCurrentFalldownTime": {
1203+
"message": "Burst Current Falldown Time (ds)"
1204+
},
1205+
"configurationLimitBurstCurrentFalldownTimeHelp": {
1206+
"message": "Smooth ramp-down time from burst to continuous limit in deci-seconds (ds). Example: 20 = 2 seconds."
1207+
},
1208+
"configurationLimitContPower": {
1209+
"message": "Continuous Power Limit (dW)"
1210+
},
1211+
"configurationLimitContPowerHelp": {
1212+
"message": "Maximum sustained power draw in deci-watts (dW). Example: 8000 = 800W. Set to 0 to disable power limiting. Requires voltage measurement."
1213+
},
1214+
"configurationLimitBurstPower": {
1215+
"message": "Burst Power Limit (dW)"
1216+
},
1217+
"configurationLimitBurstPowerHelp": {
1218+
"message": "Higher power allowed for short bursts. Example: 10000 = 1000W. Should be >= continuous limit."
1219+
},
1220+
"configurationLimitBurstPowerTime": {
1221+
"message": "Burst Power Time (ds)"
1222+
},
1223+
"configurationLimitBurstPowerTimeHelp": {
1224+
"message": "Duration burst power is allowed in deci-seconds (ds). Example: 50 = 5 seconds."
1225+
},
1226+
"configurationLimitBurstPowerFalldownTime": {
1227+
"message": "Burst Power Falldown Time (ds)"
1228+
},
1229+
"configurationLimitBurstPowerFalldownTimeHelp": {
1230+
"message": "Smooth ramp-down time from burst to continuous power limit in deci-seconds (ds). Example: 10 = 1 second."
1231+
},
11751232
"configurationLoopTime": {
11761233
"message": "フライトコントローラ ループ時間"
11771234
},

‎locale/ru/messages.json‎

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4752,6 +4752,63 @@
47524752
"pidP": {
47534753
"message": "P-коэффициент"
47544754
},
4755+
"configurationPowerLimits": {
4756+
"message": "Power Limiting"
4757+
},
4758+
"configurationPowerLimitsHelp": {
4759+
"message": "Limit battery current and power draw to protect your battery and ESCs. Set to 0 to disable. Units: dA (deci-amps) = A×10, dW (deci-watts) = W×10, ds (deci-seconds) = s×10."
4760+
},
4761+
"configurationPowerLimitsNote": {
4762+
"message": "Protects battery from over-current by smoothly reducing throttle. Requires current sensor. Set continuous and burst limits per your battery specs."
4763+
},
4764+
"configurationLimitContCurrent": {
4765+
"message": "Continuous Current Limit (dA)"
4766+
},
4767+
"configurationLimitContCurrentHelp": {
4768+
"message": "Maximum sustained current draw in deci-amps (dA). Example: 500 = 50A. Set to 0 to disable current limiting."
4769+
},
4770+
"configurationLimitBurstCurrent": {
4771+
"message": "Burst Current Limit (dA)"
4772+
},
4773+
"configurationLimitBurstCurrentHelp": {
4774+
"message": "Higher current allowed for short bursts (punch-outs, climbs). Example: 750 = 75A. Should be >= continuous limit."
4775+
},
4776+
"configurationLimitBurstCurrentTime": {
4777+
"message": "Burst Current Time (ds)"
4778+
},
4779+
"configurationLimitBurstCurrentTimeHelp": {
4780+
"message": "Duration burst current is allowed in deci-seconds (ds). Example: 100 = 10 seconds. After this time, limit falls to continuous."
4781+
},
4782+
"configurationLimitBurstCurrentFalldownTime": {
4783+
"message": "Burst Current Falldown Time (ds)"
4784+
},
4785+
"configurationLimitBurstCurrentFalldownTimeHelp": {
4786+
"message": "Smooth ramp-down time from burst to continuous limit in deci-seconds (ds). Example: 20 = 2 seconds."
4787+
},
4788+
"configurationLimitContPower": {
4789+
"message": "Continuous Power Limit (dW)"
4790+
},
4791+
"configurationLimitContPowerHelp": {
4792+
"message": "Maximum sustained power draw in deci-watts (dW). Example: 8000 = 800W. Set to 0 to disable power limiting. Requires voltage measurement."
4793+
},
4794+
"configurationLimitBurstPower": {
4795+
"message": "Burst Power Limit (dW)"
4796+
},
4797+
"configurationLimitBurstPowerHelp": {
4798+
"message": "Higher power allowed for short bursts. Example: 10000 = 1000W. Should be >= continuous limit."
4799+
},
4800+
"configurationLimitBurstPowerTime": {
4801+
"message": "Burst Power Time (ds)"
4802+
},
4803+
"configurationLimitBurstPowerTimeHelp": {
4804+
"message": "Duration burst power is allowed in deci-seconds (ds). Example: 50 = 5 seconds."
4805+
},
4806+
"configurationLimitBurstPowerFalldownTime": {
4807+
"message": "Burst Power Falldown Time (ds)"
4808+
},
4809+
"configurationLimitBurstPowerFalldownTimeHelp": {
4810+
"message": "Smooth ramp-down time from burst to continuous power limit in deci-seconds (ds). Example: 10 = 1 second."
4811+
},
47554812
"configurationLoopTime": {
47564813
"message": "Время цикла полётного контроллера"
47574814
},

‎locale/uk/messages.json‎

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1172,6 +1172,63 @@
11721172
"configurationSystem": {
11731173
"message": "Конфігурація системи"
11741174
},
1175+
"configurationPowerLimits": {
1176+
"message": "Power Limiting"
1177+
},
1178+
"configurationPowerLimitsHelp": {
1179+
"message": "Limit battery current and power draw to protect your battery and ESCs. Set to 0 to disable. Units: dA (deci-amps) = A×10, dW (deci-watts) = W×10, ds (deci-seconds) = s×10."
1180+
},
1181+
"configurationPowerLimitsNote": {
1182+
"message": "Protects battery from over-current by smoothly reducing throttle. Requires current sensor. Set continuous and burst limits per your battery specs."
1183+
},
1184+
"configurationLimitContCurrent": {
1185+
"message": "Continuous Current Limit (dA)"
1186+
},
1187+
"configurationLimitContCurrentHelp": {
1188+
"message": "Maximum sustained current draw in deci-amps (dA). Example: 500 = 50A. Set to 0 to disable current limiting."
1189+
},
1190+
"configurationLimitBurstCurrent": {
1191+
"message": "Burst Current Limit (dA)"
1192+
},
1193+
"configurationLimitBurstCurrentHelp": {
1194+
"message": "Higher current allowed for short bursts (punch-outs, climbs). Example: 750 = 75A. Should be >= continuous limit."
1195+
},
1196+
"configurationLimitBurstCurrentTime": {
1197+
"message": "Burst Current Time (ds)"
1198+
},
1199+
"configurationLimitBurstCurrentTimeHelp": {
1200+
"message": "Duration burst current is allowed in deci-seconds (ds). Example: 100 = 10 seconds. After this time, limit falls to continuous."
1201+
},
1202+
"configurationLimitBurstCurrentFalldownTime": {
1203+
"message": "Burst Current Falldown Time (ds)"
1204+
},
1205+
"configurationLimitBurstCurrentFalldownTimeHelp": {
1206+
"message": "Smooth ramp-down time from burst to continuous limit in deci-seconds (ds). Example: 20 = 2 seconds."
1207+
},
1208+
"configurationLimitContPower": {
1209+
"message": "Continuous Power Limit (dW)"
1210+
},
1211+
"configurationLimitContPowerHelp": {
1212+
"message": "Maximum sustained power draw in deci-watts (dW). Example: 8000 = 800W. Set to 0 to disable power limiting. Requires voltage measurement."
1213+
},
1214+
"configurationLimitBurstPower": {
1215+
"message": "Burst Power Limit (dW)"
1216+
},
1217+
"configurationLimitBurstPowerHelp": {
1218+
"message": "Higher power allowed for short bursts. Example: 10000 = 1000W. Should be >= continuous limit."
1219+
},
1220+
"configurationLimitBurstPowerTime": {
1221+
"message": "Burst Power Time (ds)"
1222+
},
1223+
"configurationLimitBurstPowerTimeHelp": {
1224+
"message": "Duration burst power is allowed in deci-seconds (ds). Example: 50 = 5 seconds."
1225+
},
1226+
"configurationLimitBurstPowerFalldownTime": {
1227+
"message": "Burst Power Falldown Time (ds)"
1228+
},
1229+
"configurationLimitBurstPowerFalldownTimeHelp": {
1230+
"message": "Smooth ramp-down time from burst to continuous power limit in deci-seconds (ds). Example: 10 = 1 second."
1231+
},
11751232
"configurationLoopTime": {
11761233
"message": "Час циклу польотного контролера"
11771234
},

‎locale/zh_CN/messages.json‎

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1175,6 +1175,63 @@
11751175
"configurationSystem": {
11761176
"message": "系统设置"
11771177
},
1178+
"configurationPowerLimits": {
1179+
"message": "Power Limiting"
1180+
},
1181+
"configurationPowerLimitsHelp": {
1182+
"message": "Limit battery current and power draw to protect your battery and ESCs. Set to 0 to disable. Units: dA (deci-amps) = A×10, dW (deci-watts) = W×10, ds (deci-seconds) = s×10."
1183+
},
1184+
"configurationPowerLimitsNote": {
1185+
"message": "Protects battery from over-current by smoothly reducing throttle. Requires current sensor. Set continuous and burst limits per your battery specs."
1186+
},
1187+
"configurationLimitContCurrent": {
1188+
"message": "Continuous Current Limit (dA)"
1189+
},
1190+
"configurationLimitContCurrentHelp": {
1191+
"message": "Maximum sustained current draw in deci-amps (dA). Example: 500 = 50A. Set to 0 to disable current limiting."
1192+
},
1193+
"configurationLimitBurstCurrent": {
1194+
"message": "Burst Current Limit (dA)"
1195+
},
1196+
"configurationLimitBurstCurrentHelp": {
1197+
"message": "Higher current allowed for short bursts (punch-outs, climbs). Example: 750 = 75A. Should be >= continuous limit."
1198+
},
1199+
"configurationLimitBurstCurrentTime": {
1200+
"message": "Burst Current Time (ds)"
1201+
},
1202+
"configurationLimitBurstCurrentTimeHelp": {
1203+
"message": "Duration burst current is allowed in deci-seconds (ds). Example: 100 = 10 seconds. After this time, limit falls to continuous."
1204+
},
1205+
"configurationLimitBurstCurrentFalldownTime": {
1206+
"message": "Burst Current Falldown Time (ds)"
1207+
},
1208+
"configurationLimitBurstCurrentFalldownTimeHelp": {
1209+
"message": "Smooth ramp-down time from burst to continuous limit in deci-seconds (ds). Example: 20 = 2 seconds."
1210+
},
1211+
"configurationLimitContPower": {
1212+
"message": "Continuous Power Limit (dW)"
1213+
},
1214+
"configurationLimitContPowerHelp": {
1215+
"message": "Maximum sustained power draw in deci-watts (dW). Example: 8000 = 800W. Set to 0 to disable power limiting. Requires voltage measurement."
1216+
},
1217+
"configurationLimitBurstPower": {
1218+
"message": "Burst Power Limit (dW)"
1219+
},
1220+
"configurationLimitBurstPowerHelp": {
1221+
"message": "Higher power allowed for short bursts. Example: 10000 = 1000W. Should be >= continuous limit."
1222+
},
1223+
"configurationLimitBurstPowerTime": {
1224+
"message": "Burst Power Time (ds)"
1225+
},
1226+
"configurationLimitBurstPowerTimeHelp": {
1227+
"message": "Duration burst power is allowed in deci-seconds (ds). Example: 50 = 5 seconds."
1228+
},
1229+
"configurationLimitBurstPowerFalldownTime": {
1230+
"message": "Burst Power Falldown Time (ds)"
1231+
},
1232+
"configurationLimitBurstPowerFalldownTimeHelp": {
1233+
"message": "Smooth ramp-down time from burst to continuous power limit in deci-seconds (ds). Example: 10 = 1 second."
1234+
},
11781235
"configurationLoopTime": {
11791236
"message": "飞控循环时间"
11801237
},

‎tabs/configuration.html‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -211,28 +211,28 @@
211211

212212
<!-- Current Limits -->
213213
<div class="number">
214-
<input type="number" class="batteryProfileHighlight" id="limit_cont_current" name="limit_cont_current" step="1" min="0" max="2000" data-setting-placeholder="limit_cont_current" />
214+
<input type="number" class="batteryProfileHighlight" id="limit_cont_current" name="limit_cont_current" step="1" min="0" max="2000" data-setting="limit_cont_current" />
215215
<label for="limit_cont_current">
216216
<span data-i18n="configurationLimitContCurrent"></span>
217217
</label>
218218
<div for="limit_cont_current" class="helpicon cf_tip" data-i18n_title="configurationLimitContCurrentHelp"></div>
219219
</div>
220220
<div class="number">
221-
<input type="number" class="batteryProfileHighlight" id="limit_burst_current" name="limit_burst_current" step="1" min="0" max="2000" data-setting-placeholder="limit_burst_current" />
221+
<input type="number" class="batteryProfileHighlight" id="limit_burst_current" name="limit_burst_current" step="1" min="0" max="2000" data-setting="limit_burst_current" />
222222
<label for="limit_burst_current">
223223
<span data-i18n="configurationLimitBurstCurrent"></span>
224224
</label>
225225
<div for="limit_burst_current" class="helpicon cf_tip" data-i18n_title="configurationLimitBurstCurrentHelp"></div>
226226
</div>
227227
<div class="number">
228-
<input type="number" class="batteryProfileHighlight" id="limit_burst_current_time" name="limit_burst_current_time" step="1" min="0" max="600" data-setting-placeholder="limit_burst_current_time" />
228+
<input type="number" class="batteryProfileHighlight" id="limit_burst_current_time" name="limit_burst_current_time" step="1" min="0" max="600" data-setting="limit_burst_current_time" />
229229
<label for="limit_burst_current_time">
230230
<span data-i18n="configurationLimitBurstCurrentTime"></span>
231231
</label>
232232
<div for="limit_burst_current_time" class="helpicon cf_tip" data-i18n_title="configurationLimitBurstCurrentTimeHelp"></div>
233233
</div>
234234
<div class="number">
235-
<input type="number" class="batteryProfileHighlight" id="limit_burst_current_falldown_time" name="limit_burst_current_falldown_time" step="1" min="0" max="600" data-setting-placeholder="limit_burst_current_falldown_time" />
235+
<input type="number" class="batteryProfileHighlight" id="limit_burst_current_falldown_time" name="limit_burst_current_falldown_time" step="1" min="0" max="600" data-setting="limit_burst_current_falldown_time" />
236236
<label for="limit_burst_current_falldown_time">
237237
<span data-i18n="configurationLimitBurstCurrentFalldownTime"></span>
238238
</label>
@@ -241,28 +241,28 @@
241241

242242
<!-- Power Limits -->
243243
<div class="number">
244-
<input type="number" class="batteryProfileHighlight" id="limit_cont_power" name="limit_cont_power" step="1" min="0" max="20000" data-setting-placeholder="limit_cont_power" />
244+
<input type="number" class="batteryProfileHighlight" id="limit_cont_power" name="limit_cont_power" step="1" min="0" max="20000" data-setting="limit_cont_power" />
245245
<label for="limit_cont_power">
246246
<span data-i18n="configurationLimitContPower"></span>
247247
</label>
248248
<div for="limit_cont_power" class="helpicon cf_tip" data-i18n_title="configurationLimitContPowerHelp"></div>
249249
</div>
250250
<div class="number">
251-
<input type="number" class="batteryProfileHighlight" id="limit_burst_power" name="limit_burst_power" step="1" min="0" max="20000" data-setting-placeholder="limit_burst_power" />
251+
<input type="number" class="batteryProfileHighlight" id="limit_burst_power" name="limit_burst_power" step="1" min="0" max="20000" data-setting="limit_burst_power" />
252252
<label for="limit_burst_power">
253253
<span data-i18n="configurationLimitBurstPower"></span>
254254
</label>
255255
<div for="limit_burst_power" class="helpicon cf_tip" data-i18n_title="configurationLimitBurstPowerHelp"></div>
256256
</div>
257257
<div class="number">
258-
<input type="number" class="batteryProfileHighlight" id="limit_burst_power_time" name="limit_burst_power_time" step="1" min="0" max="600" data-setting-placeholder="limit_burst_power_time" />
258+
<input type="number" class="batteryProfileHighlight" id="limit_burst_power_time" name="limit_burst_power_time" step="1" min="0" max="600" data-setting="limit_burst_power_time" />
259259
<label for="limit_burst_power_time">
260260
<span data-i18n="configurationLimitBurstPowerTime"></span>
261261
</label>
262262
<div for="limit_burst_power_time" class="helpicon cf_tip" data-i18n_title="configurationLimitBurstPowerTimeHelp"></div>
263263
</div>
264264
<div class="number">
265-
<input type="number" class="batteryProfileHighlight" id="limit_burst_power_falldown_time" name="limit_burst_power_falldown_time" step="1" min="0" max="600" data-setting-placeholder="limit_burst_power_falldown_time" />
265+
<input type="number" class="batteryProfileHighlight" id="limit_burst_power_falldown_time" name="limit_burst_power_falldown_time" step="1" min="0" max="600" data-setting="limit_burst_power_falldown_time" />
266266
<label for="limit_burst_power_falldown_time">
267267
<span data-i18n="configurationLimitBurstPowerFalldownTime"></span>
268268
</label>

0 commit comments

Comments
 (0)