Merge pull request #12 from iPromKnight/refactor/rclone_bin_name

refactor: env var for overriding rclone bin name

Author: iPromKnight

src/internal/constants/constants.go

@@ -2,7 +2,6 @@ package constants
 
 // Constants for rclone
 const (
-	Rclone     = "rclone"
 	Serve      = "serve"
 	Mount      = "mount"
 	MountPoint = "mountPoint="
@@ -28,8 +27,12 @@ const (
 
 // Constants data files
 const (
-	YAMLPathEnvVar    = "RCLONE_MANAGER_CONFIG_YAML"
-	DefaultYAMLPath   = "/data/config.yaml"
+	YAMLPathEnvVar  = "RCLONE_MANAGER_CONFIG_YAML"
+	DefaultYAMLPath = "/data/config.yaml"
+
 	RcloneConfEnvVar  = "RCLONE_MANAGER_RCLONE_CONF"
 	DefaultRcloneConf = "/data/rclone.conf"
+
+	RcloneBinaryNameEnvVar  = "RCLONE_MANAGER_RCLONE_BIN_NAME"
+	DefaultRcloneBinaryName = "rclone"
 )

src/internal/mount_manager/helpers.go

@@ -13,9 +13,9 @@ import (
 
 func createMountCommand(instance *MountProcess) *exec.Cmd {
 	backendArg := fmt.Sprintf("%s:", instance.BackendName)
+	rcloneBin := environment.GetEnvWithFallback(constants.RcloneBinaryNameEnvVar, constants.DefaultRcloneBinaryName)
 
-	cmd := exec.Command(
-		constants.Rclone, constants.Mount, backendArg, instance.MountPoint)
+	cmd := exec.Command(rcloneBin, constants.Mount, backendArg, instance.MountPoint)
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr
 

src/internal/serve_manager/helpers.go

@@ -13,9 +13,8 @@ import (
 
 func createServeCommand(instance *ServeProcess) *exec.Cmd {
 	backendArg := fmt.Sprintf("%s:", instance.BackendName)
-
-	cmd := exec.Command(
-		constants.Rclone, constants.Serve, instance.Protocol, backendArg, constants.Addr, instance.Addr)
+	rcloneBin := environment.GetEnvWithFallback(constants.RcloneBinaryNameEnvVar, constants.DefaultRcloneBinaryName)
+	cmd := exec.Command(rcloneBin, constants.Serve, instance.Protocol, backendArg, constants.Addr, instance.Addr)
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr