Skip to content

Set up semantic versioning v1.0.0 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamfarhad merged 1 commit into from
Sep 10, 2025
Merged

Set up semantic versioning v1.0.0 #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"name": "iamfarhad/laravel-prometheus",
"version": "1.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Hardcoding the version field in composer.json is not recommended for libraries that are published on Packagist. Packagist automatically determines the package version from your Git tags. Including the version here can lead to inconsistencies if a new release is tagged without updating this file, or vice-versa. The recommended practice is to omit this field and manage versions solely through Git tags.

To fix this, please remove this line. You will also need to remove the trailing comma from the "name" line above to ensure the JSON remains valid.

"description": "Production-ready Laravel Prometheus metrics package with built-in collectors for HTTP, database, cache, queue, events, errors, filesystem, and mail monitoring",
"type": "library",
"license": "MIT",
Expand Down Expand Up @@ -93,7 +94,7 @@
}
},
"branch-alias": {
"dev-main": "1.x-dev"
"dev-1.x": "1.x-dev"
}
},
"config": {
Expand Down