chore: add http-body-util dependency for enhanced body handling in axum-otel

iamnivekx · iamnivekx · commit ef69c804c0d4 · 2026-01-07T21:50:00.000+08:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -40,6 +40,7 @@ axum-otel = { path = "crates/axum-otel", version = "0.31.5" }
 config = { version = "0.14.0", default-features = false }
 dotenvy = { version = "0.15.7" }
 http = { version = "1.3.1" }
+http-body-util = { version = "0.1" }
 opentelemetry = { version = "0.31.0", default-features = false }
 opentelemetry-appender-tracing = { version = "0.31.0" }
 opentelemetry-http = { version = "0.31.0", default-features = false }
diff --git a/crates/axum-otel/Cargo.toml b/crates/axum-otel/Cargo.toml
@@ -19,6 +19,7 @@ tracing = { workspace = true }
 tracing-otel-extra = { workspace = true, features = ["macros"] }
 
 [dev-dependencies]
+http-body-util = { workspace = true }
 opentelemetry_sdk = { workspace = true, features = ["testing"] }
 reqwest = { workspace = true }
 tokio = { workspace = true }
diff --git a/crates/axum-otel/tests/integration.rs b/crates/axum-otel/tests/integration.rs
@@ -5,6 +5,7 @@ use axum::{
     routing::get,
 };
 use axum_otel::{AxumOtelOnFailure, AxumOtelOnResponse, AxumOtelSpanCreator, Level};
+use http_body_util::BodyExt;
 use opentelemetry::{global, trace::TracerProvider};
 use opentelemetry_sdk::{
     Resource,
@@ -52,8 +53,7 @@ async fn test_axum_otel_middleware() {
 
     let app = app();
 
-    // `Router` implements `tower::Service<Request<Body>>` so we can
-    // call it like any tower service, no need to run an HTTP server.
+    // Send request using oneshot
     let response = app
         .oneshot(
             Request::builder()
@@ -67,19 +67,55 @@ async fn test_axum_otel_middleware() {
 
     assert_eq!(response.status(), StatusCode::OK);
 
+    let body = response
+        .into_body()
+        .collect()
+        .await
+        .expect("Failed to read body");
+
+    assert_eq!(body.to_bytes(), "Hello, world!".as_bytes());
+
     // Force flush to ensure spans are exported
     let _ = provider.force_flush();
 
     // Verify spans were created
     let spans = exporter
         .get_finished_spans()
         .expect("Failed to get finished spans");
+
     assert!(
         !spans.is_empty(),
         "Expected at least one span to be created"
     );
 
-    assert!(!spans.is_empty());
-    let span = &spans[0];
-    assert_eq!(span.name, "hello");
+    // With oneshot(), there's no MatchedPath, so span name is just "GET"
+    // When using a real server, it would be "GET /"
+    let request_span = spans
+        .iter()
+        .find(|s| s.name == "GET" || s.name == "GET /")
+        .expect("Request span not found");
+
+    let hello_span = spans
+        .iter()
+        .find(|s| s.name == "hello")
+        .expect("Handler span not found");
+
+    assert_eq!(
+        hello_span.parent_span_id,
+        request_span.span_context.span_id(),
+        "Handler span should be a child of the request span"
+    );
+
+    // Check http.status_code attribute
+    let status_code_attr = request_span
+        .attributes
+        .iter()
+        .find(|kv| kv.key.as_str() == "http.status_code")
+        .map(|kv| kv.value.to_string());
+
+    assert_eq!(
+        status_code_attr,
+        Some("200".to_string()),
+        "Expected http.status_code to be 200"
+    );
 }
