Merge pull request #48 from jha929/feature/workflows

깃헙 액션을 이용한 자동화 테스트 파이프라인 구현

Author: 94929

.github/workflows/build.yml

@@ -0,0 +1,37 @@
+name: Build Status
+
+on: [push, pull_request]
+
+jobs:
+  build-ubuntu:
+    name: Build Test
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: [3.6, 3.7, 3.8, 3.9]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v2
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install -r requirements.txt
+    - name: Run unit tests
+      run: |
+        python -m pytest --cov=iamport tests
+    - name: Comment on coverage
+      uses: coroo/[email protected]
+      with:
+        pytest-coverage: .coverage
+    - name: Run convention tests
+      run: |
+        python -m flake8 iamport tests --ignore E203,W503,W504
+    - name: Run type check
+      run: |
+        python -m mypy iamport
+    - name: Run import sort check
+      run: |
+        python -m isort iamport tests --diff

iamport/client.py

@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 
 import json
+
 import requests
 
 __all__ = ['IAMPORT_API_URL', 'Iamport']
@@ -39,9 +40,13 @@ def get_response(response):
 
     def _get_token(self):
         url = '{}users/getToken'.format(self.imp_url)
-        payload = {'imp_key': self.imp_key,
-                   'imp_secret': self.imp_secret}
-        response = self.requests_session.post(url, headers={'Content-Type': 'application/json'}, data=json.dumps(payload))
+        payload = {
+            'imp_key': self.imp_key,
+            'imp_secret': self.imp_secret
+        }
+        response = self.requests_session.post(
+            url, headers={'Content-Type': 'application/json'}, data=json.dumps(payload)
+        )
         return self.get_response(response).get('access_token')
 
     def get_headers(self):
@@ -57,7 +62,7 @@ def _post(self, url, payload=None):
         headers['Content-Type'] = 'application/json'
         response = self.requests_session.post(url, headers=headers, data=json.dumps(payload))
         return self.get_response(response)
-    
+
     def _delete(self, url):
         headers = self.get_headers()
         response = self.requests_session.delete(url, headers=headers)
@@ -197,7 +202,7 @@ def prepare_validate(self, merchant_uid, amount):
         response = self._get(url)
         response_amount = response.get('amount')
         return response_amount == amount
-    
+
     def revoke_vbank_by_imp_uid(self, imp_uid):
         url = '{}vbanks/{}'.format(self.imp_url, imp_uid)
         return self._delete(url)

iamport/client.pyi

@@ -67,10 +67,10 @@ class Iamport(object):
 
     def prepare_validate(self, merchant_uid: str, amount: Amount) -> Dict: ...
 
-    def revoke_vbank_by_imp_uid(self, imp_uid: str): -> Dict: ...
+    def revoke_vbank_by_imp_uid(self, imp_uid: str) -> Dict: ...
 
-    def certification_by_imp_uid(self, imp_uid: str): -> Dict: ...
+    def certification_by_imp_uid(self, imp_uid: str) -> Dict: ...
 
-    def find_certification(self, imp_uid: str): -> Dict: ...
+    def find_certification(self, imp_uid: str) -> Dict: ...
 
-    def cancel_certification(self, imp_uid: str): -> Dict: ...
+    def cancel_certification(self, imp_uid: str) -> Dict: ...

requirements.txt

@@ -0,0 +1,7 @@
+requests==2.26.0
+pytest==6.2.4
+pytest-cov==2.12.1
+flake8==3.9.2
+isort==5.9.3
+mypy==0.910
+types-requests==2.25.6

tests/conftest.py

@@ -4,17 +4,25 @@
 from iamport import Iamport
 
 DEFAULT_TEST_IMP_KEY = 'imp_apikey'
-DEFAULT_TEST_IMP_SECRET = ('ekKoeW8RyKuT0zgaZsUtXXTLQ4AhPFW3ZGseDA6bkA5lamv9O'
-                           'qDMnxyeB9wqOsuO9W3Mx9YSJ4dTqJ3f')
+DEFAULT_TEST_IMP_SECRET = (
+    'ekKoeW8RyKuT0zgaZsUtXXTLQ4AhPFW3ZGseDA6b'
+    'kA5lamv9OqDMnxyeB9wqOsuO9W3Mx9YSJ4dTqJ3f'
+)
 
 
 def pytest_addoption(parser):
-    parser.addoption('--imp-key', default=DEFAULT_TEST_IMP_KEY,
-                     help='iamport client key for testing '
-                          '[default: %default]')
-    parser.addoption('--imp-secret', default=DEFAULT_TEST_IMP_SECRET,
-                     help='iamport secret key for testing '
-                          '[default: %default]')
+    parser.addoption(
+        '--imp-key',
+        default=DEFAULT_TEST_IMP_KEY,
+        help='iamport client key for testing '
+        '[default: %(default)s]'
+    )
+    parser.addoption(
+        '--imp-secret',
+        default=DEFAULT_TEST_IMP_SECRET,
+        help='iamport secret key for testing '
+        '[default: %(default)s]'
+    )
 
 
 @fixture

tests/test_certification.py

@@ -11,5 +11,4 @@ def test_find_certification(iamport):
 
     with pytest.raises(iamport.HttpError) as e:
         iamport.cancel_certification(imp_uid)
-        assert u'인증결과가 존재하지 않습니다.' == e.message     
-
+        assert u'인증결과가 존재하지 않습니다.' == e.message

tests/test_customer_get.py

@@ -7,4 +7,3 @@ def test_customer_get(iamport):
     with pytest.raises(iamport.ResponseError) as e:
         iamport.customer_get(customer_uid)
         assert u'요청하신 customer_uid(000000)로 등록된 정보를 찾을 수 없습니다.' == e.message
-

tests/test_pay_onetime.py

@@ -1,23 +1,35 @@
 # -*- coding: utf-8 -*-
+import random
+import string
 
 
 def test_pay_onetime(iamport):
+    merchant_uid = ''.join(
+        random.choice(string.ascii_uppercase + string.digits)
+        for _ in range(10)
+    )
+
     # Without 'card_number'
-    payload_notEnough = {
-        'merchant_uid': 'qwer1234',
+    payload_not_enough = {
+        'merchant_uid': merchant_uid,
         'amount': 5000,
         'expiry': '2019-03',
         'birth': '500203',
         'pwd_2digit': '19'
     }
 
     try:
-        iamport.pay_onetime(**payload_notEnough)
+        iamport.pay_onetime(**payload_not_enough)
     except KeyError as e:
         assert "Essential parameter is missing!: card_number" in str(e)
 
+    merchant_uid = ''.join(
+        random.choice(string.ascii_uppercase + string.digits)
+        for _ in range(10)
+    )
+
     payload_full = {
-        'merchant_uid': 'qwer1234',
+        'merchant_uid': merchant_uid,
         'amount': 5000,
         'card_number': '4092-0230-1234-1234',
         'expiry': '2019-03',

tests/test_prepare.py

@@ -1,12 +1,14 @@
 # -*- coding: utf-8 -*-
-import datetime
-import time
+import random
+import string
 
 
 def test_prepare(iamport):
     amount = 12000
-    mid = 'merchant_%d' % time.mktime(datetime.datetime.now().timetuple())
-
+    mid = ''.join(
+        random.choice(string.ascii_uppercase + string.digits)
+        for _ in range(10)
+    )
     result = iamport.prepare(merchant_uid=mid, amount=amount)
     assert result['amount'] == amount
     assert result['merchant_uid'] == mid