Skip to content
This repository was archived by the owner on May 12, 2025. It is now read-only.

Commit 48b7c49

Browse files
authored
chore: document reasons for disabling rules (#284)
1 parent 11185a9 commit 48b7c49

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lib/shared.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ module.exports = {
257257
rules: {
258258
// The following rules are enabled in Airbnb config, but are already checked (more thoroughly) by the TypeScript compiler
259259
// Some of the rules also fail in TypeScript files, for example: https://github.com/typescript-eslint/typescript-eslint/issues/662#issuecomment-507081586
260+
// Rules are inspired by: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/eslint-recommended.ts
260261
'constructor-super': 'off',
261262
'getter-return': 'off',
262263
'no-const-assign': 'off',
@@ -274,8 +275,11 @@ module.exports = {
274275
'no-unreachable': 'off',
275276
'no-unsafe-negation': 'off',
276277
'valid-typeof': 'off',
278+
// The following rules are enabled in Airbnb config, but are recommended to be disabled within TypeScript projects
279+
// See: https://github.com/typescript-eslint/typescript-eslint/blob/13583e65f5973da2a7ae8384493c5e00014db51b/docs/linting/TROUBLESHOOTING.md#eslint-plugin-import
277280
'import/named': 'off',
278281
'import/no-named-as-default-member': 'off',
282+
// The following rule has likely been incorrectly disabled. This will be fixed in a separate PR.
279283
'import/no-unresolved': 'off',
280284
},
281285
},

0 commit comments

Comments
 (0)