Merge pull request #19 from iazaran/#18-cache-flexible-not-working-as-expected

#18 cache flexible not working as expected

Author: iazaran

src/SmartCache.php

@@ -374,7 +374,7 @@ protected function determineCacheDriver($store): ?string
      * 
      * Laravel's flexible method uses: [freshTtl, staleTtl]
      * - freshTtl: seconds data is considered fresh
-     * - staleTtl: additional seconds to serve stale data while revalidating
+     * - staleTtl: absolute seconds to serve stale data while revalidating
      *
      * @param string $key
      * @param array $durations [freshTtl, staleTtl]
@@ -384,8 +384,8 @@ protected function determineCacheDriver($store): ?string
     public function flexible(string $key, array $durations, \Closure $callback): mixed
     {
         $freshTtl = $durations[0] ?? 3600;  // Default 1 hour fresh
-        $staleTtl = $durations[1] ?? 7200;  // Default 2 hours stale
-        $totalTtl = $freshTtl + $staleTtl;
+        $staleTtl = $durations[1] ?? 7200;  // Default 2 hours stale (absolute time)
+        $totalTtl = $staleTtl;
 
         // Get cached value with timestamp
         $metaKey = $key . '_sc_meta';
@@ -424,7 +424,7 @@ protected function generateAndCache(string $key, array $durations, \Closure $cal
         $value = $callback();
         $freshTtl = $durations[0] ?? 3600;
         $staleTtl = $durations[1] ?? 7200;
-        $totalTtl = $freshTtl + $staleTtl;
+        $totalTtl = $staleTtl;
 
         // Optimize the value
         $optimizedValue = $this->maybeOptimizeValue($value, $key, $totalTtl);

tests/Unit/SmartCacheTest.php

@@ -351,7 +351,7 @@ public function test_flexible_method_works_with_optimization()
         };
 
         // Laravel format: [freshTtl, staleTtl] 
-        $durations = [3600, 7200]; // Fresh for 1 hour, stale for additional 2 hours
+        $durations = [3600, 7200]; // Fresh for 1 hour, stale until 2 hours
 
         // Test the flexible method with real SmartCache instance
         $result = $this->smartCache->flexible($key, $durations, $callback);
@@ -379,7 +379,7 @@ public function test_flexible_method_fresh_data_retrieval()
             return $expectedValue . '-' . $callCount;
         };
 
-        // Fresh for 10 seconds, stale for additional 20 seconds
+        // Fresh for 10 seconds, stale until 20 seconds
         $durations = [10, 20];
 
         // First call should execute callback and cache result
@@ -403,7 +403,7 @@ public function test_flexible_method_stale_while_revalidate_behavior()
             return 'value-' . $callCount;
         };
 
-        // Fresh for 1 second, stale for additional 5 seconds
+        // Fresh for 1 second, stale until 5 seconds
         $durations = [1, 5];
 
         // Initial call
@@ -435,7 +435,7 @@ public function test_flexible_method_expired_data_regeneration()
             return 'value-' . $callCount;
         };
 
-        // Very short durations for testing: fresh for 1 second, stale for 1 additional second
+        // Very short durations for testing: fresh for 1 second, stale until 1 second (no stale period)
         $durations = [1, 1];
 
         // Initial call
@@ -513,7 +513,7 @@ public function test_flexible_method_with_optimization_integration()
             return $largeValue;
         };
 
-        $durations = [3600, 7200]; // Fresh 1h, stale 2h
+        $durations = [3600, 7200]; // Fresh 1h, stale until 2h
 
         // Test with real SmartCache instance
         $result = $this->smartCache->flexible($key, $durations, $callback);