Skip to content

Commit c3cf985

Browse files
Bruno Dusausoybdusauso
authored andcommitted
Remove 'Date' header
1 parent dc59d7f commit c3cf985

File tree

1 file changed

+5
-18
lines changed

1 file changed

+5
-18
lines changed

lib/ibanity/signature.ex

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@ defmodule Ibanity.Signature do
99

1010
def signature_headers(%HttpRequest{} = request, method, private_key, certificate_id) do
1111
parsed_uri = URI.parse(request.uri)
12-
date = now_to_string()
1312

1413
headers = [
15-
Date: date,
1614
Digest: "SHA-512=" <> payload_digest(request),
17-
Signature: generate_signature(request, method, parsed_uri, private_key, certificate_id, date)
15+
Signature: generate_signature(request, method, parsed_uri, private_key, certificate_id)
1816
]
1917

2018
{:ok, headers}
@@ -39,8 +37,8 @@ defmodule Ibanity.Signature do
3937
|> sha512sum()
4038
end
4139

42-
defp generate_signature(request, method, uri, private_key, certificate_id, date) do
43-
headers = signing_headers(request, method, uri, date)
40+
defp generate_signature(request, method, uri, private_key, certificate_id) do
41+
headers = signing_headers(request, method, uri)
4442
timestamp = DateTime.to_unix(DateTime.utc_now())
4543
signing_headers = headers |> Keyword.keys() |> Enum.join(" ")
4644
signature = headers |> Enum.join("\n") |> sign(private_key) |> Base.url_encode64()
@@ -51,15 +49,14 @@ defmodule Ibanity.Signature do
5149
~s/algorithm="#{@algorithm}"/,
5250
~s/headers="#{signing_headers}"/,
5351
~s/signature="#{signature}"/,
54-
] |> Enum.join(", ")
52+
] |> Enum.join(",")
5553
end
5654

57-
defp signing_headers(request, method, uri, date) do
55+
defp signing_headers(request, method, uri) do
5856
[]
5957
|> add_virtual_header(request, method, uri)
6058
|> add_host(request, method, uri)
6159
|> add_digest(request, method, uri)
62-
|> add_date(date)
6360
|> add_ibanity_headers(request, method, uri)
6461
|> add_authorization(request, method, uri)
6562
|> Enum.reverse()
@@ -83,10 +80,6 @@ defmodule Ibanity.Signature do
8380
Keyword.put_new(headers, :digest, "SHA-512=" <> payload_digest(request))
8481
end
8582

86-
defp add_date(headers, date) do
87-
Keyword.put_new(headers, :date, date)
88-
end
89-
9083
defp add_ibanity_headers(headers, request, _method, _uri) do
9184
ibanity_header? = fn {header, _} ->
9285
header
@@ -112,12 +105,6 @@ defmodule Ibanity.Signature do
112105
headers
113106
end
114107
end
115-
116-
defp now_to_string do
117-
DateTime.utc_now()
118-
|> DateTime.truncate(:second)
119-
|> DateTime.to_iso8601()
120-
end
121108
end
122109

123110
defimpl String.Chars, for: Tuple do

0 commit comments

Comments
 (0)