Skip to content

Commit 4f830d7

Browse files
committed
Refactored LanguageServiceTest to improve parameterization for invalid language code tests
1 parent 3306ab0 commit 4f830d7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tests/integration/Core/Repository/LanguageServiceTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,14 @@ public function testCreateLanguageWithEmptyLanguageCode(): void
141141
* @testWith ["."]
142142
* ["ąę"]
143143
* ["%^"]
144+
* ["eng 123"]
144145
*/
145-
public function testCreateLanguageWithInvalidLanguageCode(): void
146+
public function testCreateLanguageWithInvalidLanguageCode(string $languageCode): void
146147
{
147148
$languageCreate = $this->languageService->newLanguageCreateStruct();
148149
$languageCreate->enabled = true;
149150
$languageCreate->name = 'English';
150-
$languageCreate->languageCode = 'eng 123';
151+
$languageCreate->languageCode = $languageCode;
151152

152153
$this->expectException(InvalidArgumentException::class);
153154
$this->languageService->createLanguage($languageCreate);

0 commit comments

Comments
 (0)