Skip to content

Commit 65cf2fd

Browse files
authored
Dropped obsolete Debug Bundle DebugTemplate class (#357)
For more details see #357 Key changes: * Dropped obsolete Debug Bundle `DebugTemplate` class * [PHPStan] Aligned baseline with the changes
1 parent 6403884 commit 65cf2fd

File tree

5 files changed

+9
-175
lines changed

5 files changed

+9
-175
lines changed

phpstan-baseline-7.4.neon

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,6 @@ parameters:
125125
count: 1
126126
path: src/bundle/Core/Imagine/PlaceholderProvider/RemoteProvider.php
127127

128-
-
129-
message: "#^Parameter \\#1 \\$str of function trim expects string, string\\|false given\\.$#"
130-
count: 1
131-
path: src/bundle/Debug/Twig/DebugTemplate.php
132-
133128
-
134129
message: "#^Parameter \\#1 \\$fp of function fclose expects resource, resource\\|false given\\.$#"
135130
count: 1

phpstan-baseline-8.0.neon

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,6 @@ parameters:
125125
count: 2
126126
path: src/bundle/Core/URLChecker/Handler/HTTPHandler.php
127127

128-
-
129-
message: "#^Parameter \\#1 \\$string of function trim expects string, string\\|false given\\.$#"
130-
count: 1
131-
path: src/bundle/Debug/Twig/DebugTemplate.php
132-
133128
-
134129
message: "#^Parameter \\#1 \\$stream of function fclose expects resource, resource\\|false given\\.$#"
135130
count: 1

phpstan-baseline.neon

Lines changed: 0 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -4140,66 +4140,11 @@ parameters:
41404140
count: 1
41414141
path: src/bundle/Debug/DependencyInjection/Compiler/DataCollectorPass.php
41424142

4143-
-
4144-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\DependencyInjection\\\\IbexaDebugExtension\\:\\:load\\(\\) has no return type specified\\.$#"
4145-
count: 1
4146-
path: src/bundle/Debug/DependencyInjection/IbexaDebugExtension.php
4147-
4148-
-
4149-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\DependencyInjection\\\\IbexaDebugExtension\\:\\:prepend\\(\\) has no return type specified\\.$#"
4150-
count: 1
4151-
path: src/bundle/Debug/DependencyInjection/IbexaDebugExtension.php
4152-
41534143
-
41544144
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\IbexaDebugBundle\\:\\:build\\(\\) has no return type specified\\.$#"
41554145
count: 1
41564146
path: src/bundle/Debug/IbexaDebugBundle.php
41574147

4158-
-
4159-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\Twig\\\\DebugTemplate\\:\\:display\\(\\) has parameter \\$blocks with no value type specified in iterable type array\\.$#"
4160-
count: 1
4161-
path: src/bundle/Debug/Twig/DebugTemplate.php
4162-
4163-
-
4164-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\Twig\\\\DebugTemplate\\:\\:display\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#"
4165-
count: 1
4166-
path: src/bundle/Debug/Twig/DebugTemplate.php
4167-
4168-
-
4169-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\Twig\\\\DebugTemplate\\:\\:doDisplay\\(\\) has parameter \\$blocks with no value type specified in iterable type array\\.$#"
4170-
count: 1
4171-
path: src/bundle/Debug/Twig/DebugTemplate.php
4172-
4173-
-
4174-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\Twig\\\\DebugTemplate\\:\\:doDisplay\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#"
4175-
count: 1
4176-
path: src/bundle/Debug/Twig/DebugTemplate.php
4177-
4178-
-
4179-
message: "#^Parameter \\#1 \\$haystack of function stripos expects string, string\\|false\\|null given\\.$#"
4180-
count: 1
4181-
path: src/bundle/Debug/Twig/DebugTemplate.php
4182-
4183-
-
4184-
message: "#^Parameter \\#1 \\$path of function dirname expects string, string\\|false given\\.$#"
4185-
count: 1
4186-
path: src/bundle/Debug/Twig/DebugTemplate.php
4187-
4188-
-
4189-
message: "#^Parameter \\#1 \\$string of function substr expects string, string\\|false\\|null given\\.$#"
4190-
count: 2
4191-
path: src/bundle/Debug/Twig/DebugTemplate.php
4192-
4193-
-
4194-
message: "#^Parameter \\#3 \\$subject of function preg_replace expects array\\|string, string\\|false given\\.$#"
4195-
count: 1
4196-
path: src/bundle/Debug/Twig/DebugTemplate.php
4197-
4198-
-
4199-
message: "#^Property Ibexa\\\\Bundle\\\\Debug\\\\Twig\\\\DebugTemplate\\:\\:\\$fileSystem has no type specified\\.$#"
4200-
count: 1
4201-
path: src/bundle/Debug/Twig/DebugTemplate.php
4202-
42034148
-
42044149
message: "#^Method Ibexa\\\\Bundle\\\\IO\\\\ApiLoader\\\\HandlerRegistry\\:\\:setHandlersMap\\(\\) has no return type specified\\.$#"
42054150
count: 1

src/bundle/Debug/DependencyInjection/IbexaDebugExtension.php

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,21 @@
66
*/
77
namespace Ibexa\Bundle\Debug\DependencyInjection;
88

9-
use Ibexa\Bundle\Debug\Twig\DebugTemplate;
109
use Symfony\Component\Config\FileLocator;
1110
use Symfony\Component\DependencyInjection\ContainerBuilder;
12-
use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
1311
use Symfony\Component\DependencyInjection\Loader;
1412
use Symfony\Component\HttpKernel\DependencyInjection\Extension;
1513

16-
class IbexaDebugExtension extends Extension implements PrependExtensionInterface
14+
/**
15+
* @internal
16+
* @final
17+
*/
18+
class IbexaDebugExtension extends Extension
1719
{
18-
public function load(array $configs, ContainerBuilder $container)
20+
/**
21+
* @throws \Exception
22+
*/
23+
public function load(array $configs, ContainerBuilder $container): void
1924
{
2025
$loader = new Loader\YamlFileLoader(
2126
$container,
@@ -25,19 +30,6 @@ public function load(array $configs, ContainerBuilder $container)
2530
// Base services and services overrides
2631
$loader->load('services.yml');
2732
}
28-
29-
/**
30-
* Sets the twig base template class to this bundle's in order to collect template infos.
31-
*/
32-
public function prepend(ContainerBuilder $container)
33-
{
34-
if ($container->getParameter('kernel.debug')) {
35-
$container->prependExtensionConfig(
36-
'twig',
37-
['base_template_class' => DebugTemplate::class]
38-
);
39-
}
40-
}
4133
}
4234

4335
class_alias(IbexaDebugExtension::class, 'eZ\Bundle\EzPublishDebugBundle\DependencyInjection\EzPublishDebugExtension');

src/bundle/Debug/Twig/DebugTemplate.php

Lines changed: 0 additions & 93 deletions
This file was deleted.

0 commit comments

Comments
 (0)