IBX-10840: Fixed missing logger in ImageExtension #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing logger in ImageExtension by implementing LoggerAwareInterface and enabling repository-wide PHPStan checks for dynamic properties via checkDynamicProperties: true. This stricter analysis revealed several undeclared properties in tests and incorrect PHPDoc type hints in production code.
Key Changes:
- Added logger support to
ImageExtensionclass usingLoggerAwareInterfaceandLoggerAwareTrait - Enabled
checkDynamicPropertiesin PHPStan configuration to catch dynamic property usage - Corrected PHPDoc type hints in multiple field type classes to accurately reflect parameter types
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/MVC/Symfony/Templating/Twig/Extension/ImageExtension.php | Added LoggerAwareInterface implementation with LoggerAwareTrait |
| src/bundle/Core/Resources/config/templating.yml | Configured logger injection for ImageExtension service |
| phpstan.neon.dist | Enabled checkDynamicProperties check |
| phpstan-baseline.neon | Updated baseline to reflect resolved and new PHPStan issues |
| tests/lib/FieldType/Url/Gateway/DoctrineStorageTest.php | Declared $storageGateway property and refactored getter using null coalescing assignment |
| tests/lib/FieldType/ImageTest.php | Declared $mimeTypeDetectorMock property and refactored getter using null coalescing assignment |
| tests/lib/Repository/Values/User/UserTest.php | Added PHPStan ignore comment for intentional invalid property access test |
| tests/lib/Repository/Values/User/UserGroupTest.php | Added PHPStan ignore comment for intentional invalid property access test |
| tests/lib/Repository/Values/User/RoleTest.php | Added PHPStan ignore comment for intentional invalid property access test |
| tests/lib/Repository/Values/User/PolicyTest.php | Added PHPStan ignore comment for intentional invalid property access test |
| tests/lib/Repository/Values/ObjectState/ObjectStateTest.php | Added PHPStan ignore comment for intentional invalid property access test |
| tests/lib/Repository/Values/ObjectState/ObjectStateGroupTest.php | Added PHPStan ignore comment for intentional invalid property access test |
| tests/lib/Repository/Values/Content/TrashItemTest.php | Added PHPStan ignore comment for intentional invalid property access test |
| tests/lib/Repository/Values/Content/SectionTest.php | Added PHPStan ignore comment for intentional invalid property access test |
| tests/lib/Repository/Values/Content/LocationTest.php | Added PHPStan ignore comment for intentional invalid property access test |
| tests/lib/Repository/Values/Content/LanguageTest.php | Added PHPStan ignore comment for intentional invalid property access test |
| src/lib/FieldType/Validator/ImageValidator.php | Corrected PHPDoc to specify concrete Value parameter type |
| src/lib/FieldType/Selection/Type.php | Removed redundant union type from PHPDoc |
| src/lib/FieldType/RelationList/Type.php | Removed redundant union type from PHPDoc |
| src/lib/FieldType/Relation/Type.php | Removed redundant union type from PHPDoc |
| src/lib/FieldType/ImageAsset/Type.php | Removed redundant union type from PHPDoc |
| src/lib/FieldType/BinaryBase/Type.php | Removed redundant union type from PHPDoc |
| src/lib/FieldType/Author/Type.php | Added PHPDoc to getName() and corrected PHPDoc for getSortInfo() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
konradoboza
approved these changes
Oct 22, 2025
adamwojs
approved these changes
Oct 22, 2025
barw4
approved these changes
Oct 22, 2025
alongosz
reviewed
Oct 22, 2025
Steveb-p
force-pushed
the
ibx-10840/fixed-missing-logger
branch
from
c4183ec to
7e97871
Compare
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alongosz
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Fast forward (or rebase) merge
Description:
This PR fixes missing logger in
ImageExtensionby addingLoggerAwareInterface.Additionally, it enables repository-wide check against dynamic property use by enabling
checkDynamicPropertiesin PHPStan. This uncovered other places where property was missing (mostly tests though), and where property accessed was done on invalid assumptions (some phpdocs have been corrected).For QA:
Documentation: