Rename clear button components and update translations for consistency

mikadamczyk · mikadamczyk · commit 17513bdf06c8 · 2025-10-21T13:58:51.000+02:00
diff --git a/src/bundle/Resources/translations/ibexa_design_system_twig.en.xliff b/src/bundle/Resources/translations/ibexa_design_system_twig.en.xliff
@@ -6,10 +6,10 @@
       <note>The source node in most cases contains the sample message as written by the developer. If it looks like a dot-delimitted string such as "form.label.firstname", then the developer has not provided a default message.</note>
     </header>
     <body>
-      <trans-unit id="61c7070a29f932eb0b1a343509d049aa52c92c09" resname="ibexa.clear-btn.label">
+      <trans-unit id="325602325410dfc0d83e43dec9a10976368c7154" resname="ibexa.clear-button.label">
         <source>Clear</source>
         <target state="new">Clear</target>
-        <note>key: ibexa.clear-btn.label</note>
+        <note>key: ibexa.clear-button.label</note>
       </trans-unit>
       <trans-unit id="6c89c5a149a0c096f007f1774344ec53cd18bb20" resname="ibexa.expander.label.collapse">
         <source>Hide</source>
diff --git a/src/bundle/Resources/views/themes/standard/design_system/components/input_text/input.html.twig b/src/bundle/Resources/views/themes/standard/design_system/components/input_text/input.html.twig
@@ -30,7 +30,7 @@
 %}
 
 {% set clear_action %}
-    <twig:ibexa:ui:clear_btn :disabled="disabled" />
+    <twig:ibexa:ui:clear_button :disabled="disabled" />
 {% endset %}
 
 {% set actions = [
diff --git a/src/bundle/Resources/views/themes/standard/design_system/components/ui/clear_button.html.twig b/src/bundle/Resources/views/themes/standard/design_system/components/ui/clear_button.html.twig
@@ -1,6 +1,6 @@
 {% trans_default_domain 'ibexa_design_system_twig' %}
 
-{% set clear_msg = 'ibexa.clear-btn.label'|trans|desc('Clear') %}
+{% set clear_msg = 'ibexa.clear-button.label'|trans|desc('Clear') %}
 
 <twig:ibexa:button
     type="tertiary-alt"
diff --git a/src/lib/Twig/Components/UI/ClearButton.php b/src/lib/Twig/Components/UI/ClearButton.php
@@ -12,8 +12,8 @@
 use Symfony\UX\TwigComponent\Attribute\AsTwigComponent;
 use Symfony\UX\TwigComponent\Attribute\PreMount;
 
-#[AsTwigComponent('ibexa:ui:clear_btn')]
-final class ClearBtn
+#[AsTwigComponent('ibexa:ui:clear_button')]
+final class ClearButton
 {
     public bool $disabled = false;
 
diff --git a/tests/integration/Twig/Components/UI/ClearButtonTest.php b/tests/integration/Twig/Components/UI/ClearButtonTest.php
@@ -8,27 +8,27 @@
 
 namespace Ibexa\Tests\Integration\DesignSystemTwig\Twig\Components\UI;
 
-use Ibexa\DesignSystemTwig\Twig\Components\UI\ClearBtn;
+use Ibexa\DesignSystemTwig\Twig\Components\UI\ClearButton;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Symfony\Component\DomCrawler\Crawler;
 use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
 use Symfony\UX\TwigComponent\Test\InteractsWithTwigComponents;
 
-final class ClearBtnTest extends KernelTestCase
+final class ClearButtonTest extends KernelTestCase
 {
     use InteractsWithTwigComponents;
 
     public function testMount(): void
     {
-        $component = $this->mountTwigComponent(ClearBtn::class, ['disabled' => true]);
+        $component = $this->mountTwigComponent(ClearButton::class, ['disabled' => true]);
 
-        self::assertInstanceOf(ClearBtn::class, $component, 'Component should mount as UI\\ClearBtn.');
+        self::assertInstanceOf(ClearButton::class, $component, 'Component should mount as UI\\ClearButton.');
         self::assertTrue($component->disabled, 'Prop "disabled" should be true.');
     }
 
     public function testDefaultRenderProducesConfiguredButton(): void
     {
-        $crawler = $this->renderTwigComponent(ClearBtn::class)->crawler();
+        $crawler = $this->renderTwigComponent(ClearButton::class)->crawler();
 
         $button = $this->getButton($crawler);
         $class = $this->getClassAttr($button);
@@ -53,7 +53,7 @@ public function testDefaultRenderProducesConfiguredButton(): void
 
     public function testDisabledTrueAddsAttributeAndClass(): void
     {
-        $crawler = $this->renderTwigComponent(ClearBtn::class, ['disabled' => true])->crawler();
+        $crawler = $this->renderTwigComponent(ClearButton::class, ['disabled' => true])->crawler();
 
         $button = $this->getButton($crawler);
         $class = $this->getClassAttr($button);
@@ -65,7 +65,7 @@ public function testDisabledTrueAddsAttributeAndClass(): void
     public function testInvalidDisabledTypeCausesResolverErrorOnMount(): void
     {
         $this->expectException(InvalidOptionsException::class);
-        $this->mountTwigComponent(ClearBtn::class, ['disabled' => 'yes']);
+        $this->mountTwigComponent(ClearButton::class, ['disabled' => 'yes']);
     }
 
     private function getButton(Crawler $crawler): Crawler

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,8 @@`
`12`	`12`	`use Symfony\UX\TwigComponent\Attribute\AsTwigComponent;`
`13`	`13`	`use Symfony\UX\TwigComponent\Attribute\PreMount;`
`14`	`14`
`15`		`-#[AsTwigComponent('ibexa:ui:clear_btn')]`
`16`		`-final class ClearBtn`
	`15`	`+#[AsTwigComponent('ibexa:ui:clear_button')]`
	`16`	`+final class ClearButton`
`17`	`17`	`{`
`18`	`18`	`public bool $disabled = false;`
`19`	`19`
Original file line number	Diff line number	Diff line change
`@@ -8,27 +8,27 @@`
`8`	`8`
`9`	`9`	`namespace Ibexa\Tests\Integration\DesignSystemTwig\Twig\Components\UI;`
`10`	`10`
`11`		`-use Ibexa\DesignSystemTwig\Twig\Components\UI\ClearBtn;`
	`11`	`+use Ibexa\DesignSystemTwig\Twig\Components\UI\ClearButton;`
`12`	`12`	`use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;`
`13`	`13`	`use Symfony\Component\DomCrawler\Crawler;`
`14`	`14`	`use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;`
`15`	`15`	`use Symfony\UX\TwigComponent\Test\InteractsWithTwigComponents;`
`16`	`16`
`17`		`-final class ClearBtnTest extends KernelTestCase`
	`17`	`+final class ClearButtonTest extends KernelTestCase`
`18`	`18`	`{`
`19`	`19`	`use InteractsWithTwigComponents;`
`20`	`20`
`21`	`21`	`public function testMount(): void`
`22`	`22`	`{`
`23`		`- $component = $this->mountTwigComponent(ClearBtn::class, ['disabled' => true]);`
	`23`	`+ $component = $this->mountTwigComponent(ClearButton::class, ['disabled' => true]);`
`24`	`24`
`25`		`- self::assertInstanceOf(ClearBtn::class, $component, 'Component should mount as UI\\ClearBtn.');`
	`25`	`+ self::assertInstanceOf(ClearButton::class, $component, 'Component should mount as UI\\ClearButton.');`
`26`	`26`	`self::assertTrue($component->disabled, 'Prop "disabled" should be true.');`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`public function testDefaultRenderProducesConfiguredButton(): void`
`30`	`30`	`{`
`31`		`- $crawler = $this->renderTwigComponent(ClearBtn::class)->crawler();`
	`31`	`+ $crawler = $this->renderTwigComponent(ClearButton::class)->crawler();`
`32`	`32`
`33`	`33`	`$button = $this->getButton($crawler);`
`34`	`34`	`$class = $this->getClassAttr($button);`
`@@ -53,7 +53,7 @@ public function testDefaultRenderProducesConfiguredButton(): void`
`53`	`53`
`54`	`54`	`public function testDisabledTrueAddsAttributeAndClass(): void`
`55`	`55`	`{`
`56`		`- $crawler = $this->renderTwigComponent(ClearBtn::class, ['disabled' => true])->crawler();`
	`56`	`+ $crawler = $this->renderTwigComponent(ClearButton::class, ['disabled' => true])->crawler();`
`57`	`57`
`58`	`58`	`$button = $this->getButton($crawler);`
`59`	`59`	`$class = $this->getClassAttr($button);`
`@@ -65,7 +65,7 @@ public function testDisabledTrueAddsAttributeAndClass(): void`
`65`	`65`	`public function testInvalidDisabledTypeCausesResolverErrorOnMount(): void`
`66`	`66`	`{`
`67`	`67`	`$this->expectException(InvalidOptionsException::class);`
`68`		`- $this->mountTwigComponent(ClearBtn::class, ['disabled' => 'yes']);`
	`68`	`+ $this->mountTwigComponent(ClearButton::class, ['disabled' => 'yes']);`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`private function getButton(Crawler $crawler): Crawler`