Skip to content

Commit 20da969

Browse files
committed
Refactor translation keys and update dropdown placeholder
1 parent f4c44fc commit 20da969

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/bundle/Resources/translations/ibexa_design_system_twig.en.xliff

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111
<target state="new">Delete</target>
1212
<note>key: ibexa.chip.delete-btn.label</note>
1313
</trans-unit>
14-
<trans-unit id="61c7070a29f932eb0b1a343509d049aa52c92c09" resname="ibexa.clear-btn.label">
14+
<trans-unit id="325602325410dfc0d83e43dec9a10976368c7154" resname="ibexa.clear-button.label">
1515
<source>Clear</source>
1616
<target state="new">Clear</target>
17-
<note>key: ibexa.clear-btn.label</note>
17+
<note>key: ibexa.clear-button.label</note>
1818
</trans-unit>
1919
<trans-unit id="8bd385b5e5cc2e1edee94e57245b6d8a42f50aac" resname="ibexa.dropdown.placeholder">
2020
<source>Select an item</source>
@@ -36,6 +36,11 @@
3636
<target state="new">Show</target>
3737
<note>key: ibexa.expander.label.expand</note>
3838
</trans-unit>
39+
<trans-unit id="0af0c0b3e944e524dba4b327905685b9300f40e4" resname="ids.dropdown.placeholder">
40+
<source>Select an item</source>
41+
<target state="new">Select an item</target>
42+
<note>key: ids.dropdown.placeholder</note>
43+
</trans-unit>
3944
</body>
4045
</file>
4146
</xliff>

src/lib/Twig/Components/AbstractDropdown.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@
2424
*/
2525
abstract class AbstractDropdown
2626
{
27-
private const string TRANSLATION_DOMAIN = 'ibexa_design_system_twig';
28-
2927
public string $name;
3028

3129
public bool $disabled = false;
@@ -75,7 +73,7 @@ public function validate(array $props): array
7573
/** @Desc("Select an item") */
7674
'ids.dropdown.placeholder',
7775
[],
78-
self::TRANSLATION_DOMAIN
76+
'ibexa_design_system_twig'
7977
)
8078
);
8179
$resolver

0 commit comments

Comments
 (0)