Refactor Input and AbstractDropdown classes for improved type safety and code clarity

Author: mikadamczyk

src/lib/Twig/Components/AbstractDropdown.php

@@ -17,22 +17,22 @@
 use Symfony\UX\TwigComponent\Attribute\PreMount;
 
 /**
- * @phpstan-type DropdownItem array{
+ * @phpstan-type TDropdownItem array{
  *     id: string,
  *     label: string
  * }
  */
 abstract class AbstractDropdown
 {
-    private const TRANSLATION_DOMAIN = 'ibexa_design_system_twig';
+    private const string TRANSLATION_DOMAIN = 'ibexa_design_system_twig';
 
     public string $name;
 
     public bool $disabled = false;
 
     public bool $error = false;
 
-    /** @var array<DropdownItem> */
+    /** @var array<TDropdownItem> */
     public array $items = [];
 
     public string $placeholder;
@@ -100,7 +100,7 @@ abstract protected function configurePropsResolver(OptionsResolver $resolver): v
      * @param Options<array<string, mixed>> $options
      * @param array<int, mixed> $items
      *
-     * @return array<int, DropdownItem>
+     * @return array<int, TDropdownItem>
      */
     private static function normalizeItems(Options $options, array $items): array
     {
@@ -112,7 +112,7 @@ private static function normalizeItems(Options $options, array $items): array
             ->setAllowedTypes('label', 'string');
 
         foreach ($items as $index => $item) {
-            if (!\is_array($item)) {
+            if (!is_array($item)) {
                 throw new InvalidOptionsException(
                     sprintf(
                         'Each dropdown item must be an array, "%s" given at index %d.',
@@ -122,9 +122,7 @@ private static function normalizeItems(Options $options, array $items): array
                 );
             }
 
-            $resolvedItem = $itemResolver->resolve($item);
-
-            $items[$index] = $resolvedItem;
+            $items[$index] = $itemResolver->resolve($item);
         }
 
         return $items;

src/lib/Twig/Components/DropdownSingle/Input.php

@@ -31,7 +31,7 @@ public function postMount(): void
     public function getSelectedLabel(): string
     {
         $value = $this->value ?? '';
-        $selected_item = array_find($this->items, static function (array $item) use ($value) {
+        $selected_item = array_find($this->items, static function (array $item) use ($value): bool {
             return $item['id'] === $value;
         });