Skip to content

Commit 0d36c5d

Browse files
adriendupuismnocon
andauthored
Apply suggestions from code review
Co-authored-by: Marek Nocoń <[email protected]>
1 parent 74a5594 commit 0d36c5d

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

docs/content_management/field_types/field_type_reference/field_type_reference.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ In addition, it's possible to extend the system by creating custom types for spe
1818

1919
For general field type documentation, see [field type](field_types.md).
2020

21-
Custom field types have to be programmed in PHP. However, the built-in field types are usually enough for typical scenarios.
21+
Custom field types have to be programmed in PHP.
22+
However, the built-in field types are usually enough for typical scenarios.
2223
The following table gives an overview of the supported field types that come with [[= product_name =]].
2324

2425
## Available field types

docs/content_management/field_types/field_type_reference/imagefield.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ They're `Ibexa\Contracts\Core\Variation\Values\ImageVariation` objects with the
3939

4040
| Property | Type | Example | Description |
4141
|----------------|----------|--------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------|
42-
| `width`* | int | `200` | The variation's width in pixels. For more details see Caution note below. |
43-
| `height`* | int | `112` | The variation's height in pixels. For more details see Caution note below. |
42+
| `width` | int | `200` | The variation's width in pixels. For more details see Caution note below. |
43+
| `height` | int | `112` | The variation's height in pixels. For more details see Caution note below. |
4444
| `name` | string | `medium` | The variation's identifier, name of the image variation. |
4545
| `info` | mixed | n/a | Extra information about the image, depending on the image type, such as EXIF data. If there is no information, the `info` value is `null`. |
4646
| `fileSize` | int | `31010` | Size (in byte) of current variation. |

docs/content_management/field_types/field_type_reference/productspecificationfield.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,14 @@ month_change: true
66
# Product specification field type
77

88
This field represents and handles [product attributes](products.md#product-attributes) and [VAT](prices.md#vat).
9-
Consider it as internal to the [PIM](pim.md).
9+
Consider it as internal to the [PIM](pim.md).
1010

1111
| Name | Internal name | Expected input |
1212
|------------------------|-------------------------------|----------------|
1313
| `ProductSpecification` | `ibexa_product_specification` | mixed |
1414

1515
!!! caution
1616

17-
The presence of a specification (`ibexa_product_specification`) field is what distinct product type from content type.
17+
The presence of a specification (`ibexa_product_specification`) field distincts product types from content types.
1818
Don't remove this field from a product type (or it becomes a unreachable hidden content type).
1919
Don't add such field to a content type (or it becomes an uneditable unusable product type).
20-
You can't have more than one `ibexa_product_specification`, the laters won't be editable.

0 commit comments

Comments
 (0)